* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
@ 2012-02-13 11:11 ` rguenth at gcc dot gnu.org
2012-02-13 15:29 ` LpSolit at netscape dot net
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-02-13 11:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2012-02-13
Ever Confirmed|0 |1
--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-02-13 11:11:08 UTC ---
Confirmed.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
2012-02-13 11:11 ` [Bug web/52228] " rguenth at gcc dot gnu.org
@ 2012-02-13 15:29 ` LpSolit at netscape dot net
2012-02-13 15:32 ` LpSolit at netscape dot net
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: LpSolit at netscape dot net @ 2012-02-13 15:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Frédéric Buclin <LpSolit at netscape dot net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|unassigned at gcc dot |LpSolit at netscape dot net
|gnu.org |
Severity|normal |minor
--- Comment #2 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 15:29:25 UTC ---
My regexp explicitly forbirds / right before PR.... but I cannot remember why:
qr/(?<!\/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
I will drop this restriction, but will bring it back if it appears there was a
good reason to do so. :)
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
2012-02-13 11:11 ` [Bug web/52228] " rguenth at gcc dot gnu.org
2012-02-13 15:29 ` LpSolit at netscape dot net
@ 2012-02-13 15:32 ` LpSolit at netscape dot net
2012-02-13 15:40 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: LpSolit at netscape dot net @ 2012-02-13 15:32 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Frédéric Buclin <LpSolit at netscape dot net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #3 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 15:31:48 UTC ---
Note to self: I didn't update the tarball with this change.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (2 preceding siblings ...)
2012-02-13 15:32 ` LpSolit at netscape dot net
@ 2012-02-13 15:40 ` redi at gcc dot gnu.org
2012-02-13 15:41 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: redi at gcc dot gnu.org @ 2012-02-13 15:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-13 15:39:57 UTC ---
(In reply to comment #2)
> My regexp explicitly forbirds / right before PR.... but I cannot remember why
maybe so it doesn't catch external links like http://sourceware.org/PR123 ?
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (3 preceding siblings ...)
2012-02-13 15:40 ` redi at gcc dot gnu.org
@ 2012-02-13 15:41 ` redi at gcc dot gnu.org
2012-02-13 15:44 ` redi at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: redi at gcc dot gnu.org @ 2012-02-13 15:41 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-13 15:40:36 UTC ---
(In reply to comment #4)
> (In reply to comment #2)
> > My regexp explicitly forbirds / right before PR.... but I cannot remember why
>
> maybe so it doesn't catch external links like http://sourceware.org/0 ?
yeah, that'll be it :) that was entered as sourceware.org / P R 1 2 3 (without
spaces) and got mangled
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (4 preceding siblings ...)
2012-02-13 15:41 ` redi at gcc dot gnu.org
@ 2012-02-13 15:44 ` redi at gcc dot gnu.org
2012-02-13 16:00 ` LpSolit at netscape dot net
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: redi at gcc dot gnu.org @ 2012-02-13 15:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-13 15:44:21 UTC ---
as shown at http://gcc.gnu.org/ml/gcc-bugs/2012-02/msg01317.html
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (5 preceding siblings ...)
2012-02-13 15:44 ` redi at gcc dot gnu.org
@ 2012-02-13 16:00 ` LpSolit at netscape dot net
2012-02-13 16:17 ` burnus at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: LpSolit at netscape dot net @ 2012-02-13 16:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Frédéric Buclin <LpSolit at netscape dot net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |ASSIGNED
Resolution|FIXED |
--- Comment #7 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 15:59:50 UTC ---
(In reply to comment #5)
> yeah, that'll be it :)
Ah, right! That was the reason I explicitly excluded / right before PR. So I
guess the problem described in comment 0 is minor enough to let it unfixed. Any
objection?
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (6 preceding siblings ...)
2012-02-13 16:00 ` LpSolit at netscape dot net
@ 2012-02-13 16:17 ` burnus at gcc dot gnu.org
2012-02-13 16:24 ` LpSolit at netscape dot net
2012-02-13 17:51 ` LpSolit at netscape dot net
9 siblings, 0 replies; 11+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-02-13 16:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |burnus at gcc dot gnu.org
--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-02-13 16:17:21 UTC ---
(In reply to comment #2)
> My regexp explicitly forbirds / right before PR.... but I cannot remember why:
> qr/(?<!\/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
> I will drop this restriction, but will bring it back if it appears there was a
> good reason to do so. :)
Best would be a pattern, which only prohibits "http(s):"[nonwhitespace]/PR".
(In reply to comment #7)
> Ah, right! That was the reason I explicitly excluded / right before PR. So I
> guess the problem described in comment 0 is minor enough to let it unfixed. Any
> objection?
For the issue of comment 0, allowing "[0-9]/PR" should probably be safe.
However, one also finds: "middle-end/PR1234" (for those which mistype "PR
middle-end/1234").
Regarding comment 0, how about such a pattern:
qr/(?<!\D/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
^^
Plus a comment, which explains why one has that pattern ...
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (7 preceding siblings ...)
2012-02-13 16:17 ` burnus at gcc dot gnu.org
@ 2012-02-13 16:24 ` LpSolit at netscape dot net
2012-02-13 17:51 ` LpSolit at netscape dot net
9 siblings, 0 replies; 11+ messages in thread
From: LpSolit at netscape dot net @ 2012-02-13 16:24 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
--- Comment #9 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 16:24:20 UTC ---
(In reply to comment #8)
> Regarding comment 0, how about such a pattern:
>
> qr/(?<!\D/)\b(pr(?:\s*|\s+\S+\/)(\d+)(?:\s+comment\s+(\d+))?)/i
This is just a hack. Not a good idea.
> Best would be a pattern, which only prohibits "http(s):"[nonwhitespace]/PR".
Of course, but negative look-behind assertions only accept fixed-width strings.
Else I would simply look for :// in the string. I have a workaround which I'm
discussing upstream.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug web/52228] Bugzilla: Missing link for "PR...."
2012-02-13 9:43 [Bug web/52228] New: Bugzilla: Missing link for "PR...." burnus at gcc dot gnu.org
` (8 preceding siblings ...)
2012-02-13 16:24 ` LpSolit at netscape dot net
@ 2012-02-13 17:51 ` LpSolit at netscape dot net
9 siblings, 0 replies; 11+ messages in thread
From: LpSolit at netscape dot net @ 2012-02-13 17:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52228
Frédéric Buclin <LpSolit at netscape dot net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #10 from Frédéric Buclin <LpSolit at netscape dot net> 2012-02-13 17:51:21 UTC ---
Here we go!
^ permalink raw reply [flat|nested] 11+ messages in thread