public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "gjl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug other/52278] New: [avr] inefficient register allocation for SUBREGs Date: Thu, 16 Feb 2012 14:05:00 -0000 [thread overview] Message-ID: <bug-52278-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52278 Bug #: 52278 Summary: [avr] inefficient register allocation for SUBREGs Classification: Unclassified Product: gcc Version: 4.7.0 Status: UNCONFIRMED Keywords: missed-optimization, ra Severity: normal Priority: P3 Component: other AssignedTo: unassigned@gcc.gnu.org ReportedBy: gjl@gcc.gnu.org Target: avr Suppose the following small function compiled for AVR. Remember AVR is 8-bit machine with int = HImode and UNITS_PER_WORD = 1. int add (int val) { return val + 1; } The addition can be performed in one insn; val and return value are passed in HI:24 as you can see in .ira dump: (insn 6 3 19 2 (parallel [ (set (reg:HI 45) (plus:HI (reg:HI 24 r24 [ val ]) (const_int 1 [0x1]))) (clobber (scratch:QI)) ]) add.c:3 42 {addhi3_clobber} (expr_list:REG_DEAD (reg:HI 24 r24 [ val ]) (nil))) (insn 19 6 20 2 (set (reg:QI 24 r24) (subreg:QI (reg:HI 45) 0)) add.c:4 18 {movqi_insn} (nil)) (insn 20 19 14 2 (set (reg:QI 25 r25 [+1 ]) (subreg:QI (reg:HI 45) 1)) add.c:4 18 {movqi_insn} (expr_list:REG_DEAD (reg:HI 45) (nil))) (insn 14 20 0 2 (use (reg/i:HI 24 r24)) add.c:4 -1 (nil)) IRA writes: Pushing a0(r45,l0)(cost 0) Popping a0(r45,l0) -- assign reg 18 Disposition: 0:r45 l0 18 i.e. it assigns pseudo HI:45 to hard register HI:18 and thus causes inefficient code because it happily moves values around without need. .reload generates additional move insns to satisfy the constraints of addhi3 which are basically "=r, %0, rn" i.e. addition is a 2-operand insn where op0 and op1 must be in the same hard register: (insn 23 3 6 2 (set (reg:HI 18 r18 [45]) (reg:HI 24 r24 [ val ])) add.c:3 22 {*movhi} (nil)) (insn 6 23 19 2 (parallel [ (set (reg:HI 18 r18 [45]) (plus:HI (reg:HI 18 r18 [45]) (const_int 1 [0x1]))) (clobber (scratch:QI)) ]) add.c:3 42 {addhi3_clobber} (nil)) (insn 19 6 20 2 (set (reg:QI 24 r24) (reg:QI 18 r18 [45])) add.c:4 18 {movqi_insn} (nil)) (insn 20 19 14 2 (set (reg:QI 25 r25 [+1 ]) (reg:QI 19 r19 [+1 ])) add.c:4 18 {movqi_insn} (nil)) However, the machine could just as well do the addition in HI:24 directly like so: (parallel [(set (reg:HI 24 r24) (plus:HI (reg:HI 24) (const_int 1))) (clobber (scratch:QI))]) {addhi3_clobber} The code above is just a small example to show the problem, but the issue also occurs with more complex code and not only for return and parameter registers. == Command line == avr-gcc add.c -c -mmcu=avr4 -Os -save-temps -dp -da == configure == ../../gcc.gnu.org/trunk/configure --target=avr --prefix=/local/gnu/install/gcc-4.7 --disable-nls --enable-languages=c,c++ --with-dwarf2 --enable-checking=yes,rtl Thread model: single gcc version 4.7.0 20120206 (experimental) (GCC)
next reply other threads:[~2012-02-16 14:04 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-02-16 14:05 gjl at gcc dot gnu.org [this message] 2012-02-16 14:16 ` [Bug other/52278] " gjl at gcc dot gnu.org 2012-02-16 14:19 ` gjl at gcc dot gnu.org 2012-02-16 14:23 ` gjl at gcc dot gnu.org 2012-02-16 14:31 ` gjl at gcc dot gnu.org 2012-02-28 9:12 ` gjl at gcc dot gnu.org 2012-07-27 17:24 ` wvangulik at xs4all dot nl 2012-10-21 20:54 ` gjl at gcc dot gnu.org 2013-02-08 15:37 ` [Bug other/52278] [4.7/4.8 Regression] " rguenth at gcc dot gnu.org 2013-04-11 7:58 ` [Bug other/52278] [4.7/4.8/4.9 " rguenth at gcc dot gnu.org 2014-06-12 13:42 ` [Bug other/52278] [4.7/4.8/4.9/4.10 " rguenth at gcc dot gnu.org 2014-10-07 17:13 ` [Bug other/52278] [4.8/4.9/5 " gjl at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-52278-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).