public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/52321] poor diagnostic of invalid cast
Date: Tue, 21 Feb 2012 15:59:00 -0000	[thread overview]
Message-ID: <bug-52321-4-3w7qiDrv3B@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52321-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52321

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-02-21 15:53:10 UTC ---
Yep, it's build_static_cast_1 in typeck.c

But currently that has no way to store or pass back a message (just a boolean
indicating success or failure and the result of the cast) and would need a lot
of restructuring.

if (target is pointer or reference
    && source is class type
    && target is class type
    && (target is rvalue || source is lvalue)
    && target is derived from source
    && can convert
    && at least as qualified)

Your example fails the "target is derived from source" test, but that test
doesn't say it failed because the type is incomplete, it just returns false. 
And the "can convert" step might fail for a number of reasons, but again it
just returns a boolean.

Modifying that to report different reasons (rather than just evaluating to
'false') is not simple.


  parent reply	other threads:[~2012-02-21 15:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21  1:36 [Bug c++/52321] New: " igodard at pacbell dot net
2012-02-21 11:18 ` [Bug c++/52321] " redi at gcc dot gnu.org
2012-02-21 15:38 ` igodard at pacbell dot net
2012-02-21 15:59 ` redi at gcc dot gnu.org [this message]
2012-02-21 17:41 ` igodard at pacbell dot net
2012-02-22 16:15 ` manu at gcc dot gnu.org
2015-03-03 10:19 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-52321-4-3w7qiDrv3B@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).