[Bug libstdc++/52456] New: FAIL: libstdc++-abi/abi_check

[Bug libstdc++/52456] New: FAIL: libstdc++-abi/abi_check

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

             Bug #: 52456
           Summary: FAIL: libstdc++-abi/abi_check
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: hppa-unknown-linux-gnu
            Target: hppa-unknown-linux-gnu
             Build: hppa-unknown-linux-gnu


=== libstdc++-v3 check-abi Summary ===

# of added symbols:              325
# of missing symbols:            0
# of undesignated symbols:       2
# of incompatible symbols:       302
using: baseline_symbols.txt
FAIL: libstdc++-abi/abi_check

dave@mx3210:~/gnu/gcc/objdir/gcc$ ./xgcc -B./ -v 
Reading specs from ./specs
COLLECT_GCC=./xgcc
COLLECT_LTO_WRAPPER=./lto-wrapper
Target: hppa-linux-gnu
Configured with: ../gcc/configure --with-arch=2.0 --with-gnu-as --with-gnu-ld
--enable-shared --enable-multiarch --with-multiarch-defaults=hppa-linux-gnu
--enable-linker-build-id --build=hppa-linux-gnu --host=hppa-linux-gnu
--target=hppa-linux-gnu --prefix=/home/dave/opt/gnu/gcc/gcc-4.7.0
--with-local-prefix=/home/dave/opt/gnu --enable-threads=posix
--enable-__cxa_atexit --build=hppa-linux-gnu --enable-clocale=gnu
--enable-java-gc=boehm --without-cloog --without-ppl
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada,lto
Thread model: posix
gcc version 4.7.0 20120301 (experimental) [trunk revision 184680] (GCC)

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ro at CeBiTec dot
                   |                            |Uni-Bielefeld.DE

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-03-02 16:47:44 UTC ---
And the undesignated symbols are...? Is the issue recent?

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2012-03-02 16:56:23 UTC ---
> --- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-03-02 16:47:44 UTC ---
> And the undesignated symbols are...? Is the issue recent?

I suppose the symbols are from GLIBCXX_3.4.16.  If (as has been the case
for Solaris until very recently) the HP-PA Linux baselines were only
updated immediately before a minor (X.Y.0) release, the only contain
symbols up to GLIBCXX_3.4.15, which was how 4.6.0 was released.
check_abi (incorrectly IMO) flags GLIBCXX_3.4.16 symbols as
incompatible.

    Rainer

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkoz at gcc dot gnu.org, ro
                   |                            |at gcc dot gnu.org

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> 2012-03-02 16:58:37 UTC ---
Benjamin, what do you think?

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-03-02 17:00:17 UTC ---
Indeed (sorry) the "troublesome" (ie, leading to FAIL) symbols seem the <added>
ones, on x86_64-linux too we have two <undesignated> and no FAIL.

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-03-02 17:03:22 UTC ---
(by the way, while we are at it, on x86_64-linux I also currently have 1
<added>, no FAIL, when building --enable-libstdcxx-time=rt, I suppose it's
fine)

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #6 from dave.anglin at bell dot net 2012-03-03 00:05:34 UTC ---
On 2-Mar-12, at 11:47 AM, paolo.carlini at oracle dot com wrote:

> And the undesignated symbols are...? Is the issue recent?


Attached is the symbol diff.  The undesignated symbols are:

2 undesignated symbols
0
_ZSt11__once_call
std::__once_call
version status: compatible
GLIBCXX_3.4.11
type: tls
type size: 4
status: undesignated

1
_ZSt15__once_callable
std::__once_callable
version status: compatible
GLIBCXX_3.4.11
type: tls
type size: 4
status: undesignated

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[bkoz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #7 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-03-09 18:46:52 UTC ---

Hey all. Undesignated are optionally-added symbols (like tls) that are
configure or platform dependant and so are not set into the baselines. This is
new.

They are not FAIL. It's the incompatible symbols that are making this FAIL.

As of the fix for 52191, abi_check assumes that baseline_symbols.txt file is
current as per the last release. For the 4.7.0 release, this means:

Current in 4.7.0:
GLIBCXX_3.4.17, CXXABI_1.3.6, CXXABI_TM_1

It seems as if HPPA-linux baselines are in no way current. Looking back at the
repository, the last time this file was updated for hppa was jan 2009.
(gcc-4.3/4.4 ish)

>From your diff, hppa-linux is adding into:

+OBJECT:0:CXXABI_1.3.3
+OBJECT:0:CXXABI_1.3.4
+OBJECT:0:CXXABI_1.3.5
+OBJECT:0:CXXABI_1.3.6

GLIBCXX_3.4.11
GLIBCXX_3.4.12
GLIBCXX_3.4.13
GLIBCXX_3.4.14
GLIBCXX_3.4.15
GLIBCXX_3.4.16
GLIBCXX_3.4.17

Which is every release post 4.3.x, starting with 4.4. So, this could make
sense.

None of the symbol additions for hppa-linux diverge from x86-linux in name or
version, so this seems ok to me if you just want to update the hppa-linux
baselines to 4.7.0 exports. 

Once you update the trunk hppa baselines, abi_check will stop failing.

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #8 from John David Anglin <danglin at gcc dot gnu.org> 2012-03-10 21:23:55 UTC ---
Author: danglin
Date: Sat Mar 10 21:23:51 2012
New Revision: 185181

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185181
Log:
    PR libstdc++/52456
    * config/abi/post/hppa-linux-gnu/baseline_symbols.txt: Update.


Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/config/abi/post/hppa-linux-gnu/baseline_symbols.txt

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

--- Comment #9 from John David Anglin <danglin at gcc dot gnu.org> 2012-03-10 22:57:49 UTC ---
Author: danglin
Date: Sat Mar 10 22:57:45 2012
New Revision: 185185

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185185
Log:
    PR libstdc++/52456
    * config/abi/post/hppa-linux-gnu/baseline_symbols.txt: Update.


Modified:
    branches/gcc-4_7-branch/libstdc++-v3/ChangeLog
   
branches/gcc-4_7-branch/libstdc++-v3/config/abi/post/hppa-linux-gnu/baseline_symbols.txt

[Bug libstdc++/52456] FAIL: libstdc++-abi/abi_check

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52456

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from John David Anglin <danglin at gcc dot gnu.org> 2012-03-10 23:00:21 UTC ---
Fixed.