[Bug c++/52465] New: g++ rejects valid code with in-class using declaration

[Bug c++/52465] New: g++ rejects valid code with in-class using declaration

[vanboxem.ruben at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

             Bug #: 52465
           Summary: g++ rejects valid code with in-class using declaration
    Classification: Unclassified
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: vanboxem.ruben@gmail.com


This code is rejected by GCC 4.7 (built 2/25), but accepted by everything else:

class A
{
protected:
  struct B {};
};

class C : A
{
protected:
  using A::B;

  struct D : public B {};
};

This prevents WebKit compilation where a similar construct is used.

[Bug c++/52465] g++ rejects valid code with in-class using declaration

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jason at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-03 10:10:05 UTC ---
Started with http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181359
Whether the code is valid or not I'll leave to Jason.

[Bug c++/52465] [4.7 regression] g++ rejects valid code with in-class using declaration

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-03-03
                 CC|                            |fabien at gcc dot gnu.org
            Summary|g++ rejects valid code with |[4.7 regression] g++
                   |in-class using declaration  |rejects valid code with
                   |                            |in-class using declaration
     Ever Confirmed|0                           |1

--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> 2012-03-03 22:30:55 UTC ---
Yes, that's valid.  Fabien, can you take a look?

[Bug c++/52465] [4.7 regression] g++ rejects valid code with in-class using declaration

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

fabien at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from fabien at gcc dot gnu.org 2012-03-04 18:42:28 UTC ---
(In reply to comment #2)
> Yes, that's valid.  Fabien, can you take a look?

Yes, of course.

[Bug c++/52465] [4.7 regression] g++ rejects valid code with in-class using declaration

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

--- Comment #4 from fabien at gcc dot gnu.org 2012-03-04 21:52:15 UTC ---
This is because some USING_DECLs are stored in IDENTIDIER_BINDINGs. Jason, do
you agree that cxx_binding->value and cxx_binding->type should not be
USING_DECLs ?

[Bug c++/52465] [4.7 regression] g++ rejects valid code with in-class using declaration

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

fabien at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |fabien at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #5 from fabien at gcc dot gnu.org 2012-03-08 20:41:06 UTC ---
(In reply to comment #4)
> This is because some USING_DECLs are stored in IDENTIDIER_BINDINGs. Jason, do
> you agree that cxx_binding->value and cxx_binding->type should not be
> USING_DECLs ?

Nonsense, it cannot works. I am testing a patch...

[Bug c++/52465] [4.7/4.8 regression] g++ rejects valid code with in-class using declaration

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.1
            Summary|[4.7 regression] g++        |[4.7/4.8 regression] g++
                   |rejects valid code with     |rejects valid code with
                   |in-class using declaration  |in-class using declaration

[Bug c++/52465] [4.7/4.8 regression] g++ rejects valid code with in-class using declaration

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

--- Comment #6 from fabien at gcc dot gnu.org 2012-04-11 20:40:58 UTC ---
Author: fabien
Date: Wed Apr 11 20:40:51 2012
New Revision: 186355

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186355
Log:
gcc/testsuite/ChangeLog

2012-04-09  Fabien Chêne  <fabien@gcc.gnu.org>

    PR c++/52465
    * g++.dg/lookup/using52.C: New.

gcc/cp/ChangeLog

2012-04-09  Fabien Chêne  <fabien@gcc.gnu.org>

    PR c++/52465
    * parser.c (cp_parser_class_name): Call strip_using_decl and
    return the target decl.
    * name-lookup.c (strip_using_decl): Returns NULL_TREE if the decl
    to be stripped is NULL_TREE.
    (qualify_lookup): Call strip_using_decl and perform some checks on
    the target decl.

Added:
    trunk/gcc/testsuite/g++.dg/lookup/using52.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/name-lookup.c
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/52465] [4.7 Regression] g++ rejects valid code with in-class using declaration

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
      Known to work|                            |4.8.0
            Summary|[4.7/4.8 regression] g++    |[4.7 Regression] g++
                   |rejects valid code with     |rejects valid code with
                   |in-class using declaration  |in-class using declaration

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-13 12:56:24 UTC ---
Fixed on trunk sofar.

[Bug c++/52465] [4.7 Regression] g++ rejects valid code with in-class using declaration

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

--- Comment #8 from fabien at gcc dot gnu.org 2012-04-15 20:22:47 UTC ---
Author: fabien
Date: Sun Apr 15 20:22:44 2012
New Revision: 186473

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186473
Log:
2012-04-15  Fabien Chêne  <fabien@gcc.gnu.org>

    PR c++/52465
    * g++.dg/lookup/using52.C: New.

gcc/cp/ChangeLog

2012-04-15  Fabien Chêne  <fabien@gcc.gnu.org>

    PR c++/52465
    * parser.c (cp_parser_class_name): Call strip_using_decl and
    return the target decl.
    * name-lookup.c (strip_using_decl): Returns NULL_TREE if the decl
    to be stripped is NULL_TREE.
    (qualify_lookup): Call strip_using_decl and perform some checks on
    the target decl.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/lookup/using52.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/ChangeLog
    branches/gcc-4_7-branch/gcc/cp/name-lookup.c
    branches/gcc-4_7-branch/gcc/cp/parser.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug c++/52465] [4.7 Regression] g++ rejects valid code with in-class using declaration

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52465

fabien at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from fabien at gcc dot gnu.org 2012-04-15 20:25:23 UTC ---
Fixed in 4.7.1 and on trunk.