From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11631 invoked by alias); 15 Mar 2012 10:04:31 -0000 Received: (qmail 11617 invoked by uid 22791); 15 Mar 2012 10:04:30 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Mar 2012 10:04:17 +0000 From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/52534] gcc doesn't detect incorrect expression in call to va_start Date: Thu, 15 Mar 2012 10:04:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Keywords: accepts-invalid X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-03/txt/msg01339.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52534 Jakub Jelinek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #3 from Jakub Jelinek 2012-03-15 10:03:59 UTC --- Because otherwise void foo (char a, ...) { __builtin_va_list va; __builtin_va_start (va, a); __builtin_va_end (va); } would not work (arg there is (int) a, as char is promoted to int). IMHO if we want to diagnose this, it should be done in the C/C++ FEs, e.g. for C FE perhaps in c_parser_postfix_expression_after_primary, by requiring that the second argument to __builtin_va_start is an identifier token, rathern than a + 0 or similar.