[Bug target/52555] New: [Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[Bug target/52555] New: [Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[roman at binarylife dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

             Bug #: 52555
           Summary: [Regression] ICE unrecognizable insn with -ffast-math
                    and __attribute__((optimize(xx)))
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: roman@binarylife.net


$ cat test.cpp 
typedef unsigned long value_t;

struct foo {
    static float _factor;
    value_t _val;

    foo()
    :  _val(7)
    {
        _val=__builtin_ceil(_val * _factor);
    }
};

struct bar {
    void operator()(foo&);
};

void
__attribute__((optimize("O")))
test() {
    foo f;
    bar b;
    b(f);
}

int main() {
    test();
}

$ g++ -c -O2 -ffast-math test.cpp
test.cpp: In function ‘void test()’:
test.cpp:24:1: error: unrecognizable insn:
(insn 9 8 10 3 (parallel [
            (set (reg:XF 67)
                (unspec:XF [
                        (reg:XF 68)
                    ] UNSPEC_FRNDINT_CEIL))
            (clobber (reg:CC 17 flags))
        ]) test.cpp:10 -1
     (nil))
test.cpp:24:1: internal compiler error: in extract_insn, at recog.c:2109
Please submit a full bug report,

This happens with x86 and x86_64.

[Bug target/52555] [4.6/4.7 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[roman at binarylife dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #1 from Roman Kononov <roman at binarylife dot net> 2012-03-12 12:51:20 UTC ---
It broke in r165823.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.4
            Summary|[4.6/4.7 Regression] ICE    |[4.6/4.7/4.8 Regression]
                   |unrecognizable insn with    |ICE unrecognizable insn
                   |-ffast-math and             |with -ffast-math and
                   |__attribute__((optimize(xx) |__attribute__((optimize(xx)
                   |))                          |))

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu.org

--- Comment #2 from Uros Bizjak <ubizjak at gmail dot com> 2012-03-12 17:11:35 UTC ---
(In reply to comment #1)
> It broke in r165823.

Author: jsm28
Date: Fri Oct 22 12:14:45 2010
New Revision: 165823

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=165823
Log:
    * target.h (enum opt_levels, struct default_options): New.
    * target.def (handle_ofast): Remove hook.
    (target_option.optimization): Change to
    target_option.optimization_table.
    ...

Adding CC.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-08-15 14:01:34 UTC ---
I'd say it is wrong to clear the fast math flags when switching from global
state -ffast-math to optimize attrubute -O1 or similar, of course with no outer
-ffast-math or -Ofast attribute optimize Ofast should turn fast math options
on.
How global Ofast with O optimize attribute should behave is another question.

Anyway, what happens here is that the ceil[sdx]f2 expanders and others use
flag_unsafe_math_optimizations and flag_trapping_math options in their
conditions (i.e. HAVE_ceil[sdx]f2 uses those and init_all_optabs sets it).  But
apparently init_all_optabs is evaluated just once (several times only for
really multi targettish targets like mips).  Thus it is evaluated when fast
math options are on, but during expansion they are off.

In this light I'd say it is a target bug to use options that can change between
different functions in insn conditions.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-08-15 14:21:54 UTC ---
Another option is to switch this_target_optabs not just for SWITCHABLE_TARGETs,
but also when switching between cfun with different optimize/target attributes
(at the time when the optimization/target node is created for a function it
would try to init_all_optabs into a newly allocated array, and if that differed
from the default, it would stick it into the node and switch at set_cfun time).

I actually wonder how could target attribute work the way it is implemented
right now so far.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> 2012-08-15 14:34:53 UTC ---
(In reply to comment #4)
> I actually wonder how could target attribute work the way it is implemented
> right now so far.

It works by miracle.  See PR 37565.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |i?86-*-* x86_64-linux-gnu
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-01-04
     Ever Confirmed|0                           |1

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> 2013-01-04 03:09:43 UTC ---
Confirmed.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org

--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2013-02-07 22:43:25 UTC ---
I'll take a look.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #8 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2013-02-07 22:44:17 UTC ---
I'll take a look.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #9 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2013-02-07 23:24:42 UTC ---
Further reduced testcase, reproducible on both C and C++:

float farg;
unsigned val;

void __attribute__((optimize("O")))
test()
{
  val = __builtin_ceilf(farg);
}

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #10 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2013-02-09 19:07:44 UTC ---
Created attachment 29404
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29404
untested patch

Untested proposed patch.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-11 09:00:50 UTC ---
Thanks for working on this.  I wonder why don't you store a struct
target_optabs *
filed directly into the optimization node, instead of using a hash table for
it.
Perhaps NULL could mean the default (&default_target_optabs), so that
SWITCHABLE_TARGETS can still do something about it.  init_all_optabs is pretty
expensive, so if we have say two functions with
__attribute__((__optimize__(3))),
it would be better to just use the -O3 optabs the second time.  And, I wouldn't
compare the result of init_all_optabs against saved copy of this_target_optabs,
but &default_target_optabs.

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #12 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2013-02-19 00:04:59 UTC ---
Author: aldyh
Date: Tue Feb 19 00:04:49 2013
New Revision: 196129

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196129
Log:
    PR target/52555
    * genopinit.c (raw_optab_handler): Use this_fn_optabs.
    (swap_optab_enable): Same.
    (init_all_optabs): Use argument instead of global.
    * tree.h (struct tree_optimization_option): New field
    target_optabs.
    * expr.h (init_all_optabs): Add argument to prototype.
    (TREE_OPTIMIZATION_OPTABS): New.
    (save_optabs_if_changed): Protoize.
    * optabs.h: Declare this_fn_optabs.
    * optabs.c (save_optabs_if_changed): New.
    Declare this_fn_optabs.
    (init_optabs): Add argument to init_all_optabs() call.
    * function.c (invoke_set_current_function_hook): Handle per
    function optabs.
    * function.h (struct function): New field optabs.
    * config/mips/mips.c (mips_set_mips16_mode): Handle when
    optimization_current_node has changed.
    * target-globals.h (save_target_globals_default_opts): Protoize.
    * target-globals.c (save_target_globals_default_opts): New.
c-family/
    * c-common.c (handle_optimize_attribute): Call
    save_optabs_if_changed.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr52555.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/config/mips/mips.c
    trunk/gcc/expr.h
    trunk/gcc/function.c
    trunk/gcc/function.h
    trunk/gcc/genopinit.c
    trunk/gcc/optabs.c
    trunk/gcc/optabs.h
    trunk/gcc/target-globals.c
    trunk/gcc/target-globals.h
    trunk/gcc/tree.h

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2013-02-19 00:14:33 UTC ---
fixed on trunk

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-24 18:54:42 UTC ---
Author: jakub
Date: Sun Feb 24 18:54:37 2013
New Revision: 196245

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196245
Log:
    PR target/52555
    * target-globals.c (save_target_globals): For init_reg_sets and
    target_reinit remporarily set this_fn_optabs to this_target_optabs.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/target-globals.c

[Bug target/52555] [4.6/4.7/4.8 Regression] ICE unrecognizable insn with -ffast-math and __attribute__((optimize(xx)))

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52555
Bug 52555 depends on bug 37565, which changed state.

Bug 37565 Summary: __optimize__  attribute doesn't work correctly
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37565

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED