public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261
@ 2012-03-12 19:57 dominiq at lps dot ens.fr
2012-03-13 8:44 ` [Bug bootstrap/52569] " rguenth at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dominiq at lps dot ens.fr @ 2012-03-12 19:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52569
Bug #: 52569
Summary: [4.8 Regression] bootstrap fails on
x86_64-apple-darwin10 at revision 185261
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: bootstrap
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: dominiq@lps.ens.fr
CC: iains@gcc.gnu.org, rguenther@suse.de
Host: x86_64-apple-darwin10
Target: x86_64-apple-darwin10
Build: x86_64-apple-darwin10
Bootstrapping revision 185261 on x86_64-apple-darwin10 fails with:
/opt/gcc/build_w/./gcc/xgcc -B/opt/gcc/build_w/./gcc/
-B/opt/gcc/gcc4.8w/x86_64-apple-darwin10.8.0/bin/
-B/opt/gcc/gcc4.8w/x86_64-apple-darwin10.8.0/lib/ -isystem
/opt/gcc/gcc4.8w/x86_64-apple-darwin10.8.0/include -isystem
/opt/gcc/gcc4.8w/x86_64-apple-darwin10.8.0/sys-include -g -O2 -O2 -g -O2
-DIN_GCC -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual
-Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition -isystem
./include -pipe -fno-common -g -DIN_LIBGCC2 -fbuilding-libgcc
-fno-stack-protector -pipe -fno-common -I. -I. -I../.././gcc
-I../../../work/libgcc -I../../../work/libgcc/. -I../../../work/libgcc/../gcc
-I../../../work/libgcc/../include -DHAVE_CC_TLS -DUSE_EMUTLS -o
unwind-dw2-fde-darwin_s.o -MT unwind-dw2-fde-darwin_s.o -MD -MP -MF
unwind-dw2-fde-darwin_s.dep -DSHARED -fexceptions -c
../../../work/libgcc/config/unwind-dw2-fde-darwin.c
In file included from ../../../work/libgcc/config/unwind-dw2-fde-darwin.c:36:0:
../../../work/libgcc/unwind-dw2-fde.h: In function 'last_fde':
../../../work/libgcc/unwind-dw2-fde.h:173:10: warning: cast discards
'__attribute__((const))' qualifier from pointer target type [-Wcast-qual]
In file included from ../../../work/libgcc/config/unwind-dw2-fde-darwin.c:47:0:
../../../work/libgcc/unwind-dw2-fde.c: In function 'init_object_mutex':
../../../work/libgcc/unwind-dw2-fde.c:57:3: warning: implicit declaration of
function '__GTHREAD_MUTEX_INIT_FUNCTION' [-Wimplicit-function-declaration]
../../../work/libgcc/unwind-dw2-fde.c: In function 'init_object_mutex_once':
../../../work/libgcc/unwind-dw2-fde.c:63:3: error: unknown type name
'__gthread_once_t'
../../../work/libgcc/unwind-dw2-fde.c:63:34: error: '__GTHREAD_ONCE_INIT'
undeclared (first use in this function)
../../../work/libgcc/unwind-dw2-fde.c:63:34: note: each undeclared identifier
is reported only once for each function it appears in
../../../work/libgcc/unwind-dw2-fde.c:64:3: warning: implicit declaration of
function '__gthread_once' [-Wimplicit-function-declaration]
../../../work/libgcc/config/unwind-dw2-fde-darwin.c: At top level:
../../../work/libgcc/config/unwind-dw2-fde-darwin.c:279:1: warning: no previous
prototype for '_darwin10_Unwind_FindEnclosingFunction' [-Wmissing-prototypes]
This is likely due to revision 185231
Author: rguenth
Date: Mon Mar 12 14:23:27 2012 UTC (5 hours, 21 minutes ago)
Changed paths: 6
Log Message:
2012-03-12 Richard Guenther <rguenther@suse.de>
* gthr.h (__GTHREAD_MUTEX_INIT_FUNCTION): Adjust specification.
* gthr-posix.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define.
(__gthread_mutex_init_function): New function.
* gthr-single.h (__GTHREAD_MUTEX_INIT_FUNCTION): Define.
PR gcov/49484
* libgcov.c: Include gthr.h.
(__gcov_flush_mx): New global variable.
(init_mx, init_mx_once): New functions.
(__gcov_flush): Protect self with a mutex.
(__gcov_fork): Re-initialize mutex after forking.
* unwind-dw2-fde.c: Change condition under which to use
__GTHREAD_MUTEX_INIT_FUNCTION.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/52569] [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261
2012-03-12 19:57 [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261 dominiq at lps dot ens.fr
@ 2012-03-13 8:44 ` rguenth at gcc dot gnu.org
2012-03-13 8:53 ` iains at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-03-13 8:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52569
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2012-03-13
AssignedTo|unassigned at gcc dot |rguenth at gcc dot gnu.org
|gnu.org |
Target Milestone|--- |4.8.0
Ever Confirmed|0 |1
--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-13 08:42:53 UTC ---
Mine. But I can only guess a fix and not test it. Basically we now absolutely
require the GTHREAD_ONCE stuff, please have a try providing it for darwin
(I can see a manual page for pthread_once at least).
I see in unwind-dw2-fde-darwin.c:
/* Carefully don't include gthr.h. */
what's that about? It looks like that hack no longer works with the
changed condition for using __GTHREAD_MUTEX_INIT_FUNCTION.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/52569] [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261
2012-03-12 19:57 [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261 dominiq at lps dot ens.fr
2012-03-13 8:44 ` [Bug bootstrap/52569] " rguenth at gcc dot gnu.org
@ 2012-03-13 8:53 ` iains at gcc dot gnu.org
2012-03-13 8:57 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: iains at gcc dot gnu.org @ 2012-03-13 8:53 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52569
--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> 2012-03-13 08:52:36 UTC ---
(In reply to comment #1)
> Mine. But I can only guess a fix and not test it. Basically we now absolutely
> require the GTHREAD_ONCE stuff, please have a try providing it for darwin
> (I can see a manual page for pthread_once at least).
>
> I see in unwind-dw2-fde-darwin.c:
>
> /* Carefully don't include gthr.h. */
>
> what's that about? It looks like that hack no longer works with the
> changed condition for using __GTHREAD_MUTEX_INIT_FUNCTION.
apologies, no time to look at this right now...
.. is the content of this thread helpful?
http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00211.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/52569] [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261
2012-03-12 19:57 [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261 dominiq at lps dot ens.fr
2012-03-13 8:44 ` [Bug bootstrap/52569] " rguenth at gcc dot gnu.org
2012-03-13 8:53 ` iains at gcc dot gnu.org
@ 2012-03-13 8:57 ` rguenth at gcc dot gnu.org
2012-03-13 10:02 ` rguenth at gcc dot gnu.org
2012-03-13 10:02 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-03-13 8:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52569
--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-13 08:56:22 UTC ---
Index: libgcc/unwind-dw2-fde.c
===================================================================
--- libgcc/unwind-dw2-fde.c (revision 185278)
+++ libgcc/unwind-dw2-fde.c (working copy)
@@ -48,7 +48,9 @@ static struct object *seen_objects;
#ifdef __GTHREAD_MUTEX_INIT
static __gthread_mutex_t object_mutex = __GTHREAD_MUTEX_INIT;
#define init_object_mutex_once()
-#else
+#endif
+
+#ifdef __GTHREAD_MUTEX_INIT_FUNCTION
static __gthread_mutex_t object_mutex;
static void
@@ -63,6 +65,11 @@ init_object_mutex_once (void)
static __gthread_once_t once = __GTHREAD_ONCE_INIT;
__gthread_once (&once, init_object_mutex);
}
+#else
+/* ??? Several targets include this file with stubbing parts of gthr.h
+ and expect no locking to be done. */
+#define init_object_mutex_once()
+static __gthread_mutex_t object_mutex;
#endif
/* Called from crtbegin.o to register the unwind info for an object. */
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/52569] [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261
2012-03-12 19:57 [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261 dominiq at lps dot ens.fr
` (2 preceding siblings ...)
2012-03-13 8:57 ` rguenth at gcc dot gnu.org
@ 2012-03-13 10:02 ` rguenth at gcc dot gnu.org
2012-03-13 10:02 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-03-13 10:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52569
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-13 10:01:04 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug bootstrap/52569] [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261
2012-03-12 19:57 [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261 dominiq at lps dot ens.fr
` (3 preceding siblings ...)
2012-03-13 10:02 ` rguenth at gcc dot gnu.org
@ 2012-03-13 10:02 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-03-13 10:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52569
--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-13 10:00:53 UTC ---
Author: rguenth
Date: Tue Mar 13 10:00:48 2012
New Revision: 185322
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185322
Log:
2012-03-13 Richard Guenther <rguenther@suse.de>
PR target/52569
* unwind-dw2-fde.c: Make avoid-include-gthr.h hacks work again.
Modified:
trunk/libgcc/ChangeLog
trunk/libgcc/unwind-dw2-fde.c
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-13 10:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-12 19:57 [Bug bootstrap/52569] New: [4.8 Regression] bootstrap fails on x86_64-apple-darwin10 at revision 185261 dominiq at lps dot ens.fr
2012-03-13 8:44 ` [Bug bootstrap/52569] " rguenth at gcc dot gnu.org
2012-03-13 8:53 ` iains at gcc dot gnu.org
2012-03-13 8:57 ` rguenth at gcc dot gnu.org
2012-03-13 10:02 ` rguenth at gcc dot gnu.org
2012-03-13 10:02 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).