[Bug c++/52599] New: illegal constexpr constructor declaration make g++ assert instead of returning an error

[Bug c++/52599] New: illegal constexpr constructor declaration make g++ assert instead of returning an error

[mickael.guene at st dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52599

             Bug #: 52599
           Summary: illegal constexpr constructor declaration make g++
                    assert instead of returning an error
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: mickael.guene@st.com


Created attachment 26902
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26902
This test make g++ to assert

when compiling attach file with 'g++ -std=c++0x test.cpp' compiler assert in
build_constexpr_constructor_member_initializers function from cp/semantics.c.
g++ should instead return an error since construct is illegal.

[Bug c++/52599] ICE on illegal constexpr constructor declaration

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52599

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-03-16
            Summary|illegal constexpr           |ICE on illegal constexpr
                   |constructor declaration     |constructor declaration
                   |make g++ assert instead of  |
                   |returning an error          |
     Ever Confirmed|0                           |1

[Bug c++/52599] ICE on illegal constexpr constructor declaration

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52599

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|mickael.guene at st dot com |jason at gcc dot gnu.org

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-03-16 10:39:42 UTC ---
Actually, the gcc_assert triggering is that in
build_data_member_initialization: t is a TRY_BLOCK (of course) at that point.

Not sure at the moment if we should diagnose the issue here or earlier. Maybe
Jason has tips..

[Bug c++/52599] ICE on illegal constexpr constructor declaration

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52599

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-04-17 10:41:18 UTC ---
On it.

[Bug c++/52599] ICE on illegal constexpr constructor declaration

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52599

--- Comment #3 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2012-04-17 17:20:16 UTC ---
Author: paolo
Date: Tue Apr 17 17:20:02 2012
New Revision: 186541

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186541
Log:
/cp
2012-04-17  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/52599
    * semantics.c (build_constexpr_constructor_member_initializers):
    Check for function-try-block as function-body.

/testsuite
2012-04-17  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/52599
    * g++.dg/cpp0x/constexpr-ctor10.C: New.

/cp
2012-04-17  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/53003
    * parser.c (cp_parser_member_declaration): Check that
    initializer_token_start is non null before dereferencing it.

/testsuite
2012-04-17  Paolo Carlini  <paolo.carlini@oracle.com>

    PR c++/53003
    * g++.dg/parse/crash59.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/constexpr-ctor10.C
    trunk/gcc/testsuite/g++.dg/parse/crash59.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/cp/semantics.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/52599] ICE on illegal constexpr constructor declaration

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52599

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.8.0

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-04-17 17:21:04 UTC ---
Fixed for 4.8.0.