[Bug other/52626] New: make check fixinclude test FAILURES

[Bug other/52626] New: make check fixinclude test FAILURES

[izamyatin at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52626

             Bug #: 52626
           Summary: make check fixinclude test FAILURES
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: izamyatin@gmail.com
            Target: x86_64-unknown-linux-gnu


Issue appeared after revision 185392:

Author: ro <ro@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Wed Mar 14 17:08:03 2012 +0000

    Remove obsolete Solaris 8 support


Snippet from make check report:
pthread.h
/export/users/izamyati/trunk_for_check/fixincludes/tests/base/pthread.h differ:
byte 2526, line 86
*** pthread.h    2012-03-20 00:03:27.660335543 +0400
--- /export/users/izamyati/trunk_for_check/fixincludes/tests/base/pthread.h   
2012-03-16 13:25:18.787318293 +0400
***************
*** 83,91 ****
  #define PTHREAD_MUTEX_INITIALIZER    {{{0},0}, {{{0}}}, {0}}
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
! #define PTHREAD_COND_INITIALIZER    {{{0}, 0}, 0}    /* DEFAULTCV */
  #else
! #define PTHREAD_COND_INITIALIZER    {{{0}, 0}, {0}}    /* DEFAULTCV */
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
  #define    PTHREAD_MUTEX_INITIALIZER        /* = DEFAULTMUTEX */    \
--- 83,91 ----
  #define PTHREAD_MUTEX_INITIALIZER    {{{0},0}, {{{0}}}, {0}}
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
! #define PTHREAD_COND_INITIALIZER    {{{0}, 0, 0x4356}, 0}    /* DEFAULTCV */
  #else
! #define PTHREAD_COND_INITIALIZER    {{{0}, 0, 0x4356}, {0}}    /* DEFAULTCV
*/
  #endif
  #if __STDC__ - 0 == 0 && !defined(_NO_LONGLONG)
  #define    PTHREAD_MUTEX_INITIALIZER        /* = DEFAULTMUTEX */    \

There were fixinclude test FAILURES
make: *** [check] Error 1

[Bug other/52626] make check fixinclude test FAILURES

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52626

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-unknown-linux-gnu    |
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-03-21
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2012-03-21 16:33:00 UTC ---
My fault, patch submitted.

Sorry.
  Rainer

[Bug other/52626] make check fixinclude test FAILURES

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52626

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> 2012-03-22 16:07:53 UTC ---
Author: ro
Date: Thu Mar 22 16:07:47 2012
New Revision: 185699

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185699
Log:
Fix pthread.h failure (PR other/52626)

    PR other/52626
    * tests/base/pthread.h [SOLARIS_MUTEX_INIT_2_CHECK]
    (PTHREAD_COND_INITIALIZER): Adapt for solaris_cond_init removal.

Modified:
    trunk/fixincludes/ChangeLog
    trunk/fixincludes/tests/base/pthread.h

[Bug other/52626] make check fixinclude test FAILURES

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52626

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> 2012-03-22 16:26:35 UTC ---
Fixed for 4.8.0.