[Bug middle-end/52636] New: [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[Bug middle-end/52636] New: [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

             Bug #: 52636
           Summary: [4.8 Regression] ICE: tree check: expected
                    integer_cst, have string_cst in tree_to_double_int, at
                    tree.h:4324
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: burnus@net-b.de, rguenth@gcc.gnu.org
              Host: x86_64-apple-darwin10
            Target: x86_64-apple-darwin10
             Build: x86_64-apple-darwin10


Since revision 185466, compiling aermod.f90 from the polyhedron test suite with
'-O3 --param max-inline-insns-auto=51' and above gives an ICE:

[macbook] lin/test% /opt/gcc/gcc4.8w-185465p4/bin/gfortran -O3 --param
max-inline-insns-auto=51 aermod.f90
[macbook] lin/test% /opt/gcc/gcc4.8w-185466p4/bin/gfortran -O3 --param
max-inline-insns-auto=50 aermod.f90
[macbook] lin/test% /opt/gcc/gcc4.8w-185466p4/bin/gfortran -O3 --param
max-inline-insns-auto=51 aermod.f90
aermod.f90: In function 'preinclud_.part.28':
aermod.f90:4628:0: internal compiler error: tree check: expected integer_cst,
have string_cst in tree_to_double_int, at tree.h:4324
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

So far my attempts to reduce the code have not been successful.

[Bug middle-end/52636] [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-03-20
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-20 15:22:02 UTC ---
Confirmed.

[Bug tree-optimization/52636] [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |tree-optimization

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-20 15:56:42 UTC ---
Patch:

2012-03-20  Richard Guenther  <rguenther@suse.de>

        PR tree-optimizer/52636
        * tree-vect-slp.c (vect_get_constant_vectors): Convert constants
        to the appropriate type.

Index: gcc/tree-vect-slp.c
===================================================================
*** gcc/tree-vect-slp.c (revision 185563)
--- gcc/tree-vect-slp.c (working copy)
*************** vect_get_constant_vectors (tree op, slp_
*** 2363,2368 ****
--- 2363,2374 ----

            /* Create 'vect_ = {op0,op1,...,opn}'.  */
            number_of_places_left_in_vector--;
+         if (constant_p
+             && !types_compatible_p (TREE_TYPE (vector_type), TREE_TYPE (op)))
+           {
+             op = fold_unary (VIEW_CONVERT_EXPR, TREE_TYPE (vector_type), op);
+             gcc_assert (op && CONSTANT_CLASS_P (op));
+           }
          elts[number_of_places_left_in_vector] = op;

            if (number_of_places_left_in_vector == 0)

[Bug tree-optimization/52636] [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-03-20 18:35:50 UTC ---
The patch in comment #2 fixes the PR without side effect on the polyhedron test
suite (AFAICT;-).
Currently bootstrapping r185584, regtesting scheduled for tonight. Thanks for
the quick fix.

[Bug tree-optimization/52636] [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-03-21 07:48:02 UTC ---
Regstrapped with the patch in comment #2 without regression (but for
pr52650;-).

[Bug tree-optimization/52636] [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-21 08:05:56 UTC ---
Author: rguenth
Date: Wed Mar 21 08:05:51 2012
New Revision: 185599

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185599
Log:
2012-03-21  Richard Guenther  <rguenther@suse.de>

    PR tree-optimizer/52636
    * tree-vect-slp.c (vect_get_constant_vectors): Convert constants
    to the appropriate type.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-vect-slp.c

[Bug tree-optimization/52636] [4.8 Regression] ICE: tree check: expected integer_cst, have string_cst in tree_to_double_int, at tree.h:4324

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52636

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-21 08:07:48 UTC ---
Fixed.