* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
@ 2012-03-21 0:04 ` jan.smets@alcatel-lucent.com
2012-03-21 0:44 ` steven at gcc dot gnu.org
` (21 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: jan.smets@alcatel-lucent.com @ 2012-03-21 0:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #1 from Jan Smets <jan.smets@alcatel-lucent.com> 2012-03-20 23:45:27 UTC ---
I'd like to note that this code compiles in a few seconds in GCC 3.4.
Thanks Neil for making this profile.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
2012-03-21 0:04 ` [Bug c/52640] " jan.smets@alcatel-lucent.com
@ 2012-03-21 0:44 ` steven at gcc dot gnu.org
2012-03-21 13:02 ` steven at gcc dot gnu.org
` (20 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-21 0:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2012-03-21
AssignedTo|unassigned at gcc dot |steven at gcc dot gnu.org
|gnu.org |
Ever Confirmed|0 |1
--- Comment #2 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-21 00:37:18 UTC ---
I'll have a stab at this.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
2012-03-21 0:04 ` [Bug c/52640] " jan.smets@alcatel-lucent.com
2012-03-21 0:44 ` steven at gcc dot gnu.org
@ 2012-03-21 13:02 ` steven at gcc dot gnu.org
2012-03-21 13:03 ` steven at gcc dot gnu.org
` (19 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-21 13:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #4 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-21 13:01:07 UTC ---
Created attachment 26941
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26941
Needs an ASM_OUTPUT_EXTERNAL platform for testing
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (2 preceding siblings ...)
2012-03-21 13:02 ` steven at gcc dot gnu.org
@ 2012-03-21 13:03 ` steven at gcc dot gnu.org
2012-03-21 13:10 ` steven at gcc dot gnu.org
` (18 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-21 13:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |WAITING
--- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-21 13:00:33 UTC ---
Can you please add the output of "gcc --version" and add "-v" to your compiler
invocation and report the output?
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (3 preceding siblings ...)
2012-03-21 13:03 ` steven at gcc dot gnu.org
@ 2012-03-21 13:10 ` steven at gcc dot gnu.org
2012-03-21 15:57 ` jan.smets@alcatel-lucent.com
` (17 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-21 13:10 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #5 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-21 13:03:57 UTC ---
Ah, and obviously there should be a pointer_set_insert before VEC_safe_push...
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (4 preceding siblings ...)
2012-03-21 13:10 ` steven at gcc dot gnu.org
@ 2012-03-21 15:57 ` jan.smets@alcatel-lucent.com
2012-03-21 16:21 ` steven at gcc dot gnu.org
` (16 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: jan.smets@alcatel-lucent.com @ 2012-03-21 15:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #6 from Jan Smets <jan.smets@alcatel-lucent.com> 2012-03-21 15:51:22 UTC ---
Comment on attachment 26941
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26941
Needs an ASM_OUTPUT_EXTERNAL platform for testing
Where does deferred_global_decls come from? Can this be modified to apply to
4.6.3 ?
Target is i686-wrs-vxworks / mips-wrs-vxworks
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (5 preceding siblings ...)
2012-03-21 15:57 ` jan.smets@alcatel-lucent.com
@ 2012-03-21 16:21 ` steven at gcc dot gnu.org
2012-03-21 18:37 ` [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] " steven at gcc dot gnu.org
` (15 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-21 16:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26941|0 |1
is obsolete| |
--- Comment #7 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-21 16:17:24 UTC ---
Created attachment 26942
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26942
Fixed patch
Previous patch was obviously not yet tested, this one at least compiles.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (6 preceding siblings ...)
2012-03-21 16:21 ` steven at gcc dot gnu.org
@ 2012-03-21 18:37 ` steven at gcc dot gnu.org
2012-03-21 18:37 ` [Bug c/52640] " ncahill_alt at yahoo dot com
` (14 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-21 18:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |compile-time-hog
Status|WAITING |ASSIGNED
Component|c |middle-end
Summary|performance bottleneck: |[4.5/4.6/4.7/4.8
|gcc/tree.c;value_member |Regression] performance
| |bottleneck:
| |gcc/tree.c;value_member
--- Comment #9 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-21 18:35:10 UTC ---
Regression w.r.t. GCC3 on all active release branches.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug c/52640] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (7 preceding siblings ...)
2012-03-21 18:37 ` [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] " steven at gcc dot gnu.org
@ 2012-03-21 18:37 ` ncahill_alt at yahoo dot com
2012-03-21 20:25 ` [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] " jan.smets@alcatel-lucent.com
` (13 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: ncahill_alt at yahoo dot com @ 2012-03-21 18:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #8 from ncahill_alt at yahoo dot com 2012-03-21 17:47:21 UTC ---
Created attachment 26945
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26945
gcc -version && output with -v added
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (8 preceding siblings ...)
2012-03-21 18:37 ` [Bug c/52640] " ncahill_alt at yahoo dot com
@ 2012-03-21 20:25 ` jan.smets@alcatel-lucent.com
2012-03-24 13:48 ` steven at gcc dot gnu.org
` (12 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: jan.smets@alcatel-lucent.com @ 2012-03-21 20:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #10 from Jan Smets <jan.smets@alcatel-lucent.com> 2012-03-21 19:46:31 UTC ---
Works. ~13 sec for 243k entries. Still slower than GCC 3.4 but at least better
than 80+ seconds.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (9 preceding siblings ...)
2012-03-21 20:25 ` [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] " jan.smets@alcatel-lucent.com
@ 2012-03-24 13:48 ` steven at gcc dot gnu.org
2012-03-24 13:49 ` steven at gcc dot gnu.org
` (11 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-24 13:48 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #11 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-24 13:46:42 UTC ---
Author: steven
Date: Sat Mar 24 13:46:33 2012
New Revision: 185757
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185757
Log:
gcc/
PR middle-end/52640
* varasm.c: Include pointer-set.h.
(pending_assemble_externals_set): New pointer set.
(process_pending_assemble_externals): Destroy the pointer set.
(assemble_external): See if decl is in pending_assemble_externals_set,
and add it to pending_assemble_externals if necessary.
(init_varasm_once): Allocate pending_assemble_externals_set.
testsuite/
PR middle-end/52640
* gcc.c-torture/compile/limits-externdecl.c: New test.
Added:
branches/gcc-4_5-branch/gcc/testsuite/gcc.c-torture/compile/limits-externdecl.c
Modified:
branches/gcc-4_5-branch/gcc/varasm.c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (10 preceding siblings ...)
2012-03-24 13:48 ` steven at gcc dot gnu.org
@ 2012-03-24 13:49 ` steven at gcc dot gnu.org
2012-03-24 13:52 ` steven at gcc dot gnu.org
` (10 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-24 13:49 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #12 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-24 13:47:51 UTC ---
Author: steven
Date: Sat Mar 24 13:47:46 2012
New Revision: 185758
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185758
Log:
gcc/
PR middle-end/52640
* varasm.c: Include pointer-set.h.
(pending_assemble_externals_set): New pointer set.
(process_pending_assemble_externals): Destroy the pointer set.
(assemble_external): See if decl is in pending_assemble_externals_set,
and add it to pending_assemble_externals if necessary.
(init_varasm_once): Allocate pending_assemble_externals_set.
testsuite/
PR middle-end/52640
* gcc.c-torture/compile/limits-externdecl.c: New test.
Added:
branches/gcc-4_6-branch/gcc/testsuite/gcc.c-torture/compile/limits-externdecl.c
Modified:
branches/gcc-4_6-branch/gcc/varasm.c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.5/4.6/4.7/4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (11 preceding siblings ...)
2012-03-24 13:49 ` steven at gcc dot gnu.org
@ 2012-03-24 13:52 ` steven at gcc dot gnu.org
2012-03-24 14:48 ` [Bug middle-end/52640] [4.8 " steven at gcc dot gnu.org
` (9 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-24 13:52 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #13 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-24 13:48:51 UTC ---
Author: steven
Date: Sat Mar 24 13:48:35 2012
New Revision: 185759
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=185759
Log:
gcc/
PR middle-end/52640
* varasm.c: Include pointer-set.h.
(pending_assemble_externals_set): New pointer set.
(process_pending_assemble_externals): Destroy the pointer set.
(assemble_external): See if decl is in pending_assemble_externals_set,
and add it to pending_assemble_externals if necessary.
(init_varasm_once): Allocate pending_assemble_externals_set.
testsuite/
PR middle-end/52640
* gcc.c-torture/compile/limits-externdecl.c: New test.
Added:
branches/gcc-4_7-branch/gcc/testsuite/gcc.c-torture/compile/limits-externdecl.c
Modified:
branches/gcc-4_7-branch/gcc/varasm.c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (12 preceding siblings ...)
2012-03-24 13:52 ` steven at gcc dot gnu.org
@ 2012-03-24 14:48 ` steven at gcc dot gnu.org
2012-07-02 13:52 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: steven at gcc dot gnu.org @ 2012-03-24 14:48 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Steven Bosscher <steven at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |4.5.5, 4.6.4, 4.7.1
Target Milestone|--- |4.5.4
Summary|[4.5/4.6/4.7/4.8 |[4.8 Regression]
|Regression] performance |performance bottleneck:
|bottleneck: |gcc/tree.c;value_member
|gcc/tree.c;value_member |
Known to fail| |4.8.0
--- Comment #14 from Steven Bosscher <steven at gcc dot gnu.org> 2012-03-24 13:52:21 UTC ---
Fixed on release branches.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (13 preceding siblings ...)
2012-03-24 14:48 ` [Bug middle-end/52640] [4.8 " steven at gcc dot gnu.org
@ 2012-07-02 13:52 ` rguenth at gcc dot gnu.org
2012-09-07 11:11 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-07-02 13:52 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.5.4 |4.8.0
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (14 preceding siblings ...)
2012-07-02 13:52 ` rguenth at gcc dot gnu.org
@ 2012-09-07 11:11 ` rguenth at gcc dot gnu.org
2012-09-07 19:07 ` stevenb.gcc at gmail dot com
` (6 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-09-07 11:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
--- Comment #15 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-09-07 11:10:57 UTC ---
Any progress on the "real" solution? If not, can you install the branch fix on
trunk? Thx.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (15 preceding siblings ...)
2012-09-07 11:11 ` rguenth at gcc dot gnu.org
@ 2012-09-07 19:07 ` stevenb.gcc at gmail dot com
2012-12-11 8:04 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: stevenb.gcc at gmail dot com @ 2012-09-07 19:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #16 from stevenb.gcc at gmail dot com <stevenb.gcc at gmail dot com> 2012-09-07 19:07:27 UTC ---
> Any progress on the "real" solution? If not, can you install the branch fix on
> trunk? Thx.
I think I already mentioned before that the branch fix is the only
real fix I can think of. The problem has been aggravated by the
visibility machinery, it depends on having a pending-externs list.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (16 preceding siblings ...)
2012-09-07 19:07 ` stevenb.gcc at gmail dot com
@ 2012-12-11 8:04 ` jakub at gcc dot gnu.org
2012-12-11 9:59 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-12-11 8:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #17 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-11 08:03:44 UTC ---
Any progress on this? Does the branch patch not work on the trunk?
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (17 preceding siblings ...)
2012-12-11 8:04 ` jakub at gcc dot gnu.org
@ 2012-12-11 9:59 ` rguenth at gcc dot gnu.org
2012-12-11 16:56 ` jan.smets@alcatel-lucent.com
` (3 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-12-11 9:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #18 from Richard Biener <rguenth at gcc dot gnu.org> 2012-12-11 09:59:13 UTC ---
(In reply to comment #17)
> Any progress on this? Does the branch patch not work on the trunk?
Simply task of forward-porting and testing.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (18 preceding siblings ...)
2012-12-11 9:59 ` rguenth at gcc dot gnu.org
@ 2012-12-11 16:56 ` jan.smets@alcatel-lucent.com
2012-12-11 17:06 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: jan.smets@alcatel-lucent.com @ 2012-12-11 16:56 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #19 from Jan Smets <jan.smets@alcatel-lucent.com> 2012-12-11 16:55:30 UTC ---
Steven's example only contains 10 000 entries. I need to recompile a symbol
table of 270.000 entries a dozen times each day. (and so do a lot of other
people)
With the 'fix' it still takes 12+ seconds to compile it on a state of the art
machine and then another 4+ seconds to assemble. CLANG2.8 spends 15.5 sec and
CLANG3.1 16.5 sec.
I'm already happy with the work around but I'd really like to see a more
structural solution, whichever that may be. Thanks
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (19 preceding siblings ...)
2012-12-11 16:56 ` jan.smets@alcatel-lucent.com
@ 2012-12-11 17:06 ` jakub at gcc dot gnu.org
2012-12-12 9:44 ` jakub at gcc dot gnu.org
2012-12-12 9:45 ` jakub at gcc dot gnu.org
22 siblings, 0 replies; 24+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-12-11 17:06 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-11 17:05:33 UTC ---
Created attachment 28927
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28927
gcc48-pr52640.patch
Patch I'm going to bootstrap/regtest on the trunk. No point to #include
pointer-set.h when it is already included (it is included twice in 4.7
varams.c), and the var should be IMHO defined only if ASM_OUTPUT_EXTERNAL is
defined, otherwise it is unused local var.
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (20 preceding siblings ...)
2012-12-11 17:06 ` jakub at gcc dot gnu.org
@ 2012-12-12 9:44 ` jakub at gcc dot gnu.org
2012-12-12 9:45 ` jakub at gcc dot gnu.org
22 siblings, 0 replies; 24+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-12-12 9:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
--- Comment #21 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-12 09:43:39 UTC ---
Author: jakub
Date: Wed Dec 12 09:43:33 2012
New Revision: 194441
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194441
Log:
PR middle-end/52640
* varasm.c (pending_assemble_externals_set): New pointer set.
(process_pending_assemble_externals): Destroy the pointer set.
(assemble_external): See if decl is in pending_assemble_externals_set,
and add it to pending_assemble_externals if necessary.
(init_varasm_once): Allocate pending_assemble_externals_set.
* gcc.c-torture/compile/limits-externdecl.c: New test.
Added:
trunk/gcc/testsuite/gcc.c-torture/compile/limits-externdecl.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/varasm.c
^ permalink raw reply [flat|nested] 24+ messages in thread
* [Bug middle-end/52640] [4.8 Regression] performance bottleneck: gcc/tree.c;value_member
2012-03-20 18:36 [Bug c/52640] New: performance bottleneck: gcc/tree.c;value_member ncahill_alt at yahoo dot com
` (21 preceding siblings ...)
2012-12-12 9:44 ` jakub at gcc dot gnu.org
@ 2012-12-12 9:45 ` jakub at gcc dot gnu.org
22 siblings, 0 replies; 24+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-12-12 9:45 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52640
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #22 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-12 09:44:42 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 24+ messages in thread