[Bug middle-end/52717] New: thunk referenced in discarded section when building samba with -flto

[Bug middle-end/52717] New: thunk referenced in discarded section when building samba with -flto

[matt at use dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

             Bug #: 52717
           Summary: thunk referenced in discarded section when building
                    samba with -flto
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: matt@use.net


To reproduce from scratch with 4.7.0 and samba-3.6.3 (reduced case
below/attached):
debian-sparc:~/src/samba-3.6.3/source3# CFLAGS="-O2 -flto -mtune=leon
-floop-block -floop-interchange -floop-strip-mine -ftree-loop-distribution
-ftree-loop-distribute-patterns -ftree-loop-im -ftree-loop-ivcanon  -fivopts
-fpredictive-commoning -fipa-cp-clone -ffast-math -fgcse-after-reload -fgcse-sm
-fgcse-las" LDFLAGS="-flto -O2" ./configure --prefix=/opt/samba-3.6.4
--exec-prefix=/opt/samba-3.6.4 --sysconfdir=/opt/samba-3.6.4/etc
--with-configdir=/opt/samba-3.6.4/etc --with-quotas --with-pam
--with-pam_smbpass --build=sparc-linux
--with-logfilebase=/opt/samba-3.6.4/var/log
--with-piddir=/opt/samba-3.6.4/var/run --with-lockdir=/opt/samba-3.6.4/var/lock

debian-sparc:~/src/samba-3.6.3/source3# make
[...]
`__sparc_get_pc_thunk.l7' referenced in section `.text' of
smbta-util.ltrans24.ltrans.o: defined in discarded section
`.text.__sparc_get_pc_thunk.l7.4585[__sparc_get_pc_thunk.l7.4585]' of
smbta-util.ltrans24.ltrans.o

This is different from the previous bug -- there is no ipa-cp-clone here.
Attached is the output from save-temps.

I have yet to have any mid-sized C project fully build with LTO using -O2 or
variants, most coming down to this class of errors.

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |lto
             Target|                            |sparc-*-linux
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org, hubicka at gcc dot
                   |                            |gnu.org
          Component|middle-end                  |target

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-03-26 08:13:03 UTC ---
Which binutils version are you using?  The symbol seems to be one that is
supposed to be provided by libgcc (see sparc.c:get_pc_thunk_name, used
by GOT register loading)

That stuff might simply not be set up properly for LTO (it does not seem
to be integrated with the cgraph).  Honza?  Eric?

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-03-26
         AssignedTo|unassigned at gcc dot       |ebotcazou at gcc dot
                   |gnu.org                     |gnu.org
     Ever Confirmed|0                           |1
           Severity|major                       |normal

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-03-26 08:23:36 UTC ---
> That stuff might simply not be set up properly for LTO (it does not seem
> to be integrated with the cgraph).  Honza?  Eric?

Yes, that's very likely the source of the problem.

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[hubicka at ucw dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #3 from Jan Hubicka <hubicka at ucw dot cz> 2012-03-26 10:48:33 UTC ---
> > That stuff might simply not be set up properly for LTO (it does not seem
> > to be integrated with the cgraph).  Honza?  Eric?
> 
> Yes, that's very likely the source of the problem.
Hmm, if the sparc_get_pc_thunk is reference to libgcc, how it can end up being
defined
in ltrans24?  Perhaps renaming interfere here with the references done in sparc
frontend?

Honza

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-03-26 11:05:19 UTC ---
> Hmm, if the sparc_get_pc_thunk is reference to libgcc, how it can end up being
> defined in ltrans24?  Perhaps renaming interfere here with the references done 
> in sparc frontend?

sparc_get_pc_thunk is generated by the compiler, it isn't in libgcc.

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[matt at use dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #5 from Matt Hargett <matt at use dot net> 2012-03-26 17:09:55 UTC ---
Attachment was too big. Here's a URL for an archive that includes the ltrans
objects, ltrans asm, and cc temp files:
http://www.clock.org/~matt/tmp/smbta-util-lto-failure-temps.tar.bz2

I can provide the whole source dir or a VM image if that helps.

binutils version is freshly compiled with GCC 4.7.0 RC1:
debian-sparc:~/src/samba-3.6.3/source3# ld --version
GNU ld (GNU Binutils) 2.22.52.20120317
Copyright 2012 Free Software Foundation, Inc.

using this configure line for binutils:
../configure --prefix=/opt/gcc-4.7.0/ --enable-lto --with-gmp=/opt/gcc-4.7.0/
--with-mpfr=/opt/gcc-4.7.0/ --with-mpc=/opt/gcc-4.7.0/
--with-cloog=/opt/gcc-4.7.0/ --with-ppl=/opt/gcc-4.7.0 --enable-gold
--enable-cloog-backend=isl --disable-cloog-version-check --enable-plugins

and then this configure line for gcc 4.7.0:
 ../configure --prefix=/opt/gcc-4.7.0/ --enable-lto --with-gmp=/opt/gcc-4.7.0/
--with-mpfr=/opt/gcc-4.7.0/ --with-mpc=/opt/gcc-4.7.0/
--with-cloog=/opt/gcc-4.7.0/ --with-ppl=/opt/gcc-4.7.0 --enable-gold
--enable-cloog-backend=isl --enable-plugins --with-build-config=bootstrap-lto
--disable-libstdcxx-pch --enable-thread-safe --enable-threads=posix
--with-libelf=/opt/gcc-4.7.0/ --enable-languages=c,c++,lto --disable-bootstrap
--with-tune=leon --enable-build-with-cxx --disable-cloog-version-check
--disable-nls

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[matt at use dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #6 from Matt Hargett <matt at use dot net> 2012-03-26 17:32:51 UTC ---
The link line that fails:
gcc -o bin/smbta-util utils/smbta-util.o dynconfig.o param/loadparm.o
param/loadparm_server_role.o param/util.o lib/sharesec.o
lib/ldap_debug_handler.o registry/reg_api.o registry/reg_dispatcher.o
registry/reg_cachehook.o registry/reg_objects.o registry/reg_util_internal.o
lib/util_nttoken.o registry/reg_backend_db.o registry/reg_init_basic.o
registry/reg_util_token.o registry/reg_api_util.o
registry/reg_backend_smbconf.o registry/reg_init_smbconf.o
../lib/smbconf/smbconf.o ../lib/smbconf/smbconf_util.o
../lib/smbconf/smbconf_txt.o lib/smbconf/smbconf_reg.o
lib/smbconf/smbconf_init.o ../libcli/security/privileges.o lib/popt_common.o
./../lib/replace/replace.o ./../lib/replace/snprintf.o
./../lib/replace/getpass.o ../lib/util/rbtree.o ../lib/util/signal.o
../lib/util/time.o ../lib/util/xfile.o ../lib/util/util_strlist.o
../lib/util/util_file.o ../lib/util/data_blob.o ../lib/util/util.o
../lib/util/fsusage.o ../lib/util/params.o ../lib/util/talloc_stack.o
../lib/util/genrand.o ../lib/util/util_net.o ../lib/util/become_daemon.o
../lib/util/system.o ../lib/util/tevent_unix.o ../lib/util/tevent_ntstatus.o
../lib/util/tevent_werror.o ../lib/util/smb_threads.o ../lib/util/util_id.o
../lib/util/blocking.o ../lib/util/rfc1738.o ../lib/util/select.o
../lib/util/util_pw.o ../lib/crypto/crc32.o ../lib/crypto/md5.o
../lib/crypto/hmacmd5.o ../lib/crypto/arcfour.o ../lib/crypto/md4.o
../lib/crypto/sha256.o ../lib/crypto/hmacsha256.o ../lib/crypto/aes.o
../lib/crypto/rijndael-alg-fst.o lib/messages.o librpc/gen_ndr/ndr_messaging.o
lib/messages_local.o lib/messages_ctdbd.o lib/packet.o lib/ctdbd_conn.o
lib/interfaces.o lib/memcache.o lib/talloc_dict.o lib/serverid.o
lib/util_sconn.o lib/util_transfer_file.o ../lib/async_req/async_sock.o
lib/addrchange.o lib/util_tdb.o ../lib/util/util_tdb.o ../lib/util/tdb_wrap.o
lib/dbwrap.o lib/dbwrap_tdb.o lib/dbwrap_ctdb.o lib/g_lock.o lib/dbwrap_rbt.o
lib/version.o lib/charcnv.o ../lib/util/debug.o ../lib/util/debug_s3.o
lib/fault.o lib/interface.o lib/pidfile.o lib/system.o lib/sendfile.o
lib/recvfile.o lib/time.o lib/username.o ../libds/common/flag_mapping.o
lib/access.o lib/smbrun.o lib/bitmap.o lib/dprintf.o
../libcli/registry/util_reg.o lib/wins_srv.o lib/util_str.o lib/clobber.o
lib/util_sid.o lib/util_unistr.o ../lib/util/charset/codepoints.o
lib/util_file.o lib/util.o lib/util_cmdline.o lib/util_names.o lib/util_sock.o
lib/sock_exec.o lib/util_sec.o lib/substitute.o lib/dbwrap_util.o
lib/ms_fnmatch.o lib/errmap_unix.o lib/tallocmsg.o lib/dmallocmsg.o
libsmb/clisigning.o libsmb/smb_signing.o ../lib/util/charset/iconv.o
intl/lang_tdb.o lib/conn_tdb.o lib/adt_tree.o lib/gencache.o
lib/sessionid_tdb.o lib/module.o lib/events.o ./../lib/tevent/tevent.o
./../lib/tevent/tevent_debug.o ./../lib/tevent/tevent_util.o
./../lib/tevent/tevent_fd.o ./../lib/tevent/tevent_timed.o
./../lib/tevent/tevent_immediate.o ./../lib/tevent/tevent_signal.o
./../lib/tevent/tevent_req.o ./../lib/tevent/tevent_wakeup.o
./../lib/tevent/tevent_queue.o ./../lib/tevent/tevent_standard.o
./../lib/tevent/tevent_select.o ./../lib/tevent/tevent_poll.o
./../lib/tevent/tevent_epoll.o lib/server_contexts.o lib/ldap_escape.o
lib/secdesc.o ../libcli/security/access_check.o ../libcli/security/secace.o
../libcli/security/object_tree.o ../libcli/security/sddl.o
../libcli/security/secacl.o lib/fncall.o libads/krb5_errs.o lib/system_smbd.o
lib/audit.o ../librpc/ndr/ndr_basic.o ../librpc/ndr/ndr.o
../librpc/ndr/ndr_misc.o librpc/gen_ndr/ndr_misc.o
librpc/gen_ndr/ndr_security.o ../librpc/ndr/ndr_sec_helper.o
../librpc/ndr/ndr_string.o ../librpc/ndr/uuid.o librpc/ndr/util.o
librpc/gen_ndr/ndr_server_id.o librpc/gen_ndr/ndr_dcerpc.o lib/file_id.o
lib/idmap_cache.o ../libcli/security/dom_sid.o
../libcli/security/security_descriptor.o ../libcli/security/security_token.o
../libcli/security/util_sid.o lib/dummysmbd.o lib/dummyroot.o libsmb/nterr.o
libsmb/smberr.o ../libcli/util/doserr.o libsmb/errormap.o
../librpc/rpc/dcerpc_error.o ../libcli/auth/smbdes.o
../libcli/auth/smbencrypt.o ../libcli/auth/msrpc_parse.o
../libcli/auth/session.o passdb/secrets.o passdb/machine_account_secrets.o
passdb/machine_sid.o librpc/gen_ndr/ndr_secrets.o lib/filename_util.o -pie
-Wl,-z,relro -O2 -flto -L./bin -Wl,--export-dynamic -lresolv -lresolv -lnsl
-ldl -lrt -lldap -llber -lpopt -ltalloc -ltdb

To make the failure go away, just add -finline-functions. Similarly, changing
-O2 to -O3 also eliminates the error.

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[matt at use dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #7 from Matt Hargett <matt at use dot net> 2012-03-28 03:22:49 UTC ---
Is there any more information I need to provide for this class of issues to be
resolved? Mozilla, WebKit, and others all eventually fail with similar errors.
If there's a proposed fix, I can rebuild and provide test results back in a few
days. Thanks!

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-09 08:53:33 UTC ---
Author: ebotcazou
Date: Mon Apr  9 08:53:27 2012
New Revision: 186237

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186237
Log:
    PR target/52717
    * config/sparc/sparc.c (sparc_file_end): Set TREE_PUBLIC explicitly on
    the DECL generated for the special GOT helper.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sparc/sparc.c

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-09 08:53:54 UTC ---
Author: ebotcazou
Date: Mon Apr  9 08:53:49 2012
New Revision: 186239

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186239
Log:
    PR target/52717
    * config/sparc/sparc.c (sparc_file_end): Set TREE_PUBLIC explicitly on
    the DECL generated for the special GOT helper.

Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/config/sparc/sparc.c

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #9 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-09 08:53:40 UTC ---
Author: ebotcazou
Date: Mon Apr  9 08:53:37 2012
New Revision: 186238

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186238
Log:
    PR target/52717
    * config/sparc/sparc.c (sparc_file_end): Set TREE_PUBLIC explicitly on
    the DECL generated for the special GOT helper.

Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/config/sparc/sparc.c

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #11 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-09 08:54:07 UTC ---
Author: ebotcazou
Date: Mon Apr  9 08:54:03 2012
New Revision: 186240

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186240
Log:
    PR target/52717
    * config/sparc/sparc.c (sparc_file_end): Set TREE_PUBLIC explicitly on
    the DECL generated for the special GOT helper.

Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/config/sparc/sparc.c

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.5.4

--- Comment #12 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-09 08:57:04 UTC ---
Thanks for reporting the problem.

[Bug target/52717] thunk referenced in discarded section when building samba with -flto

[matt at use dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52717

--- Comment #13 from Matt Hargett <matt at use dot net> 2012-04-23 15:19:47 UTC ---
*** Bug 52704 has been marked as a duplicate of this bug. ***