[Bug bootstrap/52808] New: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[Bug bootstrap/52808] New: [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

             Bug #: 52808
           Summary: [4.8 Regression] LTO bootstrap failed with
                    bootstrap-profiled
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: areg.melikadamyan@gmail.com


On Linux/x86-64, revision 186029 failed to LTO bootstrap
with bootstrap-profiled, configured with

--prefix=/usr/local --enable-clocale=gnu --with-system-zlib --enable-shared
--with-demangler-in-ld --with-build-config=bootstrap-lto --with-fpmath=sse
--enable-languages=c,c++,fortran,java,lto,objc

and build with "make profiledbootstrap -j8". Stage3 gcc failed
to configure test in libiberty:

configure:4471:  /export/gnu/import/git/gcc-test-profile/bld/./prev-gcc/xgcc
-B/export/gnu/import/git/gcc-test-profile/bld/./prev-gcc/
-B/usr/local/x86_64-unknown-linux-gnu/bin/
-B/usr/local/x86_64-unknown-linux-gnu/bin/
-B/usr/local/x86_64-unknown-linux-gnu/lib/ -isystem
/usr/local/x86_64-unknown-linux-gnu/include -isystem
/usr/local/x86_64-unknown-linux-gnu/sys-include    -o conftest -g -O2
-flto=jobserver -frandom-seed=1 -fprofile-use  -static-libstdc++ -static-libgcc
 conftest.c  >&5
conftest.c: In function 'main':
conftest.c:29:1: note: file
/export/gnu/import/git/gcc-test-profile/bld/libiberty/conftest.gcda not found,
execution counts estimated
conftest.c:21:1: internal compiler error: in get_loop_body, at cfgloop.c:831
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
configure:4471: $? = 1
configure: program exited with status 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME ""
| #define PACKAGE_TARNAME ""
| #define PACKAGE_VERSION ""
| #define PACKAGE_STRING ""
| #define PACKAGE_BUGREPORT ""
| #define PACKAGE_URL ""
| /* end confdefs.h.  */
| #include <ctype.h>
| #include <stdlib.h>
| #if ((' ' & 0x0FF) == 0x020)
| # define ISLOWER(c) ('a' <= (c) && (c) <= 'z')
| # define TOUPPER(c) (ISLOWER(c) ? 'A' + ((c) - 'a') : (c))
| #else
| # define ISLOWER(c)              (('a' <= (c) && (c) <= 'i')               ||
('j' <= (c) && (c) <= 'r')                   || ('s' <= (c) && (c) <= 'z'))
| # define TOUPPER(c) (ISLOWER(c) ? ((c) | 0x40) : (c))
| #endif
|
| #define XOR(e, f) (((e) && !(f)) || (!(e) && (f)))
| int
| main ()
| {
|   int i;
|   for (i = 0; i < 256; i++)
|     if (XOR (islower (i), ISLOWER (i))
|       || toupper (i) != TOUPPER (i))
|       return 2;
|   return 0;
| }

Revision 185898 is OK.

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-03-31 14:46:11 UTC ---
A small testcase:

[hjl@gnu-16 bld]$ cat x.c
#include <ctype.h>
#if ((' ' & 0x0FF) == 0x020)
# define ISLOWER(c) ('a' <= (c) && (c) <= 'z')
# define TOUPPER(c) (ISLOWER(c) ? 'A' + ((c) - 'a') : (c))
#else
# define ISLOWER(c)              (('a' <= (c) && (c) <= 'i')               ||
('j' <= (c) && (c) <= 'r')                   || ('s' <= (c) && (c) <= 'z'))
# define TOUPPER(c) (ISLOWER(c) ? ((c) | 0x40) : (c))
#endif
#define XOR(e, f) (((e) && !(f)) || (!(e) && (f)))
int
main ()
{
  int i;
  for (i = 0; i < 256; i++)
    if (XOR (islower (i), ISLOWER (i))
      || toupper (i) != TOUPPER (i))
      return 2;
  return 0;
}
[hjl@gnu-16 bld]$ gcc -g -O2 -c -fprofile-use x.c
x.c: In function \u2018main\u2019:
x.c:19:1: note: file /export/gnu/import/git/gcc-test-profile/bld/x.gcda not
found, execution counts estimated
x.c:11:1: internal compiler error: in get_loop_body, at cfgloop.c:831
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-16 bld]$

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-03-31 15:16:11 UTC ---
The error is the same as in pr52797.

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> 2012-03-31 17:07:32 UTC ---
It may be caused by revision 185913:

http://gcc.gnu.org/ml/gcc-cvs/2012-03/msg01244.html

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

Markus Trippelsdorf <markus at trippelsdorf dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markus at trippelsdorf dot
                   |                            |de

--- Comment #4 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2012-04-01 16:09:09 UTC ---
Most likely PR52820 is also a dup.

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #5 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2012-04-01 16:14:15 UTC ---
*** Bug 52820 has been marked as a duplicate of this bug. ***

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-04-02
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.8.0
     Ever Confirmed|0                           |1

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-02 09:13:44 UTC ---
Mine.

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |52756

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-02 10:39:39 UTC ---
The fix for this depends on fixing PR52756.  The issue here is -ftracer.

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-03 11:38:10 UTC ---
Author: rguenth
Date: Tue Apr  3 11:38:04 2012
New Revision: 186104

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186104
Log:
2012-04-03  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/52808
    * tracer.c (tail_duplicate): Return whether we have duplicated
    any block.
    (tracer): If we have duplicated any block, cleanup the CFG.
    * cfghooks.c (duplicate_block): If we duplicated a loop
    header but not its loop, destroy the loop because it now has
    multiple entries.
    * tree-ssa-threadupdate.c (thread_through_loop_header): Tell
    the cfg manipulation routines we are not creating a multiple
    entry loop.

    * gcc.dg/pr52808.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/pr52808.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfghooks.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tracer.c
    trunk/gcc/tree-ssa-threadupdate.c

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-03 11:38:43 UTC ---
Fixed!

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #10 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2012-04-03 14:08:36 UTC ---
Created attachment 27073
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27073
unreduced testcase

Unfortunately LTO bootstrap with bootstrap-profiled still fails
even after your fix:

 % /var/tmp/gcc_build_dir/./prev-gcc/xgcc -B/var/tmp/gcc_build_dir/./prev-gcc/
-B/usr/x86_64-pc-linux-gnu/bin/ -B/usr/x86_64-pc-linux-gnu/bin/
-B/usr/x86_64-pc-linux-gnu/lib/ -fprofile-use hashtab.i -O2
/home/markus/gcc/libiberty/hashtab.c: In function ‘htab_find_slot_with_hash’:
/home/markus/gcc/libiberty/hashtab.c:704:1: internal compiler error: in
get_loop_body, at cfgloop.c:831

Testcase (with .gcda file) is attached.

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-03 14:17:03 UTC ---
Confirmed.  Still tracer is the issue.  Testcase reduction appreciated (heh
...)

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[markus at trippelsdorf dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #12 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2012-04-03 17:13:27 UTC ---
Created attachment 27077
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27077
reduced testcase

Reduced with c_reduce (still needs hashtab.gcda)

 $ gcc -funroll-loops -ftracer -fvpt -fbranch-probabilities -O2 -w -c hashtab.i
hashtab.i: In function ‘htab_find_slot_with_hash’:
hashtab.i:437:1: internal compiler error: in get_loop_body, at cfgloop.c:831

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

--- Comment #13 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-04 12:12:07 UTC ---
Author: rguenth
Date: Wed Apr  4 12:12:00 2012
New Revision: 186135

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186135
Log:
2012-04-04  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/52808
    * tracer.c (tail_duplicate): Do not tail-duplicate loop header
    blocks.
    * Makefile.in (tracer.o): Depend on $(CFGLOOP_H).

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in
    trunk/gcc/tracer.c

[Bug bootstrap/52808] [4.8 Regression] LTO bootstrap failed with bootstrap-profiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52808

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-04 12:22:21 UTC ---
Fixed.