[Bug c++/52841] New: [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[Bug c++/52841] New: [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

             Bug #: 52841
           Summary: [4.7/4.8 Regression] error: type 'Solvable' is not a
                    base type for type 'Resolvable'
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Keywords: rejects-valid
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rguenth@gcc.gnu.org


struct Solvable;
namespace sat
{
  class Solvable
    {
  public:
      typedef bool bool_type;
    };
}

class Resolvable : public sat::Solvable
{
public:
  using sat::Solvable::bool_type;
};

when compiled with -std=c++0x is rejected with

T.cc:14:28: error: type 'Solvable' is not a base type for type 'Resolvable'

It works when using

  using Solvable::bool_type

and when

  using ::sat::Solvable::bool_type

and it works without -std=c++0x

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.6.3
   Target Milestone|---                         |4.7.1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-03 12:15:51 UTC ---
The following is rejected as well, with the same error

struct Solvable;
namespace sat
{
  class Solvable
    {
  public:
      typedef bool bool_type;
    };
}
namespace sat2
{
  class Solvable
    {
  public:
      typedef bool bool_type;
    };
}

class Resolvable : public sat::Solvable, sat2::Solvable
{
public:
  using Solvable::bool_type;
};

only qualifying with ::sat[2]::Solvable::bool_type works.

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabien at gcc dot gnu.org

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-04-03 13:05:39 UTC ---
Fabien, could you take a look at this one too?

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

fabien at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |fabien at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from fabien at gcc dot gnu.org 2012-04-03 20:06:54 UTC ---
I'm busy this week, but I will look into it next week.

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[david.abdurachmanov at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

David Abdurachmanov <david.abdurachmanov at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.abdurachmanov at
                   |                            |gmail dot com

--- Comment #4 from David Abdurachmanov <david.abdurachmanov at gmail dot com> 2012-04-06 19:39:18 UTC ---
I can confirm the issue. Run into the problem when re-compiling a project with
C++11.

Works fine in C++98/03, does not compile in C++11. Both work-arounds suggested
in the first comment works.

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-04-12
     Ever Confirmed|0                           |1

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-04-12 12:28:55 UTC ---
Ping?

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #6 from fabien at gcc dot gnu.org 2012-04-12 12:50:31 UTC ---
(In reply to comment #5)
> Ping?

I haven't yet finished the investigation. Something is broken in c++11 mode,
the parsing of Solvable in "using sat::Solvable::bool_type;" is failing in
c++11 mode, debug_tree() is crashing while debugging it.

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #7 from fabien at gcc dot gnu.org 2012-04-17 21:06:52 UTC ---
Created attachment 27180
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27180
return earlier in cp_parser_alias_declaration

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #8 from fabien at gcc dot gnu.org 2012-04-17 21:08:13 UTC ---
It is related to alias declarations. It seems that we do not recover properly
from a failure in cp_parser_alias_declaration, in the block introduced by this
check: "if (!(flags & CP_PARSER_FLAGS_NO_USER_DEFINED_TYPES))", around here:

#0  cp_parser_simple_type_specifier (parser=0x7ffff571b738,
decl_specs=0x7fffffffdd00, flags=1) at ../../gcc/gcc/cp/parser.c:13651
#1  0x00000000006be5e0 in cp_parser_type_specifier (parser=0x7ffff571b738,
flags=1, decl_specs=0x7fffffffdd00, is_declaration=0 '\000',
declares_class_or_enum=0x0, is_cv_qualifier=0x7fffffffdcde "") at
../../gcc/gcc/cp/parser.c:13434
#2  0x00000000006c5c96 in cp_parser_type_specifier_seq (parser=0x7ffff571b738,
is_declaration=0 '\000', is_trailing_return=0 '\000',
type_specifier_seq=0x7fffffffdd00) at ../../gcc/gcc/cp/parser.c:16887
#3  0x00000000006c5a63 in cp_parser_type_id_1 (parser=0x7ffff571b738,
is_template_arg=0 '\000', is_trailing_return=0 '\000') at
../../gcc/gcc/cp/parser.c:16771
#4  0x00000000006c5b57 in cp_parser_type_id (parser=0x7ffff571b738) at
../../gcc/gcc/cp/parser.c:16810
#5  0x00000000006c1987 in cp_parser_alias_declaration (parser=0x7ffff571b738)
at ../../gcc/gcc/cp/parser.c:15101

I can't find what goes wrong there. The good news is that it seems to work if
we return earlier in cp_parser_alias_declaration -- which I think is better --,
like in the attached patch.

Perhaps Dodji (or Jason) can take a closer look ?

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-05-03 11:23:33 UTC ---
Ping?

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

fabien at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING
         AssignedTo|fabien at gcc dot gnu.org   |unassigned at gcc dot
                   |                            |gnu.org

--- Comment #10 from fabien at gcc dot gnu.org 2012-05-04 19:45:46 UTC ---
I no longer work on it, so it is more honest to set this bug as unassigned.

The patch I attached here fixes the problem, because it bypasses a deeper
issues.
Returning the earliest possible in cp_parser_alias_declaration makes sense to
me because there are probably much more using-declarations than
alias-declarations to parse at the moment. However, I do not want to submit it
because I think we should fix the real issue as well.

I had a look on non-matching parse_tentatively/definitely, without finding
anything suspect. If one needs some details about what goes wrong -- if I was
unclear here and in previous comments --, do not hesitate to ask me.

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-05-04 19:50:04 UTC ---
then it should really be status=NEW, you're not waiting for details from the
reporter

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[fabien at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

fabien at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b.r.longbons at gmail dot
                   |                            |com

--- Comment #12 from fabien at gcc dot gnu.org 2012-05-05 17:57:27 UTC ---
*** Bug 53247 has been marked as a duplicate of this bug. ***

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Paul Pluzhnikov <ppluzhnikov at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppluzhnikov at google dot
                   |                            |com

--- Comment #13 from Paul Pluzhnikov <ppluzhnikov at google dot com> 2012-05-16 03:09:56 UTC ---
*** Bug 53368 has been marked as a duplicate of this bug. ***

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> 2012-05-16 03:22:36 UTC ---
This is triggered by revision 181118:

http://gcc.gnu.org/ml/gcc-cvs/2011-11/msg00406.html

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[ppluzhnikov at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #15 from Paul Pluzhnikov <ppluzhnikov at google dot com> 2012-05-30 19:13:02 UTC ---
I've got another small reproducer, that shows up as a slightly different
failure, but very likely is the same problem:

namespace util { }   // comment out => problem disappears
namespace foo {
  namespace util {
    struct Printer {
      struct Convert {
      };
    };
    class XPrinter: Printer {
      // using ::foo::util::Printer::Convert;  // ok
      // using Printer::Convert;               // ok
      using foo::util::Printer::Convert;       // error
    };
  }
}


g++ --version
g++ (GCC) 4.8.0 20120515 (experimental)

g++ -c pp.ii -std=c++11
pp.ii:13:24: error: ‘util::Printer’ has not been declared
       using foo::util::Printer::Convert; // error

g++ -c pp.ii -std=c++98 && echo ok
ok

[Bug c++/52841] [4.7/4.8 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #16 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-06 12:22:25 UTC ---
Author: rguenth
Date: Wed Jun  6 12:22:16 2012
New Revision: 188264

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188264
Log:
2012-06-06  Fabien Chene  <fabien@gcc.gnu.org>

    PR c++/52841
    * parser.c (cp_parser_alias_declaration): Return earlier
    if an error occured.

    * g++.dg/cpp0x/pr52841.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/pr52841.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/52841] [4.7 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.8.0
            Summary|[4.7/4.8 Regression] error: |[4.7 Regression] error:
                   |type 'Solvable' is not a    |type 'Solvable' is not a
                   |base type for type          |base type for type
                   |'Resolvable'                |'Resolvable'

--- Comment #16 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-06 12:22:25 UTC ---
Author: rguenth
Date: Wed Jun  6 12:22:16 2012
New Revision: 188264

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188264
Log:
2012-06-06  Fabien Chene  <fabien@gcc.gnu.org>

    PR c++/52841
    * parser.c (cp_parser_alias_declaration): Return earlier
    if an error occured.

    * g++.dg/cpp0x/pr52841.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/pr52841.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

--- Comment #17 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-06 12:23:00 UTC ---
Fixed for trunk for now.

[Bug c++/52841] [4.7 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.8.0
            Summary|[4.7/4.8 Regression] error: |[4.7 Regression] error:
                   |type 'Solvable' is not a    |type 'Solvable' is not a
                   |base type for type          |base type for type
                   |'Resolvable'                |'Resolvable'

--- Comment #17 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-06 12:23:00 UTC ---
Fixed for trunk for now.

[Bug c++/52841] [4.7 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.1                       |4.7.2

--- Comment #18 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-14 08:44:41 UTC ---
GCC 4.7.1 is being released, adjusting target milestone.

[Bug c++/52841] [4.7 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

--- Comment #19 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-14 12:55:19 UTC ---
Author: rguenth
Date: Thu Jun 14 12:55:11 2012
New Revision: 188613

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188613
Log:
2012-06-14  Richard Guenther  <rguenther@suse.de>

        Backport from mainline
        2012-06-06  Fabien Chene  <fabien@gcc.gnu.org>

    PR c++/52841
    * parser.c (cp_parser_alias_declaration): Return earlier
    if an error occured.

    * g++.dg/cpp0x/pr52841.C: New testcase.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/cpp0x/pr52841.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/ChangeLog
    branches/gcc-4_7-branch/gcc/cp/parser.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug c++/52841] [4.7 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-14 12:55:19 UTC ---
Author: rguenth
Date: Thu Jun 14 12:55:11 2012
New Revision: 188613

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188613
Log:
2012-06-14  Richard Guenther  <rguenther@suse.de>

        Backport from mainline
        2012-06-06  Fabien Chene  <fabien@gcc.gnu.org>

    PR c++/52841
    * parser.c (cp_parser_alias_declaration): Return earlier
    if an error occured.

    * g++.dg/cpp0x/pr52841.C: New testcase.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/cpp0x/pr52841.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/ChangeLog
    branches/gcc-4_7-branch/gcc/cp/parser.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

--- Comment #20 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-14 12:55:42 UTC ---
Fixed.

[Bug c++/52841] [4.7 Regression] error: type 'Solvable' is not a base type for type 'Resolvable'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52841

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-14 12:55:42 UTC ---
Fixed.