[Bug plugins/52872] New: --enable-plugin; incorrrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[Bug plugins/52872] New: --enable-plugin; incorrrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[rainer@emrich-ebersheim.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

             Bug #: 52872
           Summary: --enable-plugin; incorrrect test for "exported
                    symbols" and "-rdynamic" in gcc/configure.ac
    Classification: Unclassified
           Product: gcc
           Version: 4.4.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: plugins
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rainer@emrich-ebersheim.de


On systems with non empty $exeext the configure tests are failing with:

checking for exported symbols...
d:\opt\devel\gnu\gcc\MINGW_NT\x86_64-w64-mingw32\mingw-w64-runtime-trunk-svn\gcc-4.6.1\bin\objdump.exe:
'conftest': No such file
checking for -rdynamic...
d:\opt\devel\gnu\gcc\MINGW_NT\x86_64-w64-mingw32\mingw-w64-runtime-trunk-svn\gcc-4.6.1\bin\objdump.exe:
'conftest': No such file

All active branches are affected!

possible patch against trunk, see below.

I'm not really sure if this is the right thing to do for a cross setup or if we
have to use $host_exeext. Anyway, something along the lines should fix it, al
least for a native bootstrap.


diff -Naur gcc-trunk/gcc/configure.ac gcc-new/gcc/configure.ac
--- gcc-trunk/gcc/configure.ac  2012-03-29 18:25:52.789019300 +0200
+++ gcc-new/gcc/configure.ac    2012-04-04 19:02:29.669435800 +0200
@@ -5021,14 +5021,14 @@
   if test "x$export_sym_check" != x; then
     echo "int main() {return 0;} int foobar() {return 0;}" > conftest.c
     ${CC} ${CFLAGS} ${LDFLAGS} conftest.c -o conftest > /dev/null 2>&1
-    if $export_sym_check conftest | grep foobar > /dev/null; then
+    if $export_sym_check conftest${exeext} | grep foobar > /dev/null; then
       : # No need to use a flag
       AC_MSG_RESULT([yes])
     else
       AC_MSG_RESULT([yes])
       AC_MSG_CHECKING([for -rdynamic])
       ${CC} ${CFLAGS} ${LDFLAGS} -rdynamic conftest.c -o conftest > /dev/null
2>&1
-      if $export_sym_check conftest | grep foobar > /dev/null; then
+      if $export_sym_check conftest${exeext} | grep foobar > /dev/null; then
         plugin_rdynamic=yes
         pluginlibs="-rdynamic"
       else

[Bug plugins/52872] --enable-plugin; incorrrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-04-04 17:18:22 UTC ---
It really won't change that much as -rdynamic and exported symbols are not
supported on windows right now anyways.

[Bug plugins/52872] --enable-plugin; incorrrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[rainer@emrich-ebersheim.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #2 from Rainer Emrich <rainer@emrich-ebersheim.de> 2012-04-04 17:22:19 UTC ---
(In reply to comment #1)
> It really won't change that much as -rdynamic and exported symbols are not
> supported on windows right now anyways.

Agreed, but I think it's pretty easy to correct this at least on trunk, before
it bites us later on.

[Bug plugins/52872] --enable-plugin; incorrrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-11-29
                 CC|                            |ktietz at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #3 from Kai Tietz <ktietz at gcc dot gnu.org> 2012-11-29 21:42:28 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > It really won't change that much as -rdynamic and exported symbols are not
> > supported on windows right now anyways.
> 
> Agreed, but I think it's pretty easy to correct this at least on trunk, before
> it bites us later on.

Yes, thoses features aren't available for pe-coff targets. I still agree that
we should at least try to keep tests working as intended, and not breaking
things by a bug.  Please sent patches for it to ML.

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[k2k at narod dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #4 from Karlson2k <k2k at narod dot ru> 2013-03-03 10:25:47 UTC ---
Created attachment 29569
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29569
Possible patch

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[k2k at narod dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

Karlson2k <k2k at narod dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |k2k at narod dot ru

--- Comment #5 from Karlson2k <k2k at narod dot ru> 2013-03-03 10:27:36 UTC ---
Simple patch is attached.

--- gcc/configure.ac.orig    2012-09-13 17:32:31 +0400
+++ gcc/configure.ac    2013-03-03 14:15:11 +0400
@@ -5117,15 +5117,15 @@ if test x"$enable_plugin" = x"yes"; then
   AC_MSG_CHECKING([for exported symbols])
   if test "x$export_sym_check" != x; then
     echo "int main() {return 0;} int foobar() {return 0;}" > conftest.c
-    ${CC} ${CFLAGS} ${LDFLAGS} conftest.c -o conftest > /dev/null 2>&1
-    if $export_sym_check conftest | grep foobar > /dev/null; then
+    ${CC} ${CFLAGS} ${LDFLAGS} conftest.c -o conftest$ac_exeext > /dev/null
2>&1
+    if $export_sym_check conftest$ac_exeext | grep foobar > /dev/null; then
       : # No need to use a flag
       AC_MSG_RESULT([yes])
     else
       AC_MSG_RESULT([yes])
       AC_MSG_CHECKING([for -rdynamic])
-      ${CC} ${CFLAGS} ${LDFLAGS} -rdynamic conftest.c -o conftest > /dev/null
2>&1
-      if $export_sym_check conftest | grep foobar > /dev/null; then
+      ${CC} ${CFLAGS} ${LDFLAGS} -rdynamic conftest.c -o conftest$ac_exeext >
/dev/null 2>&1
+      if $export_sym_check conftest$ac_exeext | grep foobar > /dev/null; then
         plugin_rdynamic=yes
         pluginlibs="-rdynamic"
       else


Should I sent it to mailing list?

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #6 from Kai Tietz <ktietz at gcc dot gnu.org> 2013-03-03 10:29:42 UTC ---
Yes, patch looks reasonable.  Please sent it to patch ML.
This patch is small, so it is ok, but do you have already made paper-work with
FSF for gcc?

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[k2k at narod dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #7 from Karlson2k <k2k at narod dot ru> 2013-03-03 14:57:11 UTC ---
(In reply to comment #6)
> Yes, patch looks reasonable.  Please sent it to patch ML.
> This patch is small, so it is ok, but do you have already made paper-work with
> FSF for gcc?

This patch is simple as possible, to be quickly get it.
But there are some space to improvement (like using standard macros, properly
redirect error output). I'm not sure is it worth to work on it.
To answer your question: no. What should I do?

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #8 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Author: ktietz
Date: Sun Nov 10 19:27:38 2013
New Revision: 204651

URL: http://gcc.gnu.org/viewcvs?rev=204651&root=gcc&view=rev
Log:
Fixed typo about bug-number ...

        PR plugin/52872
        * configure.ac: Adding for exported symbols check
        and for rdynamic-check executable-extension.
        * configure: Regenerated.

Modified:
    trunk/gcc/ChangeLog

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #9 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Author: ktietz
Date: Sun Nov 10 19:29:34 2013
New Revision: 204652

URL: http://gcc.gnu.org/viewcvs?rev=204652&root=gcc&view=rev
Log:
    Merged from trunk
    PR plugins/52872
    * configure.ac: Adding for exported symbols check
    and for rdynamic-check executable-extension.
    * configure: Regenerated.


Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/configure
    branches/gcc-4_8-branch/gcc/configure.ac

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

--- Comment #10 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Author: ktietz
Date: Sun Nov 10 19:32:42 2013
New Revision: 204653

URL: http://gcc.gnu.org/viewcvs?rev=204653&root=gcc&view=rev
Log:
    Merged from trunk
    PR plugins/52872
    * configure.ac: Adding for exported symbols check
    and for rdynamic-check executable-extension.
    * configure: Regenerated.


Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/configure
    branches/gcc-4_7-branch/gcc/configure.ac

[Bug plugins/52872] --enable-plugin; incorrect test for "exported symbols" and "-rdynamic" in gcc/configure.ac

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52872

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Fixed issue for all open branches ...
therefore close issue.