[Bug bootstrap/52878] New: sparc64 bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[Bug bootstrap/52878] New: sparc64 bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

             Bug #: 52878
           Summary: sparc64 bootstrap failure: "MASK_LONG_DOUBLE_128"
                    redefined
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jamborm@gcc.gnu.org
                CC: hjl.tools@gmail.com
              Host: sparc64-linux-gnu
            Target: sparc64-linux-gnu


Starting with revision:

------------------------------------------------------------------------
r185882 | hjl | 2012-03-27 17:28:41 +0200 (Tue, 27 Mar 2012) | 11 lines

Remove MaskNeeded

2012-03-27  H.J. Lu  <hongjiu.lu@intel.com>

        * opth-gen.awk: Allocated a bit for Mask and InverseMask if it
        hasn't been allocated.  Define a target macro for Mask and
        InverseMask if it hasn't been defined.  Remove MaskExists
        handling.

        * doc/options.texi: Remove MaskNeeded.

------------------------------------------------------------------------

sparc64-linux-gnu (gcc63.fsffrance.org) bootstrap fails with:


/home/jamborm/gcc/mine/b-obj/./prev-gcc/g++
-B/home/jamborm/gcc/mine/b-obj/./prev-gcc/
-B/home/jamborm/gcc/mine/inst/sparc64-unknown-linux-gnu/bin/ -nostdinc++
-B/home/jamborm/gcc/mine/b-obj/prev-sparc64-unknown-linux-gnu/libstdc++-v3/src/.libs
-B/home/jamborm/gcc/mine/b-obj/prev-sparc64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-I/home/jamborm/gcc/mine/b-obj/prev-sparc64-unknown-linux-gnu/libstdc++-v3/include/sparc64-unknown-linux-gnu
-I/home/jamborm/gcc/mine/b-obj/prev-sparc64-unknown-linux-gnu/libstdc++-v3/include
-I/home/jamborm/gcc/mine/src/libstdc++-v3/libsupc++
-L/home/jamborm/gcc/mine/b-obj/prev-sparc64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/jamborm/gcc/mine/b-obj/prev-sparc64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-c   -g -O2 -gtoggle -DIN_GCC   -fno-exceptions -fno-rtti -W -Wall
-Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common
 -DHAVE_CONFIG_H -I. -I. -I/home/jamborm/gcc/mine/src/gcc
-I/home/jamborm/gcc/mine/src/gcc/. -I/home/jamborm/gcc/mine/src/gcc/../include
-I/home/jamborm/gcc/mine/src/gcc/../libcpp/include
-I/opt/cfarm/gmp-4.2.4-64/include -I/opt/cfarm/mpfr-2.4.1-64/include
-I/opt/cfarm/mpc-0.8-64/include 
-I/home/jamborm/gcc/mine/src/gcc/../libdecnumber
-I/home/jamborm/gcc/mine/src/gcc/../libdecnumber/dpd -I../libdecnumber   
/home/jamborm/gcc/mine/src/gcc/lto-wrapper.c -o lto-wrapper.o
build/genhooks "Target Hook" \               
                                             > tmp-target-hooks-def.h
build/genhooks "C Target Hook" \             
                                             > tmp-c-target-hooks-def.h
/bin/sh /home/jamborm/gcc/mine/src/gcc/../move-if-change tmp-target-hooks-def.h
\
                                             target-hooks-def.h
/bin/sh /home/jamborm/gcc/mine/src/gcc/../move-if-change
tmp-c-target-hooks-def.h \
                                             c-family/c-target-hooks-def.h
build/genhooks "Common Target Hook" \        
                                             > tmp-common-target-hooks-def.h
build/genhooks -d \     
                        /home/jamborm/gcc/mine/src/gcc/doc/tm.texi.in >
tmp-tm.texi
/bin/sh /home/jamborm/gcc/mine/src/gcc/../move-if-change
tmp-common-target-hooks-def.h \
                                             common/common-target-hooks-def.h
echo timestamp > s-target-hooks-def-h
echo timestamp > s-c-target-hooks-def-h
case `echo X|tr X '\101'` in \
          A) tr -d '\015' < tmp-tm.texi > tmp2-tm.texi ;; \
          *) tr -d '\r' < tmp-tm.texi > tmp2-tm.texi ;; \
        esac
echo timestamp > s-common-target-hooks-def-h
mv tmp2-tm.texi tmp-tm.texi
/bin/sh /home/jamborm/gcc/mine/src/gcc/../move-if-change tmp-tm.texi tm.texi
In file included from /home/jamborm/gcc/mine/src/gcc/lto-wrapper.c:47:0:
./options.h:3564:0: error: "MASK_LONG_DOUBLE_128" redefined [-Werror]
./options.h:3554:0: note: this is the location of the previous definition
if [ xinfo = xinfo ]; then \
                makeinfo --split-size=5000000 --split-size=5000000
--split-size=5000000 --no-split -I . -I /home/jamborm/gcc/mine/src/gcc/doc \
                        -I /home/jamborm/gcc/mine/src/gcc/doc/include -o
doc/gccint.info /home/jamborm/gcc/mine/src/gcc/doc/gccint.texi; \
        fi
cc1plus: all warnings being treated as errors
make[3]: *** [lto-wrapper.o] Error 1
make[3]: *** Waiting for unfinished jobs....
rm gfdl.pod cpp.pod gcov.pod fsf-funding.pod gcc.pod
make[3]: Leaving directory `/home/jamborm/gcc/mine/b-obj/gcc'

[Bug bootstrap/52878] sparc64 bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-05 16:10:41 UTC ---
Created attachment 27102
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27102
A patch

This patch works for Linux/sparc. But it may not work
for all sparc targets which don't include long-double-switch.opt.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-04-06
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
   Target Milestone|---                         |4.8.0
            Summary|sparc64 bootstrap failure:  |[4.8 regression] bootstrap
                   |"MASK_LONG_DOUBLE_128"      |failure:
                   |redefined                   |"MASK_LONG_DOUBLE_128"
                   |                            |redefined
     Ever Confirmed|0                           |1

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-06 06:37:07 UTC ---
> This patch works for Linux/sparc. But it may not work
> for all sparc targets which don't include long-double-switch.opt.

You can easily find this out, just build a cross to sparc-elf.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-06 12:23:46 UTC ---
(In reply to comment #1)
> Created attachment 27102 [details]
> A patch
> 
> This patch works for Linux/sparc. But it may not work
> for all sparc targets which don't include long-double-switch.opt.

This addition:

diff --git a/gcc/config/sparc/sparc.h b/gcc/config/sparc/sparc.h
index a1919b4..a04f8ef 100644
--- a/gcc/config/sparc/sparc.h
+++ b/gcc/config/sparc/sparc.h
@@ -53,6 +53,14 @@ along with GCC; see the file COPYING3.  If not see
 #endif /* IN_LIBGCC2 */
 #define TARGET_ARCH64 (! TARGET_ARCH32)

+#ifndef TARGET_LONG_DOUBLE_128
+#define TARGET_LONG_DOUBLE_128 0
+#endif
+
+#ifndef MASK_LONG_DOUBLE_128
+#define MASK_LONG_DOUBLE_128 0
+#endif
+
 /* Code model selection in 64-bit environment.

    The machine mode used for addresses is 32-bit wide:

is also needed.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

Mikael Pettersson <mikpe at it dot uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikpe at it dot uu.se

--- Comment #4 from Mikael Pettersson <mikpe at it dot uu.se> 2012-04-16 07:13:09 UTC ---
Can someone please fix this bootstrap failure?  It's now been three weeks that
trunk hasn't bootstrapped on sparc64-linux.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #5 from Mikael Pettersson <mikpe at it dot uu.se> 2012-04-18 16:38:18 UTC ---
Created attachment 27183
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27183
combined patch

I've combined HJ's two patches to one and verified that it restores bootstrap
on sparc64-linux.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-18 17:23:24 UTC ---
> I've combined HJ's two patches to one and verified that it restores bootstrap
> on sparc64-linux.

But it probably breaks SPARC/Solaris, as TARGET_LONG_DOUBLE_128 must be
non-zero for this target.  MASK_LONG_DOUBLE_128 and TARGET_LONG_DOUBLE_128 must
always be defined to meaningful values, irrespective of whether
long-double-switch.opt is included; that's why sparc.opt also contains the
entry.

If the original patch breaks this mechanism, it should IMO provide a general
replacement, as other architectures might be affected.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-18 17:32:38 UTC ---
If someone can provide a description of what TARGET_LONG_DOUBLE_128
should be in all cases, I can try to come up with a patch.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-18 20:59:16 UTC ---
> If someone can provide a description of what TARGET_LONG_DOUBLE_128
> should be in all cases, I can try to come up with a patch.

It should be:

options.h:#define MASK_LONG_DOUBLE_128 (1 << 16)
options.h:#define TARGET_LONG_DOUBLE_128 ((target_flags & MASK_LONG_DOUBLE_128)
!= 0)

on SPARC/Solaris, but of course the (1 << 16) is dependent on other options, so
a patch that hardcodes it isn't acceptable, IOW this must be fixed in
opth-gen.awk.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-18 21:04:37 UTC ---
(In reply to comment #8)
> > If someone can provide a description of what TARGET_LONG_DOUBLE_128
> > should be in all cases, I can try to come up with a patch.
> 
> It should be:
> 
> options.h:#define MASK_LONG_DOUBLE_128 (1 << 16)
> options.h:#define TARGET_LONG_DOUBLE_128 ((target_flags & MASK_LONG_DOUBLE_128)
> != 0)
> 
> on SPARC/Solaris, but of course the (1 << 16) is dependent on other options, so
> a patch that hardcodes it isn't acceptable, IOW this must be fixed in
> opth-gen.awk.

For a target which doesn't use long-double-switch.opt, will
TARGET_LONG_DOUBLE_128 be a fixed value? If no, how is its
value determined? If yes, what is the fixed value?

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-18 21:17:47 UTC ---
> For a target which doesn't use long-double-switch.opt, will
> TARGET_LONG_DOUBLE_128 be a fixed value? If no, how is its
> value determined? If yes, what is the fixed value?

Yes, and it is determined by setting the mask flag MASK_LONG_DOUBLE_128 in
TARGET_DEFAULT, see e.g. sol2.h.  Harcoding any value isn't acceptable.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #11 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-18 21:42:39 UTC ---
One approach is to provide masks.opt to provide those masks without
switch.  masks.opt should be used when long-double-switch.opt isn't
used.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27102|0                           |1
        is obsolete|                            |
  Attachment #27183|0                           |1
        is obsolete|                            |

--- Comment #12 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-19 00:12:13 UTC ---
Created attachment 27184
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27184
A new patch

This patch adds config/sparc/sparc.opt and uses it when
config/sparc/long-double-switch.opt isn't used.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #13 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-04-19 08:40:53 UTC ---
> One approach is to provide masks.opt to provide those masks without
> switch.  masks.opt should be used when long-double-switch.opt isn't
> used.

How ugly.  Please do something in opth-gen.awk instead, or revert the patch.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27184|0                           |1
        is obsolete|                            |

--- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-19 17:17:51 UTC ---
Created attachment 27192
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27192
A patch

Please try this patch.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[mikpe at it dot uu.se]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #15 from Mikael Pettersson <mikpe at it dot uu.se> 2012-04-20 20:15:32 UTC ---
(In reply to comment #14)
> Created attachment 27192 [details]
> A patch
> 
> Please try this patch.

With this patch I'm able to bootstrap gcc-4.8-20120415 on sparc64-linux.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu.org

--- Comment #16 from Richard Henderson <rth at gcc dot gnu.org> 2012-04-23 23:20:43 UTC ---
(In reply to comment #14)

The patch looks hackish, as if there's an artificial distinction
between "normal" masks and extra masks.  Why is that?

That said, please commit the tested patch as-is, so that we repair
the bootstrap breakage.  Cleanups to "extra" can come later.

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

--- Comment #17 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2012-04-23 23:32:58 UTC ---
Author: hjl
Date: Mon Apr 23 23:32:54 2012
New Revision: 186729

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186729
Log:
Check if MASK_/TARGET_ macros defined for extra_masks

2012-04-23  H.J. Lu  <hongjiu.lu@intel.com>

    PR bootstrap/52878
    * opth-gen.awk: Check if MASK_ and TARGET_ macros are defined for
    extra_masks.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/opth-gen.awk

[Bug bootstrap/52878] [4.8 regression] bootstrap failure: "MASK_LONG_DOUBLE_128" redefined

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52878

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-05-26 13:38:35 UTC ---
.