* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
@ 2012-04-09 19:10 ` tkoenig at gcc dot gnu.org
2012-04-10 10:03 ` burnus at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tkoenig at gcc dot gnu.org @ 2012-04-09 19:10 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |WAITING
Last reconfirmed| |2012-04-09
CC| |tkoenig at gcc dot gnu.org
Ever Confirmed|0 |1
--- Comment #1 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2012-04-09 19:09:51 UTC ---
Reduced test case?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
2012-04-09 19:10 ` [Bug fortran/52916] " tkoenig at gcc dot gnu.org
@ 2012-04-10 10:03 ` burnus at gcc dot gnu.org
2012-04-10 10:29 ` burnus at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-04-10 10:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |wrong-code
CC| |burnus at gcc dot gnu.org
Target Milestone|--- |4.8.0
--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-04-10 10:02:13 UTC ---
That's probably due to my patch for PR 40973 / PR 52751 (Rev. 186223). That
patch marked functions/subroutines and variables from MODULES as
TREE_PUBLIC() = 0, if they have the PRIVATE attribute and no C-binding name.
That will definitely fail if one accesses the procedures directly, e.g. from C
via
"__moduleName_MOD_subroutine ();". The question is whether 481.wrf does so
(probably not). However, I fail to see how it could otherwise encounter the
problem.
As I do not have access to SPEC CPU, I would be happy if someone could provide
more information. (Best would be a test case.) As a first step: Are the missing
symbols procedures or (global) variables? Or both?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
2012-04-09 19:10 ` [Bug fortran/52916] " tkoenig at gcc dot gnu.org
2012-04-10 10:03 ` burnus at gcc dot gnu.org
@ 2012-04-10 10:29 ` burnus at gcc dot gnu.org
2012-04-11 19:12 ` burnus at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-04-10 10:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |NEW
--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-04-10 10:27:37 UTC ---
Found the information I was looking for at
http://www.cesm.ucar.edu/models/cesm1.0/cesm/cesmBbrowser/html_code/esmf_wrf_timemgr/ESMF_TimeMod.F90.html
The problem is that the PRIVATE module procedure is used as specific procedure
for an operator (which is PUBLIC).
Thus, one cannot set the TREE_PUBLIC() = 0 for PRIVATE procedures, if
(a) the generic procedure / user-defined operator/assignment is not also
PRIVATE
(b) a procedure is used as type-bound procedure in a nonabstract nonprivate
TYPE declaration.
[(c) if the (sub)module has a submodule. (Note: Currently, no submodules are
supported.)]
The simplest might be to add another attribute - and set it during resolution.
Workaround: Undo the "build_function_decl" part of the commit Rev. 186223 - or
revert the complete commit.
Test case, which will produce at link time with any optimization level:
undefined reference to `__m_MOD_bar'
! ----- FILE 1 ----
module m
interface gen
module procedure bar
end interface gen
private :: bar
contains
subroutine bar()
print *, "bar"
end subroutine bar
end module m
! ----- FILE 2 ----
use m
call gen()
end
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
` (2 preceding siblings ...)
2012-04-10 10:29 ` burnus at gcc dot gnu.org
@ 2012-04-11 19:12 ` burnus at gcc dot gnu.org
2012-04-12 13:57 ` izamyatin at gmail dot com
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-04-11 19:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-04-11 19:11:46 UTC ---
Submitted patch: http://gcc.gnu.org/ml/fortran/2012-04/msg00055.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
` (3 preceding siblings ...)
2012-04-11 19:12 ` burnus at gcc dot gnu.org
@ 2012-04-12 13:57 ` izamyatin at gmail dot com
2012-04-15 5:55 ` burnus at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: izamyatin at gmail dot com @ 2012-04-12 13:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
--- Comment #5 from Igor Zamyatin <izamyatin at gmail dot com> 2012-04-12 13:55:54 UTC ---
With this patch 481.wrf is ok
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
` (4 preceding siblings ...)
2012-04-12 13:57 ` izamyatin at gmail dot com
@ 2012-04-15 5:55 ` burnus at gcc dot gnu.org
2012-04-16 21:39 ` burnus at gcc dot gnu.org
2012-04-18 8:21 ` burnus at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-04-15 5:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-04-15 05:52:58 UTC ---
Author: burnus
Date: Sun Apr 15 05:52:51 2012
New Revision: 186464
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186464
Log:
2012-04-14 Tobias Burnus <burnus@net-b.de>
PR fortran/52916
PR fortran/40973
* gfortran.h (symbol_attribute): Add public_used.
* interface.c (check_sym_interfaces, check_uop_interfaces,
gfc_check_interfaces): Set it.
* resolve.c (resolve_typebound_procedure): Ditto.
* trans-decl.c (build_function_decl): Use it.
2012-04-14 Tobias Burnus <burnus@net-b.de>
PR fortran/52916
PR fortran/40973
* gfortran.dg/public_private_module_3.f90: New.
* gfortran.dg/public_private_module_4.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/public_private_module_3.f90
trunk/gcc/testsuite/gfortran.dg/public_private_module_4.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/interface.c
trunk/gcc/fortran/resolve.c
trunk/gcc/fortran/trans-decl.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
` (5 preceding siblings ...)
2012-04-15 5:55 ` burnus at gcc dot gnu.org
@ 2012-04-16 21:39 ` burnus at gcc dot gnu.org
2012-04-18 8:21 ` burnus at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-04-16 21:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-04-16 21:38:53 UTC ---
Author: burnus
Date: Mon Apr 16 21:38:49 2012
New Revision: 186506
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186506
Log:
2012-04-16 Tobias Burnus <burnus@net-b.de>
PR fortran/52916
* gfortran.dg/public_private_module_3.f90: Use dg-additional-sources
to include public_private_module_4.f90.
* gfortran.dg/public_private_module_4.f90: Skip this test on all
targets
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/public_private_module_3.f90
trunk/gcc/testsuite/gfortran.dg/public_private_module_4.f90
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/52916] [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build
2012-04-09 16:50 [Bug fortran/52916] New: [4.8 Regression] 481.wrf in SPEC CPU 2006 failed to build hjl.tools at gmail dot com
` (6 preceding siblings ...)
2012-04-16 21:39 ` burnus at gcc dot gnu.org
@ 2012-04-18 8:21 ` burnus at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-04-18 8:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52916
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-04-18 08:16:33 UTC ---
FIXED on the trunk.
Thanks for the report and the patience.
^ permalink raw reply [flat|nested] 9+ messages in thread