From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5518 invoked by alias); 11 Apr 2012 12:45:58 -0000 Received: (qmail 5505 invoked by uid 22791); 11 Apr 2012 12:45:56 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 12:45:43 +0000 From: "matz at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/52934] New: enhancement: cshift0 should be inlined Date: Wed, 11 Apr 2012 12:45:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: matz at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg00721.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52934 Bug #: 52934 Summary: enhancement: cshift0 should be inlined Classification: Unclassified Product: gcc Version: 4.8.0 Status: UNCONFIRMED Severity: minor Priority: P3 Component: fortran AssignedTo: unassigned@gcc.gnu.org ReportedBy: matz@gcc.gnu.org polyhedrons protein would improve quite a bit when the cshift0 intrinsic would be inlined. With the patch below on my machine the runtime for protein drops from 0m21.367s to 0m19.227s (i.e. by 10%). Inlining a generic cshift probably wouldn't bring the same improvement, but still. (a bit related is my patch to improve cshift0 at http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00533.html ) --- protein.f90.mm 2011-12-02 16:22:47.000000000 +0100 +++ protein.f90 2011-12-02 16:16:38.000000000 +0100 @@ -250,7 +250,20 @@ out3: do n1 = 1, polypeptide_len ! total_surface_energy = 0 true_total_surface_energy = 0.0_LONGreal - shifted_surface_sequence = cshift(surface_sequence(:,l),m-1) + if (m == 1) then + shifted_surface_sequence = surface_sequence(:,l) + else if (m == 2) then + shifted_surface_sequence(1:3) = surface_sequence(2:4,l) + shifted_surface_sequence(4) = surface_sequence(1,l) + else if (m == 3) then + shifted_surface_sequence(1:2) = surface_sequence(3:4,l) + shifted_surface_sequence(3:4) = surface_sequence(1:2,l) + else if (m == 4) then + shifted_surface_sequence(1) = surface_sequence(4,l) + shifted_surface_sequence(2:4) = surface_sequence(1:3,l) + else + shifted_surface_sequence = cshift(surface_sequence(:,l),m-1) + end if do k = 1, number_of_polypeptides surface_energy = 0 true_surface_energy = 0.0_LONGreal