public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wschmidt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/52976] [4.8 Regression] Revision 186384 breaks the polyhedron tests aermod.f90 and doduc.f90 at -O3 -ffast-math
Date: Fri, 13 Apr 2012 19:46:00 -0000	[thread overview]
Message-ID: <bug-52976-4-MiZYrpleq4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52976-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52976

--- Comment #3 from William J. Schmidt <wschmidt at gcc dot gnu.org> 2012-04-13 19:41:18 UTC ---
When changing from the original form of the patch to the form that recorded
repeated ops in the ops table, I missed the effect on undistribution where a
term contains a multiply of a repeated op.  Those terms should be excluded from
undistribution to return to the former behavior, and I'll work on fixing that
for the short term.  However, it would eventually be better to factor a P out
of the example in this case:

c1 + 2.*P*c2 + 3.*P**2*c3 ==>  c1 + P * (2.*c2 + 3.*P*c3)

In the original form of the patch, this was handled naturally because P**2 was
expanded into P*P and the existing logic was sufficient.  I just missed the
need to add some logic to undistribution.


  parent reply	other threads:[~2012-04-13 19:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 15:49 [Bug tree-optimization/52976] New: " dominiq at lps dot ens.fr
2012-04-13 18:12 ` [Bug tree-optimization/52976] " dominiq at lps dot ens.fr
2012-04-13 19:07 ` wschmidt at gcc dot gnu.org
2012-04-13 19:46 ` wschmidt at gcc dot gnu.org [this message]
2012-04-13 20:47 ` wschmidt at gcc dot gnu.org
2012-04-13 22:11 ` dominiq at lps dot ens.fr
2012-04-14 15:06 ` wschmidt at gcc dot gnu.org
2012-04-14 15:14 ` wschmidt at gcc dot gnu.org
2012-04-14 16:54 ` wschmidt at gcc dot gnu.org
2012-04-15 10:42 ` dominiq at lps dot ens.fr
2012-04-16  9:47 ` rguenth at gcc dot gnu.org
2012-04-16 12:16 ` wschmidt at gcc dot gnu.org
2012-04-16 12:18 ` wschmidt at gcc dot gnu.org
2012-04-16 13:24 ` rguenth at gcc dot gnu.org
2012-04-16 13:54 ` vincenzo.innocente at cern dot ch
2012-04-16 13:58 ` rguenther at suse dot de
2012-04-18 10:46 ` rguenth at gcc dot gnu.org
2012-04-18 12:31 ` wschmidt at gcc dot gnu.org
2012-04-18 12:49 ` wschmidt at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-52976-4-MiZYrpleq4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).