public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/52991] attribute packed broken on mingw32?
Date: Tue, 18 Dec 2012 17:15:00 -0000 [thread overview]
Message-ID: <bug-52991-4-sgBI2BqW76@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-52991-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52991
Richard Henderson <rth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rth at gcc dot gnu.org
--- Comment #9 from Richard Henderson <rth at gcc dot gnu.org> 2012-12-18 17:14:37 UTC ---
It doesn't look to me that the first two hunks of the patch are needed.
The last hunk doesn't look like it should be considering either TYPE_PACKED
of the parent structure, or TYPE_ALIGN of the field type, but rather
using DECL_ALIGN of the field. Which ought already have been assigned
by layout_decl via update_alignment_for_field.
The biggest problem to me appears to be the entire ms_bitfield_layout_p
block of code there, whose block comments talk about adjusting bitfields,
and yet is firing for structures that contain no bitfields at all. That
tells me that the logic higher in the block (or elsewere wrt bitfield_layout_p)
is in error.
next prev parent reply other threads:[~2012-12-18 17:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 4:21 [Bug c/52991] New: " sherpya at netfarm dot it
2012-08-18 3:37 ` [Bug c/52991] " daniel.c.klauer at web dot de
2012-08-18 4:01 ` daniel.c.klauer at web dot de
2012-08-18 10:13 ` mikpe at it dot uu.se
2012-08-19 20:56 ` mikpe at it dot uu.se
2012-08-22 8:35 ` mikpe at it dot uu.se
2012-10-06 23:02 ` daniel.c.klauer at web dot de
2012-10-06 23:08 ` paolo.carlini at oracle dot com
2012-12-10 15:14 ` ktietz at gcc dot gnu.org
2012-12-18 17:15 ` rth at gcc dot gnu.org [this message]
2012-12-18 21:36 ` ktietz at gcc dot gnu.org
2013-01-09 12:31 ` ktietz at gcc dot gnu.org
2013-01-09 13:34 ` ktietz at gcc dot gnu.org
2013-01-09 13:37 ` ktietz at gcc dot gnu.org
2013-10-05 14:26 ` mikpelinux at gmail dot com
2013-12-12 15:33 ` rogerdpack at gmail dot com
2013-12-12 15:48 ` ktietz at gcc dot gnu.org
2014-01-17 10:09 ` kugel at rockbox dot org
2014-02-16 10:03 ` jackie.rosen at hushmail dot com
2015-07-14 9:08 ` [Bug target/52991] " ossman at cendio dot se
2022-01-10 8:16 ` [Bug target/52991] [6/7/8 Regression] " pinskia at gcc dot gnu.org
2022-01-10 8:16 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-52991-4-sgBI2BqW76@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).