[Bug c/53001] -Wfloat-conversion should be available to warn about floating point errors

["manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #29 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
I guess this is fixed for GCC 4.9.
>From gcc-bugs-return-435187-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Nov 20 08:36:46 2013
Return-Path: <gcc-bugs-return-435187-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3650 invoked by alias); 20 Nov 2013 08:36:46 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3607 invoked by uid 48); 20 Nov 2013 08:36:41 -0000
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/59203] New: config/cris/cris.c:2491: possible typo ?
Date: Wed, 20 Nov 2013 08:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dcb314 at hotmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-59203-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg01964.txt.bz2
Content-length: 1014

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY203

            Bug ID: 59203
           Summary: config/cris/cris.c:2491: possible typo ?
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com

I just ran cppcheck over the trunk source code.

It said

[trunk/gcc/config/cris/cris.c:2491] -> [trunk/gcc/config/cris/cris.c:2491]:
(style) Same expression on both sides of '||'.

Source code is

    enum cris_pic_symbol_type t1 = cris_pic_symbol_type_of (XEXP (x, 0));
    enum cris_pic_symbol_type t2 = cris_pic_symbol_type_of (XEXP (x, 1));

    gcc_assert (t1 == cris_no_symbol || t2 == cris_no_symbol);

    if (t1 == cris_got_symbol || t1 == cris_got_symbol)
      return cris_got_symbol_needing_fixup;

Suggest code rework. It might be as simple as changing t1 to t2 after
the ||, but given the assert, I doubt it.