public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "kirill.yukhin at intel dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/53020] New: __atomic_fetch_or doesn't generate `1 insn` variant Date: Tue, 17 Apr 2012 16:21:00 -0000 [thread overview] Message-ID: <bug-53020-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53020 Bug #: 53020 Summary: __atomic_fetch_or doesn't generate `1 insn` variant Classification: Unclassified Product: gcc Version: 4.8.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: target AssignedTo: unassigned@gcc.gnu.org ReportedBy: kirill.yukhin@intel.com Hello, while working on Intel's TSX extensions, I've found strange (to me) thing. We have in config/i386/sync.md: (define_insn "atomic_<code><mode>" [(set (match_operand:SWI 0 "memory_operand" "+m") (unspec_volatile:SWI [(any_logic:SWI (match_dup 0) (match_operand:SWI 1 "nonmemory_operand" "<r><i>")) (match_operand:SI 2 "const_int_operand")] ;; model UNSPECV_LOCK)) ... any_logic covers (unconditionally) covers AND IOR and XOR ops. However, generated insn-opinit.c lacks IOR variant initalization: ... set_direct_optab_handler (atomic_and_optab, QImode, CODE_FOR_atomic_andqi); set_direct_optab_handler (atomic_xor_optab, QImode, CODE_FOR_atomic_xorqi); ... So, having such simple test: void foo (int *p, int v) { __atomic_fetch_or (p, 1, __ATOMIC_ACQUIRE | __ATOMIC_HLE_ACQUIRE); } `lock orl %edx, (%eax)` wont' be generated, since there is no corresponding occurence in IOR optab. Here is the code, that fails to find it: optabs.c:maybe_emit_op ... if (use_memmodel) { icode = direct_optab_handler (optab->mem_no_result, mode); ... The most strange thing to me is that it works fine with XOR and AND ops.
next reply other threads:[~2012-04-17 16:21 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-17 16:21 kirill.yukhin at intel dot com [this message] 2012-04-17 16:25 ` [Bug target/53020] " kirill.yukhin at intel dot com 2012-04-17 16:55 ` ubizjak at gmail dot com 2012-04-17 17:01 ` kirill.yukhin at intel dot com 2012-04-17 17:40 ` uros at gcc dot gnu.org 2012-04-17 17:41 ` uros at gcc dot gnu.org 2012-04-17 17:57 ` ubizjak at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-53020-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).