public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mikestump at comcast dot net" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/53028] add dg-pedantic Date: Tue, 24 Apr 2012 00:31:00 -0000 [thread overview] Message-ID: <bug-53028-4-k5E173XOhC@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-53028-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53028 --- Comment #9 from Mike Stump <mikestump at comcast dot net> 2012-04-24 00:31:35 UTC --- Since little proof was added to support the assertion that the additional testing is useful, I can remain skeptical about it, though, the CFE people certainly are free to require it, what they say goes. I like the idea of testing new code, just I think it could be over done. I'll give you an example, I think we all can agree on. Let's say we add a warning. The code goes in, and a single testcase: main() { i = code to produce warning; // warning } but, we don't also test: -pedantic-errors main() { i = code to produce warning; // warning } even though, it is reasonable. We could, but don't. Why don't we, because it isn't worth the testing time and the maintenance time. Testing it once, and assuming that no one will accidentally change the warning is reasonable. We also don't test that the warning goes away with -w. We don't test the warning turns into an error with -Werror. How many times has one of these tests caught someone modifying a pedantic into a warning? How many times has one of these tests caught someone modifying a pedantic into an error? How many times did someone modify a pedantic in one of the two ways because a testcase wasn't present? Feel free to use your best recollection for the above answers. I can't help but think the numbers are so low, as to not be worth the cost of the additional testcases.
next prev parent reply other threads:[~2012-04-24 0:31 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-18 9:19 [Bug testsuite/53028] New: " manu at gcc dot gnu.org 2012-04-18 9:23 ` [Bug testsuite/53028] " manu at gcc dot gnu.org 2012-04-18 17:37 ` mikestump at comcast dot net 2012-04-18 18:28 ` manu at gcc dot gnu.org 2012-04-18 20:04 ` mikestump at comcast dot net 2012-04-18 21:48 ` manu at gcc dot gnu.org 2012-04-18 22:47 ` mikestump at comcast dot net 2012-04-19 7:06 ` manu at gcc dot gnu.org 2012-04-23 21:38 ` joseph at codesourcery dot com 2012-04-24 0:31 ` mikestump at comcast dot net [this message] 2012-04-28 0:03 ` manu at gcc dot gnu.org 2012-04-30 1:08 ` mikestump at comcast dot net 2024-08-03 17:43 ` egallager at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-53028-4-k5E173XOhC@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).