From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8695 invoked by alias); 19 Apr 2012 16:06:05 -0000 Received: (qmail 8684 invoked by uid 22791); 19 Apr 2012 16:06:03 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Apr 2012 16:05:16 +0000 From: "hubicka at ucw dot cz" To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/53042] [4.8 Regression] AIX bootstrap: cgraph symbol table error Date: Thu, 19 Apr 2012 16:06:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: bootstrap X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at ucw dot cz X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.8.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg01660.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53042 --- Comment #3 from Jan Hubicka 2012-04-19 16:03:09 UTC --- Thanks for working on this. The patch is pre-approved if it passes testing. The new symtab verifier is just old cgraph verifier and only change is that we now do same testing for variables, too. I do not see why COMDAT_GROUP gets right on functions and not on variables. It seems like latent issue here: Index: decl2.c =================================================================== --- decl2.c (revision 186576) +++ decl2.c (working copy) @@ -1894,7 +1894,7 @@ maybe_emit_vtables (tree ctype) actually marking the variable as written. */ if (flag_syntax_only) TREE_ASM_WRITTEN (vtbl) = 1; - else if (DECL_COMDAT (vtbl)) + else if (DECL_ONE_ONLY (vtbl)) { current = varpool_node (vtbl); if (last) At least the corresponding callgraph code is using this test. David, does this passes the original testing? Honza