From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13119 invoked by alias); 21 Apr 2012 16:42:37 -0000 Received: (qmail 13105 invoked by uid 22791); 21 Apr 2012 16:42:35 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Apr 2012 16:41:49 +0000 From: "manu at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/53066] Wshadow should not warn for shadowing an extern function Date: Sat, 21 Apr 2012 16:42:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Keywords: diagnostic, patch X-Bugzilla-Severity: enhancement X-Bugzilla-Who: manu at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Keywords Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg01789.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D53066 Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez 2012-04-21 16:41:42 UTC --- Testing this patch: --- gcc/c-decl.c (revision 186353) +++ gcc/c-decl.c (working copy) @@ -2570,12 +2570,19 @@ warn_if_shadowing (tree new_decl) } else if (TREE_CODE (old_decl) =3D=3D PARM_DECL) warning (OPT_Wshadow, "declaration of %q+D shadows a parameter", new_decl); else if (DECL_FILE_SCOPE_P (old_decl)) - warning (OPT_Wshadow, "declaration of %q+D shadows a global " - "declaration", new_decl); + { + /* Do not warn for variables shadowing a function + declaration. */ + if (TREE_CODE (old_decl) =3D=3D FUNCTION_DECL) + break; + warning_at (DECL_SOURCE_LOCATION (new_decl), OPT_Wshadow,=20 + "declaration of %qD shadows a global declaration", + new_decl); + } else if (TREE_CODE (old_decl) =3D=3D FUNCTION_DECL && DECL_BUILT_IN (old_decl)) { warning (OPT_Wshadow, "declaration of %q+D shadows " "a built-in function", new_decl);