[Bug c++/53067] New: c++0x GCC 4.7.0 Regression std::ref with unordered sets

[Bug c++/53067] New: c++0x GCC 4.7.0 Regression std::ref with unordered sets

[cmaloney at tagged dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

             Bug #: 53067
           Summary: c++0x GCC 4.7.0 Regression std::ref with unordered
                    sets
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: cmaloney@tagged.com


Building the following code with gcc4.7 snapshot 20120421 fails, but passed
with gcc4.6.

$g++ -std=c++11

#include <functional>
#include <unordered_set>

int main(int, char**){
  std::unordered_map<int> Foo;
  ref(Foo);
}

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-04-22 08:08:05 UTC ---
Already fixed for 4.7.1.

*** This bug has been marked as a duplicate of bug 52942 ***

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2012-04-22
         Resolution|DUPLICATE                   |
     Ever Confirmed|0                           |1

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-04-22 13:36:19 UTC ---
It's not a dup, although it doesn't help that the testcase is bogus (should use
unordered_set not unordered_map)

#include <functional>
#include <unordered_set>

int main(int, char**){
  std::unordered_set<int> Foo;
  ref(Foo);
}

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-04-22 16:10:38 UTC ---
I'm right now rebuilding both mainline and branch, because yesterday both
worked and I don't think we changed anything in this area. What the heck it is?

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-04-22 16:57:19 UTC ---
Ok, for 4_7-branch just stop this insanity and make all the implementation
details public. In mainline - barring other changes - we'll be anyway able to
do better thanks to access control part of SFINAE.

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

--- Comment #5 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2012-04-22 17:38:07 UTC ---
Author: paolo
Date: Sun Apr 22 17:37:57 2012
New Revision: 186676

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186676
Log:
2012-04-22  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/53067
    * include/bits/hashtable_policy.h: Change inheritances to public.
    * testsuite/23_containers/unordered_map/requirements/53067.cc: New.
    * testsuite/23_containers/unordered_set/requirements/53067.cc: Likewise.

Added:
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_map/requirements/53067.cc
   
trunk/libstdc++-v3/testsuite/23_containers/unordered_set/requirements/53067.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/hashtable_policy.h

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

--- Comment #6 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2012-04-22 17:38:18 UTC ---
Author: paolo
Date: Sun Apr 22 17:38:11 2012
New Revision: 186677

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186677
Log:
2012-04-22  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/53067
    * include/bits/hashtable_policy.h: Change inheritances to public.
    * testsuite/23_containers/unordered_map/requirements/53067.cc: New.
    * testsuite/23_containers/unordered_set/requirements/53067.cc: Likewise.

Added:
   
branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/unordered_map/requirements/53067.cc
   
branches/gcc-4_7-branch/libstdc++-v3/testsuite/23_containers/unordered_set/requirements/53067.cc
Modified:
    branches/gcc-4_7-branch/libstdc++-v3/ChangeLog
    branches/gcc-4_7-branch/libstdc++-v3/include/bits/hashtable_policy.h

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.1

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-04-22 17:40:06 UTC ---
Fixed mainline and 4.7.1.

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fdumont at gcc dot gnu.org

--- Comment #8 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-09-25 17:05:49 UTC ---
Hi Francois, any chance you can look into this?

As you can see, at some point we hoped to have a more serious fix in mainline
thanks to access control under SFINAE, but actually we (I) were wrong, it
doesn't help. Thus we are stuck with public inheritance for all the
implementation detail base classes (see the comments in hashtable_policy.h), a
pretty ugly situation. It must be possible to redesign things a bit and avoid
that. What do you think?

[Bug c++/53067] c++0x GCC 4.7.0 Regression std::ref with unordered sets

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53067

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2012-10-11 22:21:50 UTC ---
Turns out I was wrong in my last message! Francois made me notice that in fact
in my experiments I was reverting the quick hack in an incorrect way. I have
now properly done the reversion:

  http://gcc.gnu.org/ml/gcc-cvs/2012-10/msg00502.html

and things work great in mainline.