public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/53093] [4.8 Regression]: tls/alias-1.c ICE, emutls
Date: Wed, 25 Apr 2012 17:06:00 -0000	[thread overview]
Message-ID: <bug-53093-4-zgEm8CTShV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53093-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53093

--- Comment #2 from Jan Hubicka <hubicka at ucw dot cz> 2012-04-25 17:06:41 UTC ---
Hi,
the problem seems to be quite easy.  We have variable and alias.
The code first counts number of variables and allocated vectors, then it
inserts
aliases, too, and the length of vector is not enough anymore.

Can you, please, test the following patch?  I will try to work out why this
did not ICE before.

Honza

Index: tree-emutls.c
===================================================================
--- tree-emutls.c       (revision 186831)
+++ tree-emutls.c       (working copy)
@@ -706,7 +706,7 @@ create_emultls_var (struct varpool_node 
   cdecl = new_emutls_decl (var->symbol.decl, var->alias_of);

   cvar = varpool_get_node (cdecl);
-  VEC_quick_push (varpool_node_ptr, control_vars, cvar);
+  VEC_safe_push (varpool_node_ptr, heap, control_vars, cvar);

   if (!var->alias)
     {


  parent reply	other threads:[~2012-04-25 17:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 19:42 [Bug middle-end/53093] New: " hp at gcc dot gnu.org
2012-04-24  3:54 ` [Bug middle-end/53093] " pinskia at gcc dot gnu.org
2012-04-24 13:09 ` hubicka at gcc dot gnu.org
2012-04-25 17:06 ` hubicka at ucw dot cz [this message]
2012-04-26 14:21 ` hp at gcc dot gnu.org
2012-04-26 21:14 ` hubicka at gcc dot gnu.org
2012-04-26 23:43 ` hp at gcc dot gnu.org
2012-04-27 12:03 ` hubicka at gcc dot gnu.org
2012-04-27 13:16 ` hp at gcc dot gnu.org
2012-05-02 14:35 ` hubicka at ucw dot cz
2012-05-03 19:22 ` hubicka at gcc dot gnu.org
2012-05-31 10:37 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53093-4-zgEm8CTShV@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).