[Bug target/53120] New: [4.5, 4.6, 4.7, 4.8 Regression]: ICE building driver, exposing strict_low_part / in/out operand thinko -fno-tree-sra

[Bug target/53120] New: [4.5, 4.6, 4.7, 4.8 Regression]: ICE building driver, exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

             Bug #: 53120
           Summary: [4.5, 4.6, 4.7, 4.8 Regression]: ICE building driver,
                    exposing strict_low_part / in/out operand thinko
                    -fno-tree-sra
    Classification: Unclassified
           Product: gcc
           Version: 4.5.5
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hp@gcc.gnu.org
            Target: cris-*-*, crisv32-*-*


Created attachment 27240
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27240
./cc1 -O2 -fno-tree-sra

The attached test-case, intended for gcc.dg/torture, exposes a thinko in the
CRIS port: a read/write output operand (the "+" constraint modifier) is
specified to match an input operand ("0").  Reload cannot cope, and thinking
about it, it's not possible (with the current hooks and macros).  According to
a comment in m68k.md, this is to be expected, supported by a gdb session.  The
m68k comment (grep MATCH_DUP m68k.md) is from revision 372 (!) which according
to the (artificially mapped) svn revision numbers are about 10 revisions from
the introduction of reload.c (!!).  Patch in testing. The observation was from
an import of the 4.7 branch; also confirmed on branches for 4.5, 4.6, 4.7 and
trunk, but not for 4.3.  The use of "+" was introduced with revision r134236
(2008-04-13 02:51:51 UTC), before the 4.4 branch. The bug is of course there
but just not trigging for 4.4 but nevertheless observed as a regression of 4.5,
therefore labelled as such.  Note the requirement to turn off tree-sra.

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|                            |2012-04-25
         AssignedTo|unassigned at gcc dot       |hp at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1
            Summary|[4.5, 4.6, 4.7, 4.8         |[4.5, 4.6, 4.7, 4.8
                   |Regression]: ICE building   |Regression]: ICE exposing
                   |driver, exposing            |strict_low_part / in/out
                   |strict_low_part / in/out    |operand thinko
                   |operand thinko              |-fno-tree-sra
                   |-fno-tree-sra               |

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 17:07:25 UTC ---
No intention to backport further than 4.7.

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 21:38:14 UTC ---
Forgot to quote the ICE message (here from 4.7 r186809):
/tmp/ph2.i: In function 'f':
/tmp/ph2.i:109:1: internal compiler error: in find_reloads, at reload.c:4069

>From testing on the 4.7 branch (passed) and closer inspection of log files on
trunk, it seems this bug is also the reason for
gcc.c-torture/execute/vector-compare-1.c never passing since its introduction
(thus not blipping on my radar), a test-case that doesn't require
-fno-tree-sra.

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 22:31:40 UTC ---
Author: hp
Date: Wed Apr 25 22:31:36 2012
New Revision: 186843

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186843
Log:
    PR target/53120
    * config/cris/cris.md ("*andhi_lowpart_v32")
    ("*andqi_lowpart_v32"): Change first input-only operand from
    a (match_operand ...) to (match_dup 0).  Drop alternatives with
    const_int-matching constraints for redundancy.
    ("*andhi_lowpart_non_v32", "*andqi_lowpart_non_v32"): Ditto.  Drop
    three-operand alternative.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/cris/cris.md

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

--- Comment #4 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 22:33:33 UTC ---
Author: hp
Date: Wed Apr 25 22:33:30 2012
New Revision: 186844

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186844
Log:
    PR target/53120
    * gcc.dg/torture/pr53120.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr53120.c
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

--- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 23:23:37 UTC ---
Author: hp
Date: Wed Apr 25 23:23:34 2012
New Revision: 186848

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186848
Log:
    PR target/53120
    * config/cris/cris.md ("*andhi_lowpart_v32")
    ("*andqi_lowpart_v32"): Change first input-only operand from
    a (match_operand ...) to (match_dup 0).  Drop alternatives with
    const_int-matching constraints for redundancy.
    ("*andhi_lowpart_non_v32", "*andqi_lowpart_non_v32"): Ditto.  Drop
    three-operand alternative.

Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/config/cris/cris.md

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

--- Comment #6 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 23:24:53 UTC ---
Author: hp
Date: Wed Apr 25 23:24:48 2012
New Revision: 186849

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=186849
Log:
    PR target/53120
    * gcc.dg/torture/pr53120.c: New test.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr53120.c
Modified:
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.2

--- Comment #7 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2012-04-25 23:26:21 UTC ---
Fixed 4.7 and trunk, no further backport planned.

[Bug target/53120] [4.5, 4.6, 4.7, 4.8 Regression]: ICE exposing strict_low_part / in/out operand thinko -fno-tree-sra

[nickc at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53120

--- Comment #8 from Nick Clifton <nickc at gcc dot gnu.org> 2012-05-10 13:40:27 UTC ---
Author: nickc
Date: Thu May 10 13:40:20 2012
New Revision: 187368

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=187368
Log:
    PR target/53120
    * config/m32c/bitops.md (bset_qi): Change operand 2 from having
    a "0" constraint to being a (match_dup 0).

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/m32c/bitops.md