From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31456 invoked by alias); 28 Apr 2012 12:05:39 -0000 Received: (qmail 31446 invoked by uid 22791); 28 Apr 2012 12:05:38 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Apr 2012 12:05:25 +0000 From: "marc.glisse at normalesup dot org" To: gcc-bugs@gcc.gnu.org Subject: [Bug c/53131] -Wlogical-op: ready for prime time in -Wall ? Date: Sat, 28 Apr 2012 12:05:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: c X-Bugzilla-Keywords: diagnostic X-Bugzilla-Severity: minor X-Bugzilla-Who: marc.glisse at normalesup dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: CC Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg02500.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53131 Marc Glisse changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marc.glisse at normalesup | |dot org --- Comment #4 from Marc Glisse 2012-04-28 12:05:20 UTC --- (In reply to comment #2) > > Do the warnings indicate bugs or not? > Yes. I checked the first ten. Could you give a sample? -Wlogical-op merges 2 unrelated warnings: *) x && 2 (you would expect a boolean, not 2, so maybe x&2 was meant) *) x<0 && x>0 (not so likely to happen) or x>=-5 || x<2 (always true) and it is not clear which one you are most interested in.