[Bug debug/53145] New: [4.8 Regression] gcc.dg/pch/save-temps-1.c

[Bug debug/53145] New: [4.8 Regression] gcc.dg/pch/save-temps-1.c

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

             Bug #: 53145
           Summary: [4.8 Regression] gcc.dg/pch/save-temps-1.c
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: jakub@redhat.com


On Linux/x86-64, revision 186835:

http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00787.html

caused:

FAIL: gcc.dg/pch/save-temps-1.c  -O0 -g assembly comparison
FAIL: gcc.dg/pch/save-temps-1.c   -O3 -g  assembly comparison

with --target_board='unix{-m32}'. I got

ine #161 
< .LASF3:
> .LASF0:
line #162
<       .string
"/export/gnu/import/git/gcc-regression/master/186835/bld/gcc/testsuite/gcc" 
>       .string "unsigned int"
line #163   
< .LASF0:
> .LASF3:
line #164
<       .string "unsigned int"
>       .string "/export/gnu/import/git/gcc-regression/master/186835/bld/gcc/testsuite/gcc" 
FAIL: gcc.dg/pch/save-temps-1.c   -O3 -g  assembly comparison

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-29 16:23:05 UTC ---
This fixes the regression.  But I don't see why it should make
a difference.

diff --git a/gcc/common.opt b/gcc/common.opt
index 14c88bf..cd760fc 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2237,7 +2237,7 @@ Common JoinedOrMissing
 Generate debug information in default extended format

 gno-record-gcc-switches
-Common RejectNegative Var(dwarf_record_gcc_switches,0) Init(1)
+Common RejectNegative Var(dwarf_record_gcc_switches,0) Init(0)
 Don't record gcc command line switches in DWARF DW_AT_producer.

 grecord-gcc-switches

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2012-04-29 16:29:27 UTC ---
/* Return a heap allocated producer string including command line options
   if -grecord-gcc-switches.  */

static char *
gen_producer_string (void)
{
  size_t j;
  VEC(dchar_p, heap) *switches = NULL;
  const char *language_string = lang_hooks.name;
  char *producer, *tail;
  const char *p;
  size_t len = dwarf_record_gcc_switches ? 0 : 3;
  size_t plen = strlen (language_string) + 1 + strlen (version_string);

  for (j = 1; dwarf_record_gcc_switches && j < save_decoded_options_count; j++)

Will heap allocation affect PCH?  Should we add -gno-record-gcc-switches
to gcc.dg/pch/save-temps-1.c?

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-10-20
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-10-20 10:39:07 UTC ---
I see it on SPARC/Linux and MIPS/Linux as well.

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-11-07 18:10:05 UTC ---
Created attachment 28630
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28630
gcc48-pr53145.patch

I can't reproduce this (and with the default -feliminate-unused-debug-types I
don't even see how this is actually possible, because prune_unused_types
empties and repopulates debug_str_hash hash table), but at least for
-fno-eliminate-unused-debug-types the attached patch ought to fix it.

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-11-08 20:20:33 UTC ---
Author: jakub
Date: Thu Nov  8 20:20:10 2012
New Revision: 193340

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193340
Log:
    PR debug/53145
    * dwarf2out.c (gen_compile_unit_die): Don't call gen_producer_string
    here, instead add "" if producer_string is NULL.
    (dwarf2out_finish): Call gen_producer_string here, unconditionally
    decrease refcount of the old indirect string and set val_str to
    find_AT_string result.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.c

[Bug debug/53145] [4.8 Regression] gcc.dg/pch/save-temps-1.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53145

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-15 00:28:06 UTC ---
Fixed.