public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/53168] ICE in find_or_generate_expression, at tree-ssa-pre.c:3053 Date: Wed, 02 May 2012 15:02:00 -0000 [thread overview] Message-ID: <bug-53168-4-N7dmlG9OlD@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-53168-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53168 Richard Guenther <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steven at gcc dot gnu.org --- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-05-02 15:00:54 UTC --- It's what I always wondered about ... we phi-translate again during do_regular_insertion but we fail to "clean" the result in any way. So we end with a translation result that is "invalid", thus one without a leader and one which we cannot re-create. That is, valid_in_sets returns false for it. Index: gcc/tree-ssa-pre.c =================================================================== --- gcc/tree-ssa-pre.c (revision 187042) +++ gcc/tree-ssa-pre.c (working copy) @@ -3617,6 +3619,11 @@ do_regular_insertion (basic_block block, vprime, NULL); if (edoubleprime == NULL) { + if (!valid_in_sets (AVAIL_OUT (bprime), NULL, eprime, bprime)) + { + cant_insert = true; + break; + } avail[bprime->index] = eprime; all_same = false; } Steven - do you by chance remember why "re-translating" during insertion is ok? Or is a phi-translation result that cannot be inserted in its form at the end of the BB bogus (always? or only during insertion?).
next prev parent reply other threads:[~2012-05-02 15:02 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-04-30 13:43 [Bug c/53168] New: " regehr at cs dot utah.edu 2012-04-30 15:18 ` [Bug tree-optimization/53168] " jakub at gcc dot gnu.org 2012-05-02 10:31 ` rguenth at gcc dot gnu.org 2012-05-02 15:02 ` rguenth at gcc dot gnu.org [this message] 2012-05-03 8:32 ` steven at gcc dot gnu.org 2012-05-03 14:18 ` rguenth at gcc dot gnu.org 2012-05-04 11:31 ` rguenth at gcc dot gnu.org 2012-05-04 11:36 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-53168-4-N7dmlG9OlD@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).