[Bug target/53194] New: [4.8 Regression] Many x86 failures

[Bug target/53194] New: [4.8 Regression] Many x86 failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

             Bug #: 53194
           Summary: [4.8 Regression] Many x86 failures
    Classification: Unclassified
           Product: gcc
           Version: 4.7.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: kirill.yukhin@intel.com


On Linux/ia32, revision 187051:

http://gcc.gnu.org/ml/gcc-cvs/2012-05/msg00047.html

caused:

FAIL: gcc.target/i386/funcspec-9.c (test for excess errors)
FAIL: gcc.target/i386/pr44948-2a.c (test for excess errors)
FAIL: gcc.target/i386/sse-22.c (test for excess errors)
FAIL: gcc.target/i386/sse-22a.c (test for excess errors)
FAIL: gcc.target/i386/sse-23.c (test for excess errors)
FAIL: gcc.target/i386/sse-24.c (test for excess errors)

[Bug target/53194] [4.8 Regression] Many x86 failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-05-02 17:55:50 UTC ---
The same failures happens on both ia32 and x86-64.

[Bug target/53194] [4.8 Regression] Many x86 failures

[kirill.yukhin at intel dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

--- Comment #2 from Yukhin Kirill <kirill.yukhin at intel dot com> 2012-05-02 19:20:59 UTC ---
The problem is here:
+
+  sprintf (hle_macro, "__ATOMIC_HLE_ACQUIRE=%d", IX86_HLE_ACQUIRE);
+  def_or_undef (parse_in, hle_macro);
+
+  sprintf (hle_macro, "__ATOMIC_HLE_RELEASE=%d", IX86_HLE_RELEASE);
+  def_or_undef (parse_in, hle_macro);

Seems, when def_or_undef acts as `undef` we've got a problem:
$ /export/users/kyukhin/ws/build/build-x86_64-linux/gcc/xgcc
-B/export/users/kyukhin/ws/build/build-x86_64-linux/gcc/ /export/users/ky
o-diagnostics-show-caret  -S -o sse-22.s
/export/users/kyukhin/ws/git/gcc/testsuite/gcc.target/i386/sse-22.c:54:21:
warning: extra tokens at end of #undef directive [enabled b
/export/users/kyukhin/ws/git/gcc/testsuite/gcc.target/i386/sse-22.c:54:21:
warning: extra tokens at end of #undef directive [enabled b

[Bug target/53194] [4.8 Regression] Many x86 failures

[kirill.yukhin at intel dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

--- Comment #3 from Yukhin Kirill <kirill.yukhin at intel dot com> 2012-05-03 07:01:37 UTC ---
Created attachment 27299
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27299
Proposed solution

[Bug target/53194] [4.8 Regression] Many x86 failures

[kirill.yukhin at intel dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

--- Comment #4 from Yukhin Kirill <kirill.yukhin at intel dot com> 2012-05-03 07:02:50 UTC ---
(In reply to comment #3)
> Created attachment 27299 [details]
> Proposed solution

Attached patch cures failing tests

[Bug target/53194] [4.8 Regression] Many x86 failures

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-05-03
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-05-03 07:07:23 UTC ---
Created attachment 27300
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27300
gcc48-pr53194.patch

Alternate patch, see http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00730.html

[Bug target/53194] [4.8 Regression] Many x86 failures

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-05-03 10:12:39 UTC ---
Author: jakub
Date: Thu May  3 10:12:33 2012
New Revision: 187084

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=187084
Log:
    PR target/53194
    * config/i386/i386-c.c (ix86_target_macros_internal): Don't
    define __ATOMIC_HLE_* macros here.
    (ix86_target_macros): But here, using cpp_define_formatted.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386-c.c

[Bug target/53194] [4.8 Regression] Many x86 failures

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-05-03 10:29:55 UTC ---
Fixed.

[Bug target/53194] [4.8 Regression] Many x86 failures

[eraman at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53194

--- Comment #8 from eraman at gcc dot gnu.org 2012-08-14 00:51:15 UTC ---
Author: eraman
Date: Tue Aug 14 00:51:10 2012
New Revision: 190375

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=190375
Log:
2012-08-13   Easwaran Raman  <eraman@google.com>
    Backport the following patches from trunk to add support for Intel
    Transactional Memory Instructions support (Google ref b/6496405):
    r185218, r185223, r187051, r187084.

    r185218,r185223:
    2012-02-12  Kirill Yukhin  <kirill.yukhin@intel.com>
        * doc/invoke.texi: Document -mrtm option.
        * common/config/i386/i386-common.c (OPTION_MASK_ISA_RTM_SET):
        New.
        (OPTION_MASK_ISA_RTM_UNSET): Ditto.
        (ix86_handle_option): Handle OPT_mrtm.
        * config.gcc (i[34567]86-*-*): Add rtmintrin.h and
        xtestintrin.h.
        (x86_64-*-*): Ditto.
        * i386-builtin-types.def (INT_FTYPE_VOID): New.
        * config/i386/i386-c.c (ix86_target_macros_internal): Define
        __RTM__ if needed.
        (ix86_target_string): Define -mrtm option.
        (PTA_RTM): New.
        (ix86_option_override_internal): Extend "corei7-avx" with
        RTM option. Handle new option.
        (ix86_valid_target_attribute_inner_p): Add OPT_mrtm.
        (ix86_builtins): Add IX86_BUILTIN_XBEGIN, IX86_BUILTIN_XEND,
        IX86_BUILTIN_XTEST.
        (bdesc_special_args): Ditto.
        (ix86_init_mmx_sse_builtins): Add IX86_BUILTIN_XABORT.
        (ix86_expand_special_args_builtin): Handle new built-in type.
        (ix86_expand_builtin): Handle XABORT instruction.
        * config/i386/i386.h (TARGET_RTM): New.
        * config/i386/i386.md (UNSPECV_XBEGIN): New.
        (UNSPECV_XEND): Ditto.
        (UNSPECV_XABORT): Ditto.
        (UNSPECV_XTEST): Ditto.
        (xbegin): Ditto.
        (xbegin_1): Ditto.
        (xend): Ditto.
        (xabort): Ditto
        (xtest): Ditto.
        (xtest_1): Ditto.
        * config/i386/i386.opt (mrtm): New.
        * config/i386/immintrin.h: Include rtmintrin.h and
        xtestintrin.h.
        * config/i386/rtmintrin.h: New header.
        * config/i386/xtestintrin.h: Ditto.

    r187051:
    2012-05-02  Kirill Yukhin  <kirill.yukhin@intel.com>
            Andi Kleen <ak@linux.intel.com>

        * coretypes (MEMMODEL_MASK): New.
        * builtins.c (get_memmodel): Add val. Call target.memmodel_check
        and return new variable.
        (expand_builtin_atomic_exchange):  Mask memmodel values.
        (expand_builtin_atomic_compare_exchange): Ditto.
        (expand_builtin_atomic_load): Ditto.
        (expand_builtin_atomic_store): Ditto.
        (expand_builtin_atomic_clear): Ditto.
        * doc/extend.texi: Mention port-dependent memory model flags.
        * config/i386/cpuid.h (bit_HLE): New.
        * config/i386/driver-i386.c (host_detect_local_cpu): Detect
        HLE support.
        * config/i386/i386-protos.h (ix86_generate_hle_prefix): New.
        * config/i386/i386-c.c (ix86_target_macros_internal): Set
        HLE defines.
        (ix86_target_string)<-mhle>: New.
        (ix86_valid_target_attribute_inner_p)<OPT_mhle>: Ditto.
        * config/i386/i386.c (ix86_target_string)<OPTION_MASK_ISA_HLE>:
        New.
        (ix86_valid_target_attribute_inner_p)<OPT_mhle>: Ditto.
        (ix86_option_override_internal)<PTA_HLE>: New switch, set it
        enabled for generic, generic64 and core-avx2.
        (ix86_print_operand): Generate HLE lock prefixes.
        (ix86_memmodel_check): New.
        (TARGET_MEMMODEL_CHECK): Ditto.
        * config/i386/i386.h (OPTION_ISA_HLE): Ditto.
        (IX86_HLE_ACQUIRE): Ditto.
        (IX86_HLE_RELEASE): Ditto.
        * config/i386/i386.h (ix86_generate_hle_prefix): Ditto.
        * config/i386/i386.opt (mhle): Ditto.
        * config/i386/sync.md(atomic_compare_and_swap<mode>): Pass
        success model to instruction emitter.
        (atomic_fetch_add<mode>): Ditto.
        (atomic_exchange<mode>): Ditto.
        (atomic_add<mode>): Ditto.
        (atomic_sub<mode>): Ditto.
        (atomic_<code><mode>): Ditto.
        (*atomic_compare_and_swap_doubledi_pic): Ditto.
        (atomic_compare_and_swap_single<mode>): Define and use argument
        for success model.
        (atomic_compare_and_swap_double<mode>): Ditto.
        * configure.ac: Check if assembler support HLE prefixes.
        * configure: Regenerate.
        * config.in: Ditto.

    r187084:
    2012-05-03  Jakub Jelinek  <jakub@redhat.com>
        PR target/53194
        * config/i386/i386-c.c (ix86_target_macros_internal): Don't
        define __ATOMIC_HLE_* macros here.
        (ix86_target_macros): But here, using cpp_define_formatted.

testsuite/ChangeLog.google-4_7:

2012-08-13   Easwaran Raman  <eraman@google.com>
    Backport the following patches from trunk to add support for Intel
    Transactional Memory Instructions support (Google ref b/6496405):
    r185218, r185223, r187051, r187089, r187094.

    r85218,r185223:
    2012-03-12  Kirill Yukhin  <kirill.yukhin@intel.com>
        * gcc.target/i386/rtm-xabort-1.c: New.
        * gcc.target/i386/rtm-xbegin-1.c: Ditto.
        * gcc.target/i386/rtm-xend-1.c: Ditto.
        * gcc.target/i386/rtm-xtest-1.c: Ditto.
        * gcc.target/i386/sse-12.c: Test RTM intrinsics.
        * gcc.target/i386/sse-13.c: Ditto.
        * gcc.target/i386/sse-14.c: Ditto.
        * gcc.target/i386/sse-22.c: Ditto.
        * gcc.target/i386/sse-23.c: Ditto.
        * g++.dg/other/i386-2.C: Ditto.
        * g++.dg/other/i386-3.C: Ditto.

    r187051:
    2012-05-02  Kirill Yukhin  <kirill.yukhin@intel.com>
        * gcc.target/i386/hle-cmpxchg-acq-1.c: New.
        * gcc.target/i386/hle-cmpxchg-rel-1.c: Ditto.
        * gcc.target/i386/hle-add-acq-1.c: Ditto.
        * gcc.target/i386/hle-add-rel-1.c: Ditto.
        * gcc.target/i386/hle-and-acq-1.c: Ditto.
        * gcc.target/i386/hle-and-rel-1.c: Ditto.
        * gcc.target/i386/hle-or-acq-1.c: Ditto.
        * gcc.target/i386/hle-or-rel-1.c: Ditto.
        * gcc.target/i386/hle-sub-acq-1.c: Ditto.
        * gcc.target/i386/hle-sub-rel-1.c: Ditto.
        * gcc.target/i386/hle-xadd-acq-1.c: Ditto.
        * gcc.target/i386/hle-xadd-rel-1.c: Ditto.
        * gcc.target/i386/hle-xchg-acq-1.c: Ditto.
        * gcc.target/i386/hle-xchg-rel-1.c: Ditto.
        * gcc.target/i386/hle-xor-acq-1.c: Ditto.
        * gcc.target/i386/hle-xor-rel-1.c: Ditto.

    r187089:
    2012-05-03  Jakub Jelinek  <jakub@redhat.com>
        * gcc.target/i386/hle-xadd-rel-1.c: Match .byte 0xf3 instead of
        .byte 0xf2.
        * gcc.target/i386/hle-sub-rel-1.c: Likewise.
        * gcc.target/i386/hle-xchg-rel-1.c: Likewise.
        * gcc.target/i386/hle-add-rel-1.c: Likewise.

    r187094:
    2012-05-03  Uros Bizjak  <ubizjak@gmail.com>
        * gcc.target/i386/hle-cmpxchg-acq-1.c (dg-options): Add -march=x86-64.
        * gcc.target/i386/hle-xadd-acq-1.c (dg-options): Ditto.
        * gcc.target/i386/hle-cmpxchg-rel-1.c (dg-options): Ditto.
        * gcc.target/i386/hle-xadd-rel-1.c (dg-options): Ditto.


Added:
    branches/google/gcc-4_7/gcc/config/i386/rtmintrin.h
      - copied unchanged from r185223, trunk/gcc/config/i386/rtmintrin.h
    branches/google/gcc-4_7/gcc/config/i386/xtestintrin.h
      - copied unchanged from r185223, trunk/gcc/config/i386/xtestintrin.h
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-add-acq-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-add-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-add-rel-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-add-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-and-acq-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-and-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-and-rel-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-and-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-cmpxchg-acq-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-cmpxchg-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-cmpxchg-rel-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-cmpxchg-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-or-acq-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-or-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-or-rel-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-or-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-sub-acq-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-sub-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-sub-rel-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-sub-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-xadd-acq-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-xadd-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-xadd-rel-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-xadd-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-xchg-acq-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-xchg-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-xchg-rel-1.c
      - copied, changed from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-xchg-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-xor-acq-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-xor-acq-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/hle-xor-rel-1.c
      - copied unchanged from r187051,
trunk/gcc/testsuite/gcc.target/i386/hle-xor-rel-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/rtm-xabort-1.c
      - copied unchanged from r185223,
trunk/gcc/testsuite/gcc.target/i386/rtm-xabort-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/rtm-xbegin-1.c
      - copied unchanged from r185223,
trunk/gcc/testsuite/gcc.target/i386/rtm-xbegin-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/rtm-xend-1.c
      - copied unchanged from r185223,
trunk/gcc/testsuite/gcc.target/i386/rtm-xend-1.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/rtm-xtest-1.c
      - copied unchanged from r185223,
trunk/gcc/testsuite/gcc.target/i386/rtm-xtest-1.c
Modified:
    branches/google/gcc-4_7/gcc/ChangeLog.google-4_7
    branches/google/gcc-4_7/gcc/builtins.c
    branches/google/gcc-4_7/gcc/common/config/i386/i386-common.c
    branches/google/gcc-4_7/gcc/config.gcc
    branches/google/gcc-4_7/gcc/config.in
    branches/google/gcc-4_7/gcc/config/i386/cpuid.h
    branches/google/gcc-4_7/gcc/config/i386/driver-i386.c
    branches/google/gcc-4_7/gcc/config/i386/i386-builtin-types.def
    branches/google/gcc-4_7/gcc/config/i386/i386-c.c
    branches/google/gcc-4_7/gcc/config/i386/i386.c
    branches/google/gcc-4_7/gcc/config/i386/i386.h
    branches/google/gcc-4_7/gcc/config/i386/i386.md
    branches/google/gcc-4_7/gcc/config/i386/i386.opt
    branches/google/gcc-4_7/gcc/config/i386/immintrin.h
    branches/google/gcc-4_7/gcc/config/i386/sync.md
    branches/google/gcc-4_7/gcc/configure
    branches/google/gcc-4_7/gcc/configure.ac
    branches/google/gcc-4_7/gcc/coretypes.h
    branches/google/gcc-4_7/gcc/doc/extend.texi
    branches/google/gcc-4_7/gcc/doc/invoke.texi
    branches/google/gcc-4_7/gcc/doc/tm.texi
    branches/google/gcc-4_7/gcc/doc/tm.texi.in
    branches/google/gcc-4_7/gcc/target.def
    branches/google/gcc-4_7/gcc/testsuite/ChangeLog.google-4_7
    branches/google/gcc-4_7/gcc/testsuite/g++.dg/other/i386-2.C
    branches/google/gcc-4_7/gcc/testsuite/g++.dg/other/i386-3.C
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/sse-12.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/sse-13.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/sse-14.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/sse-22.c
    branches/google/gcc-4_7/gcc/testsuite/gcc.target/i386/sse-23.c