[Bug c++/53224] New: synthesized_method_walk returns uninitialized values

[Bug c++/53224] New: synthesized_method_walk returns uninitialized values

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53224

             Bug #: 53224
           Summary: synthesized_method_walk returns uninitialized values
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


static void
synthesized_method_walk (tree ctype, special_function_kind sfk, bool const_p,
                         tree *spec_p, bool *trivial_p, bool *deleted_p,
                         bool *constexpr_p, bool diag)
{
  tree binfo, base_binfo, scope, fnname, rval, argtype;
  bool move_p, copy_arg_p, assign_p, expected_trivial, check_vdtor;
  VEC(tree,gc) *vbases;
  int i, quals, flags;
  tsubst_flags_t complain;
  const char *msg;
  bool ctor_p;

  if (spec_p)
    *spec_p = (cxx_dialect >= cxx0x ? noexcept_true_spec : empty_except_spec);

  if (deleted_p)
    {
      /* "The closure type associated with a lambda-expression has a deleted
         default constructor and a deleted copy assignment operator."
         This is diagnosed in maybe_explain_implicit_delete.  */
      if (LAMBDA_TYPE_P (ctype)
          && (sfk == sfk_constructor
              || sfk == sfk_copy_assignment))
        {  
          *deleted_p = true;
          return;  
        }    

      *deleted_p = false;
    }        

trivial_p and constexpr_p may not be initialized here.

[Bug c++/53224] synthesized_method_walk returns uninitialized values

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53224

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-05-04 02:41:12 UTC ---
I think you need more context than just the above code.
Is *trivial_p and *constexpr_p checked when *deleted_p is true?

[Bug c++/53224] synthesized_method_walk returns uninitialized values

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53224

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-05-04 02:43:22 UTC ---
  synthesized_method_walk (type, kind, const_p, &raises, &trivial_p,
                           &deleted_p, &constexpr_p, false);
  /* Don't bother marking a deleted constructor as constexpr.  */
  if (deleted_p)
    constexpr_p = false;
  /* A trivial copy/move constructor is also a constexpr constructor.  */
  else if (trivial_p && cxx_dialect >= cxx0x
           && (kind == sfk_copy_constructor
               || kind == sfk_move_constructor))
    gcc_assert (constexpr_p);


  if (!trivial_p && type_has_trivial_fn (type, kind))
    type_set_nontrivial_flag (type, kind);

So trivial_p could be used uninitialized only as it is obvious that constexpr_p
was set correctly.

[Bug c++/53224] synthesized_method_walk returns uninitialized values

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53224

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Dup, already fixed.

*** This bug has been marked as a duplicate of bug 55418 ***