public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/53265] Warn when undefined behavior implies smaller iteration count
Date: Tue, 30 Apr 2013 06:46:00 -0000	[thread overview]
Message-ID: <bug-53265-4-cVgr1fzsD3@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53265-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53265

--- Comment #29 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-30 06:45:54 UTC ---
If you want another testcase which doesn't warn and is optimized based on the
assumption that undefined behavior doesn't occur, then say:
http://blog.regehr.org/archives/918#comment-8646
contains:
int a[4];

__attribute__((noinline, noclone)) int
foo (int x)
{
  int i, r = 0, n = x & 31;
  for (i = 0; i < n; i++)
    r += a[i];
  return r;
}

int
main ()
{
  int x = 255;
  __asm volatile ("" : "+r" (x));
  return foo (x);
}

But in both the testcases warning is questionable, in your testcase, if p.r[0]
is non-zero and any of p.r[1] through p.r[8] is zero, then no undefined
behaviour is triggered and the program is valid, and gcc doesn't break it in
any way.
Similarly with the my testcase above and foo being called with x where the low
5 bits are 0 to 4, again, valid in that case (ignore main and the value 255
being hidden from the compiler there).
What would you like to warn about?  That if the loop is invoked with variables
and data that result in undefined behaviour that the behaviour will be
undefined?
The difference between where we know is there the compiler knows that whenever
you enter the loop construct, you will hit the undefined behavior (unless say
one of the called functions in the body throws or exits), so the level of false
positives is low.


  parent reply	other threads:[~2013-04-30  6:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07 14:09 [Bug tree-optimization/53265] New: " amonakov at gcc dot gnu.org
2012-05-07 14:21 ` [Bug tree-optimization/53265] " rguenth at gcc dot gnu.org
2013-01-29 17:23 ` jakub at gcc dot gnu.org
2013-01-31 12:13 ` jakub at gcc dot gnu.org
2013-03-11 10:15 ` rguenth at gcc dot gnu.org
2013-03-11 14:14 ` rguenth at gcc dot gnu.org
2013-03-11 14:16 ` rguenth at gcc dot gnu.org
2013-03-11 14:17 ` rguenth at gcc dot gnu.org
2013-03-11 15:49 ` jakub at gcc dot gnu.org
2013-03-11 15:59 ` rguenth at gcc dot gnu.org
2013-03-11 16:16 ` amonakov at gcc dot gnu.org
2013-03-11 16:42 ` manu at gcc dot gnu.org
2013-03-11 16:50 ` manu at gcc dot gnu.org
2013-03-11 17:11 ` jakub at gcc dot gnu.org
2013-03-12 11:25 ` jakub at gcc dot gnu.org
2013-03-12 11:26 ` jakub at gcc dot gnu.org
2013-03-12 11:30 ` jakub at gcc dot gnu.org
2013-03-12 11:48 ` jakub at gcc dot gnu.org
2013-03-12 12:37 ` jakub at gcc dot gnu.org
2013-03-12 12:41 ` jakub at gcc dot gnu.org
2013-03-12 14:15 ` jakub at gcc dot gnu.org
2013-03-12 20:10 ` jakub at gcc dot gnu.org
2013-03-12 21:48 ` jakub at gcc dot gnu.org
2013-03-13 10:36 ` jakub at gcc dot gnu.org
2013-03-13 11:01 ` rguenth at gcc dot gnu.org
2013-03-14  9:14 ` jakub at gcc dot gnu.org
2013-03-14 10:55 ` jakub at gcc dot gnu.org
2013-04-29 23:18 ` ppluzhnikov at google dot com
2013-04-30  6:07 ` jakub at gcc dot gnu.org
2013-04-30  6:46 ` jakub at gcc dot gnu.org [this message]
2014-02-16 13:14 ` jackie.rosen at hushmail dot com
2023-06-09 16:52 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53265-4-cVgr1fzsD3@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).