[Bug target/53283] New: [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[Bug target/53283] New: [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

             Bug #: 53283
           Summary: [4.8 Regression] Many failures on
                    x86_64-apple-darwin10 after revision 186789
    Classification: Unclassified
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: iains@gcc.gnu.org, mikestump@comcast.net,
                    tmsriram@gcc.gnu.org
              Host: x86_64-apple-darwin10
            Target: x86_64-apple-darwin10
             Build: x86_64-apple-darwin10


After revision 186789, the following tests are failing on
x86_64-apple-darwin10:

FAIL: gcc.dg/darwin-cfstring-1.c  (test for errors, line 24)
FAIL: gcc.dg/darwin-cfstring-1.c  (test for errors, line 25)
FAIL: gcc.dg/darwin-cfstring-1.c (test for excess errors)
FAIL: gcc.dg/darwin-cfstring-2.c built-in function .* requires .* flag (test
for errors, line 11)
FAIL: gcc.dg/darwin-cfstring-2.c (test for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O0  (test for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O1  (test for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O2  (test for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O3 -fomit-frame-pointer  (test for
excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O3 -g  (test for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -Os  (test for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O2 -flto -flto-partition=none  (test
for excess errors)
FAIL: gcc.dg/torture/darwin-cfstring-3.c  -O2 -flto  (test for excess errors)
FAIL: gcc.target/i386/builtin_target.c (test for excess errors)

FAIL: objc.dg/strings/const-cfstring-2.m -fnext-runtime (internal compiler
error)
FAIL: objc.dg/strings/const-cfstring-2.m -fnext-runtime  (test for warnings,
line 22)
FAIL: objc.dg/strings/const-cfstring-2.m -fnext-runtime  (test for warnings,
line 23)
FAIL: objc.dg/strings/const-cfstring-2.m -fnext-runtime  (test for warnings,
line 25)
FAIL: objc.dg/strings/const-cfstring-2.m -fnext-runtime  (test for warnings,
line 26)
FAIL: objc.dg/strings/const-cfstring-2.m -fnext-runtime (test for excess
errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O0  -fnext-runtime (test for
excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O1  -fnext-runtime (test for
excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O2  -fnext-runtime (test for
excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O3 -fomit-frame-pointer 
-fnext-runtime (test for excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O3 -g  -fnext-runtime (test
for excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -Os  -fnext-runtime (test for
excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O2 -flto
-flto-partition=none  -fnext-runtime (test for excess errors)
FAIL: objc.dg/torture/strings/const-cfstring-1.m  -O2 -flto  -fnext-runtime
(test for excess errors)

FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++98 (internal compiler error)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++98  (test for errors, line 21)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++98  (test for errors, line 22)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++98 (test for excess errors)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++11 (internal compiler error)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++11  (test for errors, line 21)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++11  (test for errors, line 22)
FAIL: g++.dg/other/darwin-cfstring1.C -std=gnu++11 (test for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O0  (internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O0  (test for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O1  (internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O1  (test for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O2  (internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O2  (test for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O3 -fomit-frame-pointer  (internal
compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O3 -fomit-frame-pointer  (test for
excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O3 -g  (internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O3 -g  (test for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -Os  (internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -Os  (test for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O2 -flto -flto-partition=none 
(internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O2 -flto -flto-partition=none  (test
for excess errors)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O2 -flto  (internal compiler error)
FAIL: g++.dg/torture/darwin-cfstring-3.C  -O2 -flto  (test for excess errors)

FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime (internal compiler
error)
FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime  (test for
warnings, line 22)
FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime  (test for
warnings, line 23)
FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime  (test for
warnings, line 25)
FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime  (test for
warnings, line 26)
FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime (test for excess
errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O0  -fnext-runtime
(internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O0  -fnext-runtime (test
for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O1  -fnext-runtime
(internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O1  -fnext-runtime (test
for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O2  -fnext-runtime
(internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O2  -fnext-runtime (test
for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O3 -fomit-frame-pointer 
-fnext-runtime (internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O3 -fomit-frame-pointer 
-fnext-runtime (test for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O3 -g  -fnext-runtime
(internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O3 -g  -fnext-runtime
(test for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -Os  -fnext-runtime
(internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -Os  -fnext-runtime (test
for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O2 -flto
-flto-partition=none  -fnext-runtime (internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O2 -flto
-flto-partition=none  -fnext-runtime (test for excess errors)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O2 -flto  -fnext-runtime
(internal compiler error)
FAIL: obj-c++.dg/torture/strings/const-cfstring-1.mm  -O2 -flto  -fnext-runtime
(test for excess errors)

Although I did not look exhaustively to the errors, I have found three classes:

(1) gcc.target/i386/builtin_target.c fails with
Undefined symbols:
  "___cpu_indicator_init", referenced from:
      _main in cckJG3Id.o

(2) For gcc.dg/darwin-cfstring-1.c, the errors have changed from

[macbook] f90/bug% /opt/gcc/gcc4.8p-186788/bin/gcc
/opt/gcc/work/gcc/testsuite/gcc.dg/darwin-cfstring-1.c
-fno-diagnostics-show-caret
/opt/gcc/work/gcc/testsuite/gcc.dg/darwin-cfstring-1.c: In function 'main':
/opt/gcc/work/gcc/testsuite/gcc.dg/darwin-cfstring-1.c:24:3: error: CFString
literal expression is not a string constant
/opt/gcc/work/gcc/testsuite/gcc.dg/darwin-cfstring-1.c:25:3: error: CFString
literal expression is not a string constant

to

[macbook] f90/bug% /opt/gcc/gcc4.8p-186789/bin/gcc
/opt/gcc/work/gcc/testsuite/gcc.dg/darwin-cfstring-1.c
-fno-diagnostics-show-caret
/opt/gcc/work/gcc/testsuite/gcc.dg/darwin-cfstring-1.c:20:1: error: initializer
element is not constant

(3) The ICEs I have looked at are of the kind

[macbook] f90/bug% /opt/gcc/gcc4.8p-186789/bin/g++
/opt/gcc/work/gcc/testsuite/g++.dg/torture/darwin-cfstring-3.C -c
-fno-diagnostics-show-caret
/opt/gcc/work/gcc/testsuite/g++.dg/torture/darwin-cfstring-3.C: In function
'void foo()':
/opt/gcc/work/gcc/testsuite/g++.dg/torture/darwin-cfstring-3.C:22:26: internal
compiler error: in ix86_expand_builtin, at config/i386/i386.c:30264
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[tmsriram at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

Sriraman Tallam <tmsriram at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tmsriram at google dot com

--- Comment #1 from Sriraman Tallam <tmsriram at google dot com> 2012-05-08 17:23:00 UTC ---
The builtin_target.c failure on Darwin seems related to this:

http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00455.html

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-05-10 12:36:32 UTC ---
> The builtin_target.c failure on Darwin seems related to this:
>
> http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00455.html

and is fixed by r187365.

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[mrs at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

mrs@gcc.gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |mrs at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #3 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> 2012-05-10 16:10:12 UTC ---
:-)

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2012-05-10
         Resolution|FIXED                       |
     Ever Confirmed|0                           |1

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-05-10 17:49:55 UTC ---
> :-)

Only one test is fixed out of many: all the Darwin specific tests are still
failing.

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[mrs at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

mrs@gcc.gnu.org <mrs at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

--- Comment #5 from mrs at gcc dot gnu.org <mrs at gcc dot gnu.org> 2012-05-10 17:57:01 UTC ---
Oops.

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> 2012-05-19 16:51:27 UTC ---
Created attachment 27441
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27441
fix (bootstrapped *darwin9,10, lightly tested).

.. well Darwin was already using TARGET_FOLD_BUILTIN which has now been
over-ridden in i386.c, leading to the breakage of CFString.

FWIW: since darwin has several targets - we try to keep common stuff in
config/darwin* .. so it's always worth a quick check there, as well as in
config/{i386,rs6000}/

The attached patch bootstrapped on *86*-darwin9/10, ppc-darwin9 - lightly
tested ...  needs checking on Darwin11.

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-05-20 09:29:39 UTC ---
> The attached patch bootstrapped on *86*-darwin9/10, ppc-darwin9 - lightly
> tested ...  needs checking on Darwin11.

The patch in comment #6 (after a clean bootstrap) fixes most of the failures,
but

FAIL: g++.dg/other/darwin-cfstring1.C ...
FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime ...

Note that an ICE has been recently introduced for
obj-c++.dg/ivar-invalid-type-1.mm (I'll open a new PR for it ASAP).

Thanks for the patch

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-05-20 09:38:24 UTC ---
> The patch in comment #6 (after a clean bootstrap) fixes most of the failures,
> but
>
> FAIL: g++.dg/other/darwin-cfstring1.C ...
> FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime ...

Note that these two tests fail also on powerpc-apple-darwin9 (without the patch
in comment #6).

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #9 from Iain Sandoe <iains at gcc dot gnu.org> 2012-05-20 09:42:03 UTC ---
((In reply to comment #7)
> > The attached patch bootstrapped on *86*-darwin9/10, ppc-darwin9 - lightly
> > tested ...  needs checking on Darwin11.
> 
> The patch in comment #6 (after a clean bootstrap) fixes most of the failures,
> but
> 
> FAIL: g++.dg/other/darwin-cfstring1.C ...
> FAIL: obj-c++.dg/strings/const-cfstring-2.mm -fnext-runtime ...

these are, AFAICT, the result of a different problem: viz folding of macro
expressions (not sure I understand what that's doing, exactly)

> 
> Note that an ICE has been recently introduced for
> obj-c++.dg/ivar-invalid-type-1.mm (I'll open a new PR for it ASAP).

I also see this on *-d9, x86-64-d10 - (at present) I think it completely
unrelated, (failing apparently on a line with __thread)

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[gseanmcg at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #10 from Sean McGovern <gseanmcg at gmail dot com> 2012-06-22 18:24:25 UTC ---
Any new action on this? I still can't build anything that depends on the
CFSTR() macro.

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #11 from Iain Sandoe <iains at gcc dot gnu.org> 2012-06-25 07:57:25 UTC ---
posted.
http://gcc.gnu.org/ml/gcc-patches/2012-06/msg01559.html

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[gseanmcg at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #12 from Sean McGovern <gseanmcg at gmail dot com> 2012-07-09 13:32:25 UTC ---
This was OK'ed on the ML but not committed yet?

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

--- Comment #13 from Iain Sandoe <iains at gcc dot gnu.org> 2012-07-09 19:22:03 UTC ---
Author: iains
Date: Mon Jul  9 19:21:59 2012
New Revision: 189391

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=189391
Log:

    PR target/53283
    * config/i386/i386.c (ix86_fold_builtin): Call SUBTARGET_FOLD_BUILTIN
    if defined.
    * config/darwin.h: Rename TARGET_FOLD_BUILTIN to
    SUBTARGET_FOLD_BUILTIN.
    * config/rs6000/darwin.h: Map TARGET_FOLD_BUILTIN onto
    SUBTARGET_FOLD_BUILTIN.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/darwin.h
    trunk/gcc/config/i386/i386.c
    trunk/gcc/config/rs6000/darwin.h

[Bug target/53283] [4.8 Regression] Many failures on x86_64-apple-darwin10 after revision 186789

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53283

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Iain Sandoe <iains at gcc dot gnu.org> 2012-07-10 08:52:47 UTC ---
fixed on trunk, remaining CFString errors are a different problem, needs a new
PR.