public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug other/53284] Several libatomic tests fail on 32-bit Solaris/x86 Date: Wed, 09 May 2012 11:48:00 -0000 [thread overview] Message-ID: <bug-53284-4-YCHCPNqcXu@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-53284-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53284 --- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2012-05-09 11:45:10 UTC --- > --- Comment #1 from Richard Henderson <rth at gcc dot gnu.org> 2012-05-08 22:39:35 UTC --- > Can you investigate why configure decides that __atomic_compare_exchange_8 > is implemented inline? That it isn't inline is obvious from the recursion. That was the critical hint, thanks. Comparing i386-pc-solaris2.10 and i686-unknown-linux-gnu config.log, I see that in the Linux case the test is run as a link test and includes -fno-sync-libcalls $XCFLAGS, while in the Solaris case, it's an compile test and lacks all of them. > Was the configure change to CFLAGS in fact wrong? No, that's unrelated. The following patch works for me and lets all tests in the above configuration pass. I've chosen to add to CFLAGS rather than adding $XCFLAGS since otherwise we loose -fno-sync-libcalls. Ok for mainline? Thanks. Rainer 2012-05-09 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> * acinclude.m4 (LIBAT_TEST_ATOMIC_BUILTIN): Add -O0 -S to CFLAGS instead of overriding. * configure: Regenerate. diff --git a/libatomic/acinclude.m4 b/libatomic/acinclude.m4 --- a/libatomic/acinclude.m4 +++ b/libatomic/acinclude.m4 @@ -67,7 +67,7 @@ AC_DEFUN([LIBAT_TEST_ATOMIC_BUILTIN],[ else old_CFLAGS="$CFLAGS" # Compile unoptimized. - CFLAGS='-O0 -S' + CFLAGS="$CFLAGS -O0 -S" if AC_TRY_EVAL(ac_compile); then if grep __atomic_ conftest.s >/dev/null 2>&1 ; then eval $2=no
next prev parent reply other threads:[~2012-05-09 11:45 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-05-08 16:23 [Bug other/53284] New: " ro at gcc dot gnu.org 2012-05-08 22:56 ` [Bug other/53284] " rth at gcc dot gnu.org 2012-05-09 11:48 ` ro at CeBiTec dot Uni-Bielefeld.DE [this message] 2012-05-09 18:08 ` rth at gcc dot gnu.org 2012-05-10 9:18 ` ro at gcc dot gnu.org 2012-05-10 9:46 ` ro at gcc dot gnu.org 2012-05-10 12:36 ` dominiq at lps dot ens.fr
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-53284-4-YCHCPNqcXu@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).