public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/53300] [4.8 Regression] AIX bootstrap related to varpool patch
Date: Thu, 10 May 2012 18:31:00 -0000	[thread overview]
Message-ID: <bug-53300-4-6ZRipM0Kwx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53300-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53300

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-05-10 17:59:46 UTC ---
i am still somewhat in dark on root of this problem.  What may actually be
problem here is the fact that varpool no longer outputs constant pool decls
relying on constant pool code to manage them on its own.

Does the following hack avoid the problem? Perhaps during the years when
varpool
was outputting constant pool vars something broke in the code tracking when the
var is needed.

Index: varpool.c
===================================================================
--- varpool.c   (revision 187371)
+++ varpool.c   (working copy)
@@ -282,7 +282,8 @@ varpool_assemble_decl (struct varpool_no

   /* Constant pool is output from RTL land when the reference
      survive till this level.  */
-  if (DECL_IN_CONSTANT_POOL (decl))
+  if (DECL_IN_CONSTANT_POOL (decl)
+      && TREE_ASM_WRITTEN (decl))
     return false;

   /* Decls with VALUE_EXPR should not be in the varpool at all.  They


  parent reply	other threads:[~2012-05-10 18:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 19:38 [Bug bootstrap/53300] New: " dje at gcc dot gnu.org
2012-05-09 19:42 ` [Bug bootstrap/53300] " dje at gcc dot gnu.org
2012-05-10  7:33 ` [Bug bootstrap/53300] [4.8 Regression] " rguenth at gcc dot gnu.org
2012-05-10 12:17 ` ro at gcc dot gnu.org
2012-05-10 13:24 ` dje at gcc dot gnu.org
2012-05-10 17:50 ` hubicka at gcc dot gnu.org
2012-05-10 18:31 ` hubicka at gcc dot gnu.org [this message]
2012-05-10 19:47 ` dje at gcc dot gnu.org
2012-05-10 20:47 ` dje at gcc dot gnu.org
2012-05-10 20:55 ` hubicka at ucw dot cz
2012-05-10 22:43 ` ebotcazou at gcc dot gnu.org
2012-05-10 23:12 ` hubicka at ucw dot cz
2012-05-11  8:45 ` hubicka at gcc dot gnu.org
2012-05-11 10:49 ` ro at CeBiTec dot Uni-Bielefeld.DE
2012-05-11 15:11 ` dje at gcc dot gnu.org
2012-05-11 15:11 ` dje at gcc dot gnu.org
2012-05-11 15:12 ` dje at gcc dot gnu.org
2012-05-11 15:46 ` dje at gcc dot gnu.org
2012-05-11 15:49 ` dje at gcc dot gnu.org
2012-09-07 11:46 ` rguenth at gcc dot gnu.org
2012-11-15  3:18 ` pinskia at gcc dot gnu.org
2012-11-15 14:04 ` dje at gcc dot gnu.org
2013-01-15 13:55 ` rguenth at gcc dot gnu.org
2013-01-15 18:24 ` hubicka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53300-4-6ZRipM0Kwx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).