public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/53346] [4.6/4.7/4.8 Regression] Bad vectorization in the proc cptrf2 of rnflow.f90
Date: Wed, 14 Nov 2012 22:38:00 -0000	[thread overview]
Message-ID: <bug-53346-4-pEOdp0sJoY@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53346-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53346

--- Comment #22 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-11-14 22:38:19 UTC ---
OK, similar loop in C looks like:
float a[10000];
float b[10000];
t()
{
  int mi = 0,i;
  for (i=0;i<1000;i++)
    if (a[i]<b[i])
      mi = i;
  return mi;
}
and the why we do not ifconvert at RTl level is that the condition is UNLE that
do not pass unordered_comparsion_operator.  This was noticed by Jakub in other
PR, we do not really need to test unorderedness here since expander knows how
to handle it.  So this was more by chance than by design. I am testing
Index: config/i386/i386.md
===================================================================
--- config/i386/i386.md (revision 193503)
+++ config/i386/i386.md (working copy)
@@ -964,7 +964,7 @@
        (compare:CC (match_operand:SDWIM 1 "nonimmediate_operand")
                    (match_operand:SDWIM 2 "<general_operand>")))
    (set (pc) (if_then_else
-              (match_operator 0 "ordered_comparison_operator"
+              (match_operator 0 "comparison_operator"
                [(reg:CC FLAGS_REG) (const_int 0)])
               (label_ref (match_operand 3))
               (pc)))]
@@ -982,7 +982,7 @@
        (compare:CC (match_operand:SWIM 2 "nonimmediate_operand")
                    (match_operand:SWIM 3 "<general_operand>")))
    (set (match_operand:QI 0 "register_operand")
-       (match_operator 1 "ordered_comparison_operator"
+       (match_operator 1 "comparison_operator"
          [(reg:CC FLAGS_REG) (const_int 0)]))]
   ""
 {
@@ -16120,7 +16120,7 @@

 (define_expand "mov<mode>cc"
   [(set (match_operand:SWIM 0 "register_operand")
-       (if_then_else:SWIM (match_operand 1 "ordered_comparison_operator")
+       (if_then_else:SWIM (match_operand 1 "comparison_operator")
                           (match_operand:SWIM 2 "<general_operand>")
                           (match_operand:SWIM 3 "<general_operand>")))]
   ""


  parent reply	other threads:[~2012-11-14 22:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 15:44 [Bug tree-optimization/53346] New: " dominiq at lps dot ens.fr
2012-05-15  9:54 ` [Bug tree-optimization/53346] " rguenth at gcc dot gnu.org
2012-05-15 12:55 ` dominiq at lps dot ens.fr
2012-05-17 18:35 ` ubizjak at gmail dot com
2012-05-17 20:47 ` ubizjak at gmail dot com
2012-05-18 11:49 ` rguenth at gcc dot gnu.org
2012-05-18 14:28 ` rguenth at gcc dot gnu.org
2012-05-18 14:32 ` rguenth at gcc dot gnu.org
2012-05-18 14:49 ` ubizjak at gmail dot com
2012-05-18 14:52 ` dominiq at lps dot ens.fr
2012-05-18 15:13 ` ubizjak at gmail dot com
2012-05-18 17:32 ` ubizjak at gmail dot com
2012-05-18 17:34 ` ubizjak at gmail dot com
2012-05-18 17:46 ` ubizjak at gmail dot com
2012-05-18 17:48 ` ubizjak at gmail dot com
2012-05-18 17:56 ` pinskia at gcc dot gnu.org
2012-05-18 18:27 ` hjl.tools at gmail dot com
2012-05-18 18:27 ` ubizjak at gmail dot com
2012-05-18 19:45 ` dominiq at lps dot ens.fr
2012-05-19 23:50 ` dominiq at lps dot ens.fr
2012-09-07 11:59 ` [Bug target/53346] " rguenth at gcc dot gnu.org
2012-11-14 22:19 ` hubicka at gcc dot gnu.org
2012-11-14 22:38 ` hubicka at gcc dot gnu.org [this message]
2012-12-31  9:20 ` [Bug target/53346] [4.6/4.7/4.8 Regression] Bad if conversion in " pinskia at gcc dot gnu.org
2012-12-31  9:41 ` pinskia at gcc dot gnu.org
2022-09-26  3:22 ` cvs-commit at gcc dot gnu.org
2022-09-26  3:24 ` crazylht at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53346-4-pEOdp0sJoY@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).