[Bug target/53359] New: [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[Bug target/53359] New: [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

             Bug #: 53359
           Summary: [4.8 regression] undefined reference to
                    `__gnu_cxx::__numeric_traits_integer<int>::__min'
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: schwab@linux-m68k.org
            Target: powerpc64-*-*


>From the libmudflap testsuite:

spawn /daten/gcc/gcc-20120514/Build/./gcc/g++ -shared-libgcc
-B/daten/gcc/gcc-20120514/Build/./gcc -nostdinc++
-L/daten/gcc/gcc-20120514/Build/powerpc64-linux/64/libstdc++-v3/src
-L/daten/gcc/gcc-20120514/Build/powerpc64-linux/64/libstdc++-v3/src/.libs
-B/usr/powerpc64-linux/bin/ -B/usr/powerpc64-linux/lib/ -isystem
/usr/powerpc64-linux/include -isystem /usr/powerpc64-linux/sys-include -m64
-fPIC -mstrict-align -ggdb3 -DDEBUG_ASSERT -D_GLIBCXX_ASSERT -fmessage-length=0
-ffunction-sections -fdata-sections -O2 -g -D_GNU_SOURCE
-I/daten/gcc/gcc-20120514/libmudflap/testsuite
-I/daten/gcc/gcc-20120514/libmudflap/testsuite/.. -I.. -nostdinc++
-I/daten/gcc/gcc-20120514/Build/powerpc64-linux/64/libstdc++-v3/include/powerpc64-linux
-I/daten/gcc/gcc-20120514/Build/powerpc64-linux/64/libstdc++-v3/include
-I/daten/gcc/gcc-20120514/libstdc++-v3/libsupc++
-I/daten/gcc/gcc-20120514/libstdc++-v3/include/backward
-I/daten/gcc/gcc-20120514/libstdc++-v3/testsuite/util
-L/daten/gcc/gcc-20120514/Build/powerpc64-linux/64/libmudflap/.libs
/daten/gcc/gcc-20120514/libmudflap/testsuite/libmudflap.c++/pass41-frag.cxx
-fmudflap -lmudflap
-L/daten/gcc/gcc-20120514/Build/powerpc64-linux/64/libmudflap/testsuite -ldl
-lm -m64 -o ./pass41-frag.exe
/tmp/ccptOQsc.o:(.toc+0x10): undefined reference to
`__gnu_cxx::__numeric_traits_integer<int>::__min'
/tmp/ccptOQsc.o:(.toc+0x18): undefined reference to
`__gnu_cxx::__numeric_traits_integer<int>::__max'
/tmp/ccptOQsc.o:(.toc+0x20): undefined reference to
`__gnu_cxx::__numeric_traits_integer<unsigned long>::__digits'
/tmp/ccptOQsc.o:(.toc+0x28): undefined reference to
`__gnu_cxx::__numeric_traits_integer<char>::__max'
/tmp/ccptOQsc.o:(.toc+0x30): undefined reference to
`__gnu_cxx::__numeric_traits_integer<short>::__min'
/tmp/ccptOQsc.o:(.toc+0x38): undefined reference to
`__gnu_cxx::__numeric_traits_integer<short>::__max'
/tmp/ccptOQsc.o:(.toc+0x40): undefined reference to
`__gnu_cxx::__numeric_traits_integer<long>::__min'
/tmp/ccptOQsc.o:(.toc+0x48): undefined reference to
`__gnu_cxx::__numeric_traits_integer<long>::__max'

Regression introduced between revisions 186361 and 187478.

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> 2012-05-15 17:40:50 UTC ---
ff2a5adaa72fef87cac689a40c23258a30b304c8 is the first bad commit
commit ff2a5adaa72fef87cac689a40c23258a30b304c8
Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Sun Apr 22 21:28:07 2012 +0000

        * lto-symtab.c (lto_varpool_replace_node): Do not merge needed flags.
        * cgraphbuild.c (record_reference, record_type_list, mark_address,
        mark_load, mark_store): Do not mark varpool nodes as needed.
        * cgraph.c (cgraph_new_nodes): Remove.
...
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@186687
138bc75d-0d04-0410-961f-82ee72b054a4

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-05-16 12:34:29 UTC ---
Can you, please get me -fdump-ipa-cgraph and the assembly file?  The testcase
seems to work normally and those constants are supposed to be optimized out.  
For me hose are usual comdat vars:
_ZN9__gnu_cxx24__numeric_traits_integerIlE5__minE/388 (const long int
__gnu_cxx::__numeric_traits_integer<long int>::__min) @0x7ffff650e528
  Type: variable
  Visibility: public weak comdat
comdat_group:_ZN9__gnu_cxx24__numeric_traits_integerIlE5__minE one_only
visibility_specified
  References:
  Referring:
  Availability: not-ready
  Varpool flags: initialized finalized

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> 2012-05-16 13:22:38 UTC ---
Created attachment 27422
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27422
pass41-frag.s

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> 2012-05-16 13:25:18 UTC ---
Created attachment 27423
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27423
pass41-frag.cxx.000i.cgraph

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aoliva at gcc dot gnu.org

--- Comment #5 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-12-06 21:39:50 UTC ---
I have a hunch that the patch for bug 53952 might fix this, if this happens to
be another case of variables that are not addressable being SRAed or otherwise
transformed in ways that makes mudflap marked as addressable and checked when
they didn't even have to be output in the first place.  A preprocessed testcase
would help me test this theory more immediately with a cross compiler, rather
than a full cross toolchain.

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

--- Comment #6 from Andreas Schwab <schwab@linux-m68k.org> 2012-12-07 00:01:40 UTC ---
Created attachment 28889
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28889
Preprocessed testcase

[Bug target/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-12-15
     Ever Confirmed|0                           |1

--- Comment #7 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-12-15 18:40:39 UTC ---
Thanks.  It's not the same issue, after all.  These decls are recorded in
deferred_static_decls, and mudflap_finish_file emits calls to mf_register for
them, so they end up referenced in the toc.  I suppose mudflap_finish_file
needs tweaking to tell that GCC decided not to emit the symbol after all.

[Bug libmudflap/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |aoliva at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #8 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2012-12-15 19:04:00 UTC ---
Jan, does a change like this seem reasonable?

--- a/gcc/tree-mudflap.c
+++ b/gcc/tree-mudflap.c
@@ -1335,6 +1335,10 @@ mudflap_finish_file (void)
           if (! TREE_PUBLIC (obj) && ! TREE_ADDRESSABLE (obj))
             continue;

+      /* If we're not emitting the symbol, don't register it.  */
+      if (!symtab_get_node (obj))
+        continue;
+
           if (! COMPLETE_TYPE_P (TREE_TYPE (obj)))
             {
               warning (OPT_Wmudflap,

[Bug libmudflap/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

--- Comment #9 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2013-01-18 10:58:18 UTC ---
Author: aoliva
Date: Fri Jan 18 10:57:58 2013
New Revision: 195290

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195290
Log:
PR libmudflap/53359
* tree-mudflap.c (mudflap_finish_file): Skip deferred decls
not found in the symtab.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-mudflap.c

[Bug libmudflap/53359] [4.8 regression] undefined reference to `__gnu_cxx::__numeric_traits_integer<int>::__min'

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53359

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2013-01-18 11:17:38 UTC ---
Fixed