[Bug target/53378] New: gcc/regs.h hides system header regs.h on vxWorks

[Bug target/53378] New: gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

             Bug #: 53378
           Summary: gcc/regs.h hides system header regs.h on vxWorks
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rbmj@verizon.net


This may be not-a-bug or wont-fix, but when I'm compiling gcc 4.7.0 on vxWorks,
libgcc/config/vxlib.c #includes taskLib.h.  This vxWorks header then includes
regs.h, another vxWorks system header.  However, at compile time, gcc/regs.h is
included instead.  This conflict causes a multitude of compilation errors.

The current workaround is to go into taskLib.h and change #include <regs.h> to
#include "./regs.h".  Not pretty, but it works.

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-05-16 16:22:33 UTC ---
This is another one of these target headers including GCC headers which should
not be done.

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #2 from rbmj at verizon dot net 2012-05-16 16:33:36 UTC ---
No it is not.  regs.h is a system header on VxWorks.  I can see a big:

/* regs.h - CPU registers */

/* Copyright 1984-2003 Wind River Systems, Inc. */

At the top of /usr/powerpc-wrs-vxworks/sys-include/regs.h.  It includes an
architecture specific register file and then defines a struct regindex.  I
checked gcc/regs.h - they are not the same.

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-05-18
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-05-18 09:19:46 UTC ---
Old known issue.  We use a trick in ada/sigtramp-ppcvxw.c:

#include <vxWorks.h>
#include <arch/../regs.h>
#include <sigLib.h>

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #4 from rbmj at verizon dot net 2012-05-18 12:16:29 UTC ---
The issue is that this is affecting a system header (ioLib.h) which is included
from other, standard header files.

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #5 from rbmj at verizon dot net 2012-05-23 17:27:09 UTC ---
Could this be fixed by a fixincludes stub somewhat like the following?

/*
 *  Work around same-named gcc header regs.h in taskLib.h on VxWorks
 */
fix = {
    hackname    = vxworks_tasklib_regs;
    files       = taskLib.h;
    test        = " -r vxWorks.h ";

    select      = "#[\t ]*include[\t ]+<regs.h>";
    c_fix       = format;
    c_fix_arg   = "#include <arch/../regs.h>";

    test_text   = "`touch taskLib.h vxWorks.h`"
        "#include <regs.h>\n";
};

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-05-23 17:50:44 UTC ---
> Could this be fixed by a fixincludes stub somewhat like the following?

I don't understand why you cannot use a similar trick as ada/sigtramp-ppcvxw.c.

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #7 from rbmj at verizon dot net 2012-05-23 17:57:53 UTC ---
> > Could this be fixed by a fixincludes stub somewhat like the following?
> 
> I don't understand why you cannot use a similar trick as ada/sigtramp-ppcvxw.c.

Isn't that the same trick?  It's just that taskLib.h is not in GCC sources so I
can't just put the change in.  Yes, I can change my local header file, but
isn't avoiding manual changes to system headers and automating that same
process the purpose of fixincludes?

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2012-05-23 18:51:55 UTC ---
> Isn't that the same trick?  It's just that taskLib.h is not in GCC sources so I
> can't just put the change in.

The trick should be in libgcc/config/vxlib.c of course...

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #9 from rbmj at verizon dot net 2012-05-23 19:29:23 UTC ---
Created attachment 27482
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27482
Errors introduced by gcc/regs.h

The problem is that gcc/regs.h introduces its own errors.  It looks like it's
missing some other header of its own.  So even if I add #include
<arch/../regs.h> before #include <taskLib.h>, there's still a bunch of errors
from the transitive include.  It would be possible to just add all the extra
includes that gcc/regs.h needs, but it doesn't seem like the *best* solution,
that's all.

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

--- Comment #10 from rbmj at verizon dot net 2012-06-25 18:25:11 UTC ---
This issue is resolved in this (approved, not committed) patch series here:
http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00382.html, specifically
http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00389.html with dependency on
http://gcc.gnu.org/ml/gcc-patches/2012-06/msg00383.html

[Bug target/53378] gcc/regs.h hides system header regs.h on vxWorks

[rbmj at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53378

rbmj at verizon dot net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from rbmj at verizon dot net 2012-10-30 02:01:21 UTC ---
Fixed in 192952!