public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/53426] [4.8 Regression] ICE:create_variable_info_for  at ../../gcc-trunk/gcc/tree-ssa-structalias.c:5581
Date: Tue, 22 May 2012 12:39:00 -0000	[thread overview]
Message-ID: <bug-53426-4-li6FfLY0wc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53426-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53426

--- Comment #6 from Jan Hubicka <hubicka at ucw dot cz> 2012-05-22 12:19:55 UTC ---
> by changing it to
> 
>           if (!vnode
>               || DECL_INITIAL (vnode) == error_mark_node
>               || !varpool_all_refs_explicit_p (vnode))
>             make_copy_constraint (vi, nonlocal_id);
> 
> also noting the special error_mark_node DECL_INITIAL (what's that coming
> from!?)

DECL_INITIAL is replaced by error mark when the variable is removed from
varpool
(so we know it is no longer going to be referenced or emit in some way) to
conserve
memory.

Other case is the partitioning, when the variable is in the other partition 
and thus there is no need to sream the DECL_INITIAL (we stream DECL_INITIAL for
variables from other partitions only when we think it may be useful for
constant
folding: that is variables passes const_value_known_p).  This is probably the
case
here.

If you only need to collect all things that escape, you can safely ignore
DECL_INITIAL of DECLs with in_ohter_partition set: all vars that are in current
partition referenced by the constructor from other partition
"used_from_other_partition" set anyway, so they won't pass
varpool_all_refs_explicit_p.

You only need to worry about local constructors.

Honza


  parent reply	other threads:[~2012-05-22 12:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-53426-4@http.gcc.gnu.org/bugzilla/>
2012-05-20 20:01 ` [Bug lto/53426] [lto]: " pinskia at gcc dot gnu.org
2012-05-20 20:10 ` pinskia at gcc dot gnu.org
2012-05-21 10:04 ` [Bug lto/53426] [lto with ipa-pta]: " vincenzo.innocente at cern dot ch
2012-05-21 12:37 ` [Bug tree-optimization/53426] [4.8 Regression] " rguenth at gcc dot gnu.org
2012-05-21 15:09 ` hubicka at ucw dot cz
2012-05-22 10:16 ` rguenth at gcc dot gnu.org
2012-05-22 12:39 ` hubicka at ucw dot cz [this message]
2012-05-22 12:48 ` rguenth at gcc dot gnu.org
2012-05-22 12:56 ` hubicka at ucw dot cz
2012-05-22 13:42 ` hubicka at gcc dot gnu.org
2012-05-22 14:40 ` rguenth at gcc dot gnu.org
2012-05-23  8:11 ` vincenzo.innocente at cern dot ch
2012-05-23 10:49 ` hubicka at gcc dot gnu.org
2012-05-23 11:53 ` rguenth at gcc dot gnu.org
2012-05-23 12:27 ` vincenzo.innocente at cern dot ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53426-4-li6FfLY0wc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).