public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "lhyatt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/53431] C++ preprocessor ignores #pragma GCC diagnostic
Date: Fri, 24 Dec 2021 21:29:22 +0000	[thread overview]
Message-ID: <bug-53431-4-cWCJJAJVZ7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-53431-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53431

--- Comment #47 from Lewis Hyatt <lhyatt at gcc dot gnu.org> ---
(In reply to Manuel López-Ibáñez from comment #46)
> If you don't get much attention to the patch, it may be worth pinging it.
> But before that, I would also suggest submitting all the cleanups separately
> as their own, easy-to-review patch. For example, the bits about
> cp_token_is_module_directive.

Thank you for the note, I have resubmitted it to gcc-patches in two parts:
https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587357.html
https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587358.html

The cp_token_is_module_directive that you highlighted clearly should be in its
own patch, yes. I looked through the rest though and wasn't able to identify
anything else that seemed to make sense when split out on its own, so that
ended up being the only thing I factored out.

  parent reply	other threads:[~2021-12-24 21:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-21  8:03 [Bug c++/53431] New: C++ preprocessor ignores #pragma GCC diagnostic ignored "-Wundef" ml.lattuada at libero dot it
2013-02-17 17:04 ` [Bug c++/53431] " rainarchitect at gmail dot com
2013-03-03  4:10 ` markus at oberhumer dot com
2013-07-12  9:20 ` nomegenerico at email dot it
2013-11-16 18:13 ` rainarchitect at gmail dot com
2013-11-16 19:51 ` manu at gcc dot gnu.org
2013-11-16 20:23 ` manu at gcc dot gnu.org
2014-09-05 17:42 ` [Bug c++/53431] C++ preprocessor ignores #pragma GCC diagnostic manu at gcc dot gnu.org
2015-06-03  8:27 ` manu at gcc dot gnu.org
2015-07-20  9:38 ` manu at gcc dot gnu.org
2015-07-22  0:00 ` noloader at gmail dot com
2015-07-22 10:51 ` redi at gcc dot gnu.org
2015-07-22 11:24 ` noloader at gmail dot com
2015-07-23 10:34 ` noloader at gmail dot com
2015-07-23 10:47 ` redi at gcc dot gnu.org
2015-07-23 11:32 ` manu at gcc dot gnu.org
2015-07-23 13:20 ` manu at gcc dot gnu.org
2015-07-23 23:26 ` noloader at gmail dot com
2015-07-30 17:22 ` miyuki at gcc dot gnu.org
2021-02-27 11:24 ` noloader at gmail dot com
2021-06-03 12:04 ` redi at gcc dot gnu.org
2021-10-06 14:40 ` jakub at gcc dot gnu.org
2021-12-01 17:43 ` egallager at gcc dot gnu.org
2021-12-04 17:48 ` lhyatt at gcc dot gnu.org
2021-12-19 11:55 ` pinskia at gcc dot gnu.org
2021-12-19 19:50 ` manu at gcc dot gnu.org
2021-12-24 21:29 ` lhyatt at gcc dot gnu.org [this message]
2022-03-23  0:58 ` pinskia at gcc dot gnu.org
2022-05-25 13:38 ` lhyatt at gcc dot gnu.org
2022-06-29 16:08 ` lhyatt at gcc dot gnu.org
2022-07-06 19:40 ` cvs-commit at gcc dot gnu.org
2022-07-06 19:42 ` lhyatt at gcc dot gnu.org
2022-07-06 22:59 ` lhyatt at gcc dot gnu.org
2022-11-08 22:28 ` redi at gcc dot gnu.org
2022-11-09  0:05 ` markus at oberhumer dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53431-4-cWCJJAJVZ7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).