[Bug target/53435] New: (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[Bug target/53435] New: (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

             Bug #: 53435
           Summary: (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do
                    not pass arguments to avx2_permvar8s[f,i] correctly
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: aivchenk@gmail.com
                CC: areg.melikadamyan@gmail.com, hjl.tools@gmail.com,
                    kirill.yukhin@intel.com, ubizjak@gmail.com
            Target: i?86-*-* x86_64-*-*


Seems that after:

commit 8da8a06b586ddd9511b5c5c83e2c28ca8d7613a8
Author: uros <uros@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Apr 12 18:37:42 2012 +0000

        PR target/52932
        * config/i386/avx2intrin.h (_mm256_permutevar8x32_ps): Change second
        argument type to __m256i.  Update call to __builtin_ia32_permvarsf256.
...
        (avx2_permvarv8sf, avx2_permvarv8si): Switch operands 1 and 2.
...
        (ix86_expand_vec_perm): Update calls to gen_avx2_permvarv8si and
        gen_avx2_permvarv8sf.
        (expand_vec_perm_pshufb): Ditto.


gcc.c-torture/execute/vshuf-v* and gcc.dg/torture/pr45720.c fail.

The problem is that not everything that had to be changed was changed to use
the second argument as __m256i.

Please take a look at the attached patch that should fix those problems

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[kirill.yukhin at intel dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

--- Comment #2 from Yukhin Kirill <kirill.yukhin at intel dot com> 2012-05-21 12:17:41 UTC ---
(In reply to comment #0)
> 
> gcc.c-torture/execute/vshuf-v* and gcc.dg/torture/pr45720.c fail.
> 
This occurs on AVX2-capable HW

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[aivchenk at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

--- Comment #1 from Alexander Ivchenko <aivchenk at gmail dot com> 2012-05-21 11:46:35 UTC ---
Created attachment 27460
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27460
proposed patch for fixing

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> 2012-05-21 13:13:02 UTC ---
(In reply to comment #1)
> Created attachment 27460 [details]
> proposed patch for fixing

Please submit it to gcc-patches mailing list.

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[kyukhin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

--- Comment #4 from Kirill Yukhin <kyukhin at gcc dot gnu.org> 2012-05-25 13:03:21 UTC ---
Author: kyukhin
Date: Fri May 25 13:03:18 2012
New Revision: 187881

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=187881
Log:
2012-05-21  Alexander Ivchenko  <alexander.ivchenko@intel.com>

       PR target/53435
       * config/i386/i386.c (ix86_expand_vec_perm): Use correct op.
       (ix86_expand_vec_perm): Use int mode instead of float.
       (expand_vec_perm_pshufb): Remove handling of useseless type
       conversion.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[kyukhin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

--- Comment #5 from Kirill Yukhin <kyukhin at gcc dot gnu.org> 2012-05-25 13:34:12 UTC ---
Author: kyukhin
Date: Fri May 25 13:34:07 2012
New Revision: 187882

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=187882
Log:
2012-05-25  Alexander Ivchenko  <alexander.ivchenko@intel.com>

        PR target/53435
        * config/i386/i386.c (ix86_expand_vec_perm): Use correct op.
        (ix86_expand_vec_perm): Use int mode instead of float.


Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/config/i386/i386.c

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[glisse at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

--- Comment #6 from Marc Glisse <glisse at gcc dot gnu.org> 2012-12-04 19:18:26 UTC ---
Can we close this one?

[Bug target/53435] (ix86_expand_vec_perm) and (ix86_expand_vec_perm) do not pass arguments to avx2_permvar8s[f,i] correctly

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53435

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2012-05/msg01415.htm
                   |                            |l
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.3

--- Comment #7 from Uros Bizjak <ubizjak at gmail dot com> 2012-12-04 19:31:28 UTC ---
Fixed some time ago.