public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "carrot at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/53447] New: missed optimization of 64bit ALU operation with small constant
Date: Tue, 22 May 2012 07:37:00 -0000	[thread overview]
Message-ID: <bug-53447-4@http.gcc.gnu.org/bugzilla/> (raw)

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53447

             Bug #: 53447
           Summary: missed optimization of 64bit ALU operation with small
                    constant
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: carrot@google.com
            Target: arm-unknown-linux-gnueabi


Compile the following code with options -march=armv7-a -O2 -mthumb

void t0p(long long *p)
{
  *p += 1;
}

GCC 4.8  generates:


t0p:
    ldrd    r2, [r0]
    push    {r4, r5}
    movs    r4, #1       //A
    adds    r2, r2, r4   //B
    mov    r5, #0       //C
    adc    r3, r3, r5   //D
    strd    r2, [r0]
    pop    {r4, r5}
    bx    lr

Instructions ABCD can be simplified as

        adds   r2, r2, 1
        adc    r3, r3, 0

This sequence is smaller and faster than original code, it uses two less
registers, so the push/pop instructions can also be removed.

Both arm/thumb mode and Os/O2 generates similar code.

This optimization can also be applied to other alu operations, such as
sub/and/or/xor/cmp.


             reply	other threads:[~2012-05-22  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  7:37 carrot at google dot com [this message]
2012-05-22  9:57 ` [Bug target/53447] " steven at gcc dot gnu.org
2012-05-22 10:01 ` steven at gcc dot gnu.org
2012-05-23  7:06 ` carrot at google dot com
2012-07-01 15:15 ` carrot at gcc dot gnu.org
2012-07-06  2:23 ` carrot at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-53447-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).