[Bug target/53461] New: Incorrect handling of CASE_VECTOR_PC_RELATIVE in config/m68k.md

[Bug target/53461] New: Incorrect handling of CASE_VECTOR_PC_RELATIVE in config/m68k.md

[gvvn1200 at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53461

             Bug #: 53461
           Summary: Incorrect handling of CASE_VECTOR_PC_RELATIVE in
                    config/m68k.md
    Classification: Unclassified
           Product: gcc
           Version: 4.6.3
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: gvvn1200@gmail.com


I have been trying to port a recent gcc version to m68k-next-nextstep3 target
and encountered an ICE in the stage1 compiler.  With help of the m68k debian
ports community I was able to identify a bug in config/m68k/m68k.md.  This bug
exists in all reasonably recent versions of gcc but not in gcc-3.2 and gcc-3.4.

The m68k.md file contains the following conditional statement:

#ifdef CASE_VECTOR_PC_RELATIVE
   operands[0] = gen_rtx_PLUS (SImode, pc_rtx,
                gen_rtx_SIGN_EXTEND (SImode, operands[0]));
#endif

If the target configuration files undefine CASE_VECTOR_PC_RELATIVE, the
defaults.h header redefines CASE_VECTOR_PC_RELATIVE as follows:

/* Assume that case vectors are not pc-relative.  */
#ifndef CASE_VECTOR_PC_RELATIVE
#define CASE_VECTOR_PC_RELATIVE 0
#endif

The defaults.h header file is included after the target configuration files and
thus overrides the CASE_VECTOR_PC_RELATIVE.  The conditional statement in
config/m68k/m68k.md is therefore always satisfied even if the target
configuration undefines CASE_VECTOR_PC_RELATIVE.

I was able to resolve the issue with the following change to
config/m68k/m68k.md:

#if CASE_VECTOR_PC_RELATIVE != 0
   operands[0] = gen_rtx_PLUS (SImode, pc_rtx,
                gen_rtx_SIGN_EXTEND (SImode, operands[0]));
#endif

t-rexky

[Bug target/53461] Incorrect handling of CASE_VECTOR_PC_RELATIVE in config/m68k.md

[gvvn1200 at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53461

t-rexky <gvvn1200 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

[Bug target/53461] Incorrect handling of CASE_VECTOR_PC_RELATIVE in config/m68k.md

[schwab at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53461

--- Comment #1 from Andreas Schwab <schwab at gcc dot gnu.org> 2012-06-04 13:13:15 UTC ---
Author: schwab
Date: Mon Jun  4 13:13:09 2012
New Revision: 188179

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188179
Log:
PR target/53461
* config/m68k/m68k.md ("tablejump"): Fix check for
CASE_VECTOR_PC_RELATIVE.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/m68k/m68k.md

[Bug target/53461] Incorrect handling of CASE_VECTOR_PC_RELATIVE in config/m68k.md

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53461

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> 2012-06-04 13:14:43 UTC ---
Fixed in trunk.