[Bug middle-end/53616] New: [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[Bug middle-end/53616] New: [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

             Bug #: 53616
           Summary: [4.8 Regression]  416.gamess in SPEC CPU 2006
                    miscompiled
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: areg.melikadamyan@gmail.com


On Linux/x86-64, revision 188299 miscompiled 416.gamess in SPEC CPU 2006
with:

-O3 -funroll-loops -ffast-math -ffixed-form  -DSPEC_CPU_LP64

 Running 416.gamess ref peak lnx32e-gcc default

*** Miscompare of triazolium.out; for details see
   
/export/gnu/import/git/gcc-test-spec/spec/2006/x86_64/spec/benchspec/CPU2006
/416.gamess/run/run_peak_ref_lnx32e-gcc.0000/triazolium.out.mis

*** Miscompare of cytosine.2.out; for details see
   
/export/gnu/import/git/gcc-test-spec/spec/2006/x86_64/spec/benchspec/CPU2006
/416.gamess/run/run_peak_ref_lnx32e-gcc.0000/cytosine.2.out.mis

Revision 188248 is OK.

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org
   Target Milestone|---                         |4.8.0

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-08 22:15:39 UTC ---
It is caused by revision 188261:

http://gcc.gnu.org/ml/gcc-cvs/2012-06/msg00171.html

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2012-06-11
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-11 09:48:04 UTC ---
Mine.

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-11 13:58:38 UTC ---
Author: rguenth
Date: Mon Jun 11 13:58:29 2012
New Revision: 188386

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188386
Log:
2012-06-11  Richard Guenther  <rguenther@suse.de>

    PR c++/53616
    * mangle.c (write_array_type): Use double-ints for array domain
    arithmetic.

    * g++.dg/ext/pr53605.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/ext/pr53605.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/mangle.c
    trunk/gcc/testsuite/ChangeLog

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-12 12:29:46 UTC ---
I can't reproduce the miscompares - are these really the only flags you use?
Which local patches do you apply to gamess?  For me gamess just hangs (but
even before the patch - ah, PR53086).

I do see a _lot_ of generated memcpy/memmove calls, so bisecting those will be
hard.

I can reproduce it with -flto which avoids PR53086, but only with ref input.

Do you have a SPEC patch for PR53086?

Thx.

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> 2012-06-12 13:03:57 UTC ---
Created attachment 27610
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27610
alt.src for 416.games

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-12 14:06:18 UTC ---
Ok, that doesn't apply for me (I'm stuck on v1.0).  I can reproduce it with
-fno-tree-vrp without LTO but only with reference input (thus bisecting
to a single file will take _quite_ some time).  There are more than 1000
loop replacements with memcpy/memmove.

Let's say I hope somebody comes up with a smaller wrong-code testcase ;))

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-06-14 13:02:12 UTC ---
Author: rguenth
Date: Thu Jun 14 13:02:06 2012
New Revision: 188615

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=188615
Log:
2012-06-14  Richard Guenther  <rguenther@suse.de>

        Backport from mainline
        2012-06-11  Richard Guenther  <rguenther@suse.de>

    PR c++/53616
    * mangle.c (write_array_type): Use double-ints for array domain
    arithmetic.

    * g++.dg/ext/pr53605.C: New testcase.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/ext/pr53605.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/ChangeLog
    branches/gcc-4_7-branch/gcc/cp/mangle.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[pthaugen at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

Pat Haugen <pthaugen at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pthaugen at gcc dot gnu.org

--- Comment #8 from Pat Haugen <pthaugen at gcc dot gnu.org> 2012-06-27 19:11:59 UTC ---
This fails on PowerPC also with just -O3. I'll see what I can do about
narrowing down to a smaller testcase.

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #9 from rguenther at suse dot de <rguenther at suse dot de> 2012-06-28 08:26:42 UTC ---
On Wed, 27 Jun 2012, pthaugen at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616
> 
> Pat Haugen <pthaugen at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |pthaugen at gcc dot gnu.org
> 
> --- Comment #8 from Pat Haugen <pthaugen at gcc dot gnu.org> 2012-06-27 19:11:59 UTC ---
> This fails on PowerPC also with just -O3. I'll see what I can do about
> narrowing down to a smaller testcase.

I expect it to be yet another 416.gamess source bug.  Which is why
this did not have high priority for me.

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[vbyakovl23 at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #10 from Vladimir Yakovlev <vbyakovl23 at gmail dot com> 2012-07-23 12:48:59 UTC ---
Created attachment 27858
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27858
Reduced test case

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[vbyakovl23 at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

Vladimir Yakovlev <vbyakovl23 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vbyakovl23 at gmail dot com

--- Comment #11 from Vladimir Yakovlev <vbyakovl23 at gmail dot com> 2012-07-23 12:53:13 UTC ---
Miscompare in 416 .games is caused by a wrong transformation of a loop in file
grd2b.f, lines 113-121.

      DO 110 M=1,3
        P12(M,1)= C(M,IAT)
        P12(M,2)= C(M,JAT)
        P12(M,3)= P12(M,2)-P12(M,1)
      R12= R12+P12(M,3)*P12(M,3)
         P34(M,1)= C(M,KAT)
         P34(M,2)= C(M,LAT)
         P34(M,3)= P34(M,2)-P34(M,1)
  110 R34= R34+P34(M,3)*P34(M,3)

After transformation we have

      P12(:,1) = C(:,IAT)
      P12(:,2) = C(:,jAT)
      DO 110 M=1,3
        P12(M,3)= P12(M,2)-P12(M,1)
      R12= R12+P12(M,3)*P12(M,3)
         P34(M,3)= P34(M,2)-P34(M,1)
  110 R34= R34+P34(M,3)*P34(M,3)
      P34(:,1) = C(:,KAT)
      P34(:,2) = C(:,LAT)

That is we changed order of operators in the loop. Right transformation should
be

      P12(:,1) = C(:,IAT)
      P12(:,2) = C(:,jAT)
      DO 110 M=1,3
        P12(M,3)= P12(M,2)-P12(M,1)
  110   R12= R12+P12(M,3)*P12(M,3)
      P34(:,1) = C(:,KAT)
      P34(:,2) = C(:,LAT)
      DO 111 M=1,3
         P34(M,3)= P34(M,2)-P34(M,1)
  111 R34= R34+P34(M,3)*P34(M,3)

I attached a reduced test case and dumps with and without transformations.
Command line to compile is 

gfortran   m.f t.f -O3
The result of run is differed from a result of code compiled with -O0 opt
level.
I used compiler

Target: x86_64-unknown-linux-gnu
Configured with: ../gcc/configure --with-arch=corei7 --with-cpu=corei7
--enable-clocale=gnu --with-system-zlib --enable-shared --with-demangler-in-ld
--enable-cloog-backend=isl --with-fpmath=sse --enable-languages=c,c++,fortran
--enable-bootstrap=no
Thread model: posix
gcc version 4.8.0 20120606 (experimental) (GCC)

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #12 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-07-23 13:29:22 UTC ---
Thanks for the detective work!  Mine.

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #13 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-07-24 08:37:50 UTC ---
Author: rguenth
Date: Tue Jul 24 08:37:43 2012
New Revision: 189802

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=189802
Log:
2012-07-24  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/53616
    * tree-loop-distribution.c (ldist_gen): Do not change
    partition ordering when merging partitions.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-loop-distribution.c

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-07-24 09:05:21 UTC ---
Fixed (hopefully).

[Bug middle-end/53616] [4.8 Regression] 416.gamess in SPEC CPU 2006 miscompiled

[vbyakovl23 at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53616

--- Comment #15 from Vladimir Yakovlev <vbyakovl23 at gmail dot com> 2012-07-24 15:36:16 UTC ---
416.games is passed now.