From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21821 invoked by alias); 12 Jun 2012 06:25:25 -0000 Received: (qmail 21806 invoked by uid 22791); 12 Jun 2012 06:25:24 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jun 2012 06:25:11 +0000 From: "chrbr at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/53621] [SH] Frame pointers not generated with -fno-omit-frame-pointer on GCC 4.7.0 Date: Tue, 12 Jun 2012 06:25:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: chrbr at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-06/txt/msg00652.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53621 --- Comment #7 from chrbr at gcc dot gnu.org 2012-06-12 06:25:09 UTC --- (In reply to comment #6) > I thought that -pg and -fomit-frame-pointer are always incompatible. > Agree with the possible issues for old unwinders. > > I've forgotten that sh coff targets went away. Then, removing that > line might be enough. > I'd like to approve any patches for this PR :-) It should be > backported to the release branches, because this is a 4.6/4.7/4.8 > regression from 4.5, AFAIK. I will remove it, but first I'd like to make a few other checks: I had a look to see why this was broken since the 4.6, and it appears that the line was well formed when it lived within the OPTIMIZATION_OPTION hook. However it was removed and all the settings moved away first to the TARGET_OPTION_OVERRIDE hook, which now is bogus. in the 4.6 branch we could still use TARGET_OPTION_INIT_STRUCT but not in the 4.7. so the fix will certainly differ between branches. So I'd prefer that all the internal variables that used to be set in sh_optimization_option should be double checked.