public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/53626] New: move assignment for ifstream
@ 2012-06-10 19:46 mikhail_semenov at hotmail dot com
2012-06-10 21:20 ` [Bug c++/53626] [C++11] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: mikhail_semenov at hotmail dot com @ 2012-06-10 19:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53626
Bug #: 53626
Summary: move assignment for ifstream
Classification: Unclassified
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: mikhail_semenov@hotmail.com
Created attachment 27599
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27599
The program
The move assignment operator should be provided for ifstream.
The following program fails to compile. It should print out the contents of a
text file, whose first line starts with "My File".
#include <iostream>
#include <string>
#include <fstream>
std::ifstream OpenMyFile(const std::string& filename)
{
std::ifstream file(filename);
if (!file.good())
{
file.close();
return file;
}
std::string s;
std::getline(file, s);
if (s.substr(0,7) != "My File")
{
file.close();
file.setstate(std::ios_base::failbit);
return file;
}
return file;
}
int main(int count, char *args[])
{
if (count < 2)
{
std::cout << "Incorrect number of parameters" << std::endl;
return -1;
}
std::ifstream myFile = OpenMyFile(args[1]);
if (myFile.good())
{
while (!myFile.eof())
{
std::string s;
std::getline(myFile,s);
std::cout << s << std::endl;
}
}
else
{
std::cout << "*** FILE ERROR ***" << std::endl;
}
return 0;
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c++/53626] [C++11] move assignment for ifstream
2012-06-10 19:46 [Bug c++/53626] New: move assignment for ifstream mikhail_semenov at hotmail dot com
@ 2012-06-10 21:20 ` redi at gcc dot gnu.org
2013-06-22 19:11 ` [Bug libstdc++/53626] " paolo.carlini at oracle dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2012-06-10 21:20 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53626
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|move assignment for |[C++11] move assignment for
|ifstream |ifstream
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-06-10 21:20:27 UTC ---
Yep, this is documented as missing:
http://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2011
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/53626] [C++11] move assignment for ifstream
2012-06-10 19:46 [Bug c++/53626] New: move assignment for ifstream mikhail_semenov at hotmail dot com
2012-06-10 21:20 ` [Bug c++/53626] [C++11] " redi at gcc dot gnu.org
@ 2013-06-22 19:11 ` paolo.carlini at oracle dot com
2014-09-19 10:58 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paolo.carlini at oracle dot com @ 2013-06-22 19:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53626
--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> ---
*** Bug 57677 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/53626] [C++11] move assignment for ifstream
2012-06-10 19:46 [Bug c++/53626] New: move assignment for ifstream mikhail_semenov at hotmail dot com
2012-06-10 21:20 ` [Bug c++/53626] [C++11] " redi at gcc dot gnu.org
2013-06-22 19:11 ` [Bug libstdc++/53626] " paolo.carlini at oracle dot com
@ 2014-09-19 10:58 ` redi at gcc dot gnu.org
2014-09-22 13:34 ` redi at gcc dot gnu.org
2014-09-22 13:45 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-09-19 10:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53626
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2014-09-19
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Target Milestone|--- |5.0
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/53626] [C++11] move assignment for ifstream
2012-06-10 19:46 [Bug c++/53626] New: move assignment for ifstream mikhail_semenov at hotmail dot com
` (2 preceding siblings ...)
2014-09-19 10:58 ` redi at gcc dot gnu.org
@ 2014-09-22 13:34 ` redi at gcc dot gnu.org
2014-09-22 13:45 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-09-22 13:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53626
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Sep 22 13:34:09 2014
New Revision: 215463
URL: https://gcc.gnu.org/viewcvs?rev=215463&root=gcc&view=rev
Log:
Make streams movable and swappable.
PR libstdc++/54316
PR libstdc++/53626
* config/abi/pre/gnu.ver: Add new exports.
* config/io/basic_file_stdio.h (__basic_file): Support moving and
swapping.
* include/bits/basic_ios.h (basic_ios::move, basic_ios::swap):
Likewise.
* include/bits/ios_base.h (ios_base::_M_move, ios_base::_M_swap):
Likewise.
* include/bits/fstream.tcc (basic_filebuf): Likewise.
* include/bits/move.h (__exchange): Define for C++11 mode.
* include/ext/stdio_filebuf.h (stdio_filebuf): Support moving and
swapping.
* include/ext/stdio_sync_filebuf.h (stdio_sync_filebuf): Likewise.
* include/std/fstream (basic_filebuf, basic_ifstream, basic_ofstream,
basic_fstream): Likewise.
* include/std/ios: Remove whitespace.
* include/std/istream (basic_istream, basic_iostream): Support moving
and swapping.
* include/std/ostream (basic_ostream): Likewise.
* include/std/sstream (basic_stringbuf, basic_istringstream,
basic_ostringstream, basic_stringstream): Likewise.
* include/std/streambuf (basic_streambuf): Do not default copy
constructor and assignment on first declaration.
* include/std/utility (exchange): Forward to __exchange.
* testsuite/27_io/basic_filebuf/cons/char/copy_neg.cc: New.
* src/c++11/Makefile.am: Add stream-related files.
* src/c++11/Makefile.in: Regenerate.
* src/c++11/ext11-inst.cc (stdio_filebuf, stdio_sync_filebuf):
New file for explicit instantiation definitions.
* src/c++11/ios.cc: Move from src/c++98 to here.
(ios_base::_M_move, ios_base::_M_swap): Define.
* src/c++11/ios-inst.cc: Move from src/c++98 to here.
* src/c++11/iostream-inst.cc: Likewise.
* src/c++11/istream-inst.cc: Likewise.
* src/c++11/ostream-inst.cc: Likewise.
* src/c++11/sstream-inst.cc: Likewise.
* src/c++11/streambuf-inst.cc: Likewise.
* src/c++98/Makefile.am: Remove stream-related files.
* src/c++98/Makefile.in: Regenerate.
* src/c++98/ext-inst.cc (stdio_filebuf): Remove explicit
instantiations.
* src/c++98/misc-inst.cc (stdio_sync_filebuf): Likewise.
* src/c++98/ios-inst.cc: Move to src/c++11/.
* src/c++98/ios.cc: Move to src/c++11/.
* src/c++98/iostream-inst.cc: Likewise.
* src/c++98/istream-inst.cc: Likewise.
* src/c++98/ostream-inst.cc: Likewise.
* src/c++98/sstream-inst.cc: Likewise.
* src/c++98/streambuf-inst.cc: Likewise.
* testsuite/27_io/basic_filebuf/cons/char/copy_neg.cc: New.
* testsuite/27_io/basic_fstream/cons/move.cc: New.
* testsuite/27_io/basic_fstream/assign/1.cc: New.
* testsuite/27_io/basic_ifstream/cons/move.cc: New.
* testsuite/27_io/basic_ifstream/assign/1.cc: New.
* testsuite/27_io/basic_istringstream/assign/1.cc: New.
* testsuite/27_io/basic_istringstream/cons/move.cc: New.
* testsuite/27_io/basic_ofstream/cons/move.cc: New.
* testsuite/27_io/basic_ofstream/assign/1.cc: New.
* testsuite/27_io/basic_ostringstream/assign/1.cc: New.
* testsuite/27_io/basic_ostringstream/cons/move.cc: New.
* testsuite/27_io/basic_stringstream/assign/1.cc: New.
* testsuite/27_io/basic_stringstream/cons/move.cc: New.
Added:
trunk/libstdc++-v3/src/c++11/ext11-inst.cc
- copied, changed from r215458, trunk/libstdc++-v3/src/c++98/ios-inst.cc
trunk/libstdc++-v3/src/c++11/ios-inst.cc
- copied, changed from r215458, trunk/libstdc++-v3/src/c++98/ios-inst.cc
trunk/libstdc++-v3/src/c++11/ios.cc
- copied, changed from r215458, trunk/libstdc++-v3/src/c++98/ios.cc
trunk/libstdc++-v3/src/c++11/iostream-inst.cc
- copied, changed from r215458,
trunk/libstdc++-v3/src/c++98/iostream-inst.cc
trunk/libstdc++-v3/src/c++11/istream-inst.cc
- copied, changed from r215458,
trunk/libstdc++-v3/src/c++98/istream-inst.cc
trunk/libstdc++-v3/src/c++11/ostream-inst.cc
- copied, changed from r215458,
trunk/libstdc++-v3/src/c++98/ostream-inst.cc
trunk/libstdc++-v3/src/c++11/sstream-inst.cc
- copied, changed from r215458,
trunk/libstdc++-v3/src/c++98/sstream-inst.cc
trunk/libstdc++-v3/src/c++11/streambuf-inst.cc
- copied, changed from r215458,
trunk/libstdc++-v3/src/c++98/streambuf-inst.cc
trunk/libstdc++-v3/testsuite/27_io/basic_filebuf/cons/char/copy_neg.cc
trunk/libstdc++-v3/testsuite/27_io/basic_fstream/assign/
trunk/libstdc++-v3/testsuite/27_io/basic_fstream/assign/1.cc
trunk/libstdc++-v3/testsuite/27_io/basic_fstream/cons/move.cc
trunk/libstdc++-v3/testsuite/27_io/basic_ifstream/assign/
trunk/libstdc++-v3/testsuite/27_io/basic_ifstream/assign/1.cc
trunk/libstdc++-v3/testsuite/27_io/basic_ifstream/cons/move.cc
trunk/libstdc++-v3/testsuite/27_io/basic_istringstream/assign/
trunk/libstdc++-v3/testsuite/27_io/basic_istringstream/assign/1.cc
trunk/libstdc++-v3/testsuite/27_io/basic_istringstream/cons/move.cc
trunk/libstdc++-v3/testsuite/27_io/basic_ofstream/assign/
trunk/libstdc++-v3/testsuite/27_io/basic_ofstream/assign/1.cc
trunk/libstdc++-v3/testsuite/27_io/basic_ofstream/cons/move.cc
trunk/libstdc++-v3/testsuite/27_io/basic_ostringstream/assign/
trunk/libstdc++-v3/testsuite/27_io/basic_ostringstream/assign/1.cc
trunk/libstdc++-v3/testsuite/27_io/basic_ostringstream/cons/move.cc
trunk/libstdc++-v3/testsuite/27_io/basic_stringstream/assign/
trunk/libstdc++-v3/testsuite/27_io/basic_stringstream/assign/1.cc
trunk/libstdc++-v3/testsuite/27_io/basic_stringstream/cons/move.cc
Removed:
trunk/libstdc++-v3/src/c++98/ios-inst.cc
trunk/libstdc++-v3/src/c++98/ios.cc
trunk/libstdc++-v3/src/c++98/iostream-inst.cc
trunk/libstdc++-v3/src/c++98/istream-inst.cc
trunk/libstdc++-v3/src/c++98/ostream-inst.cc
trunk/libstdc++-v3/src/c++98/sstream-inst.cc
trunk/libstdc++-v3/src/c++98/streambuf-inst.cc
Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/config/abi/pre/gnu.ver
trunk/libstdc++-v3/config/io/basic_file_stdio.h
trunk/libstdc++-v3/include/bits/basic_ios.h
trunk/libstdc++-v3/include/bits/fstream.tcc
trunk/libstdc++-v3/include/bits/ios_base.h
trunk/libstdc++-v3/include/bits/move.h
trunk/libstdc++-v3/include/ext/stdio_filebuf.h
trunk/libstdc++-v3/include/ext/stdio_sync_filebuf.h
trunk/libstdc++-v3/include/std/fstream
trunk/libstdc++-v3/include/std/ios
trunk/libstdc++-v3/include/std/istream
trunk/libstdc++-v3/include/std/ostream
trunk/libstdc++-v3/include/std/sstream
trunk/libstdc++-v3/include/std/streambuf
trunk/libstdc++-v3/include/std/utility
trunk/libstdc++-v3/src/c++11/Makefile.am
trunk/libstdc++-v3/src/c++11/Makefile.in
trunk/libstdc++-v3/src/c++98/Makefile.am
trunk/libstdc++-v3/src/c++98/Makefile.in
trunk/libstdc++-v3/src/c++98/ext-inst.cc
trunk/libstdc++-v3/src/c++98/misc-inst.cc
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/53626] [C++11] move assignment for ifstream
2012-06-10 19:46 [Bug c++/53626] New: move assignment for ifstream mikhail_semenov at hotmail dot com
` (3 preceding siblings ...)
2014-09-22 13:34 ` redi at gcc dot gnu.org
@ 2014-09-22 13:45 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-09-22 13:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53626
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for GCC 5
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-22 13:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-10 19:46 [Bug c++/53626] New: move assignment for ifstream mikhail_semenov at hotmail dot com
2012-06-10 21:20 ` [Bug c++/53626] [C++11] " redi at gcc dot gnu.org
2013-06-22 19:11 ` [Bug libstdc++/53626] " paolo.carlini at oracle dot com
2014-09-19 10:58 ` redi at gcc dot gnu.org
2014-09-22 13:34 ` redi at gcc dot gnu.org
2014-09-22 13:45 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).