public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/53668] New: Do some Cray-pointer fixes
@ 2012-06-14  9:08 burnus at gcc dot gnu.org
  2015-08-28 20:47 ` [Bug fortran/53668] " fxcoudert at gcc dot gnu.org
  2015-08-28 20:52 ` [Bug fortran/53668] Cray-pointer diagnostic enhancement fxcoudert at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-06-14  9:08 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53668

             Bug #: 53668
           Summary: Do some Cray-pointer fixes
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Keywords: diagnostic, missed-optimization
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org


Based on PR 53667.

a) Currently, FREE() and MALLOC() call via iresolve.c the
libgfortran/intrinsic/malloc.c's functions. One should call the builtins
instead - the library doesn't do anything different.


b) Passing an integer to a Cray pointer dummy should print a warning - both
when the explicit interface is known as well as via gsym.

Cray prints an error: 'The type of the actual argument, "INTEGER", does not
match "Cray pointer", the type of the dummy argument.'

But probably printing a warning is better - as the tricks in PR 53667 show:
Better to have an integer to a Cray pointer dummy than an integer dummy with an
address, which is only later converted to a Cray pointer.

! Compile with: -fcray-pointer
use iso_c_binding
implicit none
integer(c_intptr_t) :: intptr
call f(intptr)
 end
!contains
  subroutine f(p)
    pointer (p, i)
    integer :: i
  end subroutine f
!end


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug fortran/53668] Do some Cray-pointer fixes
  2012-06-14  9:08 [Bug fortran/53668] New: Do some Cray-pointer fixes burnus at gcc dot gnu.org
@ 2015-08-28 20:47 ` fxcoudert at gcc dot gnu.org
  2015-08-28 20:52 ` [Bug fortran/53668] Cray-pointer diagnostic enhancement fxcoudert at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2015-08-28 20:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53668

--- Comment #1 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Author: fxcoudert
Date: Fri Aug 28 20:46:43 2015
New Revision: 227311

URL: https://gcc.gnu.org/viewcvs?rev=227311&root=gcc&view=rev
Log:
        PR fortran/53668

        * intrinsic.c (add_functions, add_subroutines): Remove resolution
        functions for FREE and MALLOC.
        * intrinsic.h (gfc_resolve_malloc, gfc_resolve_free): Remove.
        * iresolve.c (gfc_resolve_malloc, gfc_resolve_free): Remove.
        * trans-intrinsic.c (conv_intrinsic_free,
        gfc_conv_intrinsic_malloc): New functions.

        * intrinsics/malloc.c: Adapt comments.

Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/intrinsic.c
    trunk/gcc/fortran/intrinsic.h
    trunk/gcc/fortran/iresolve.c
    trunk/gcc/fortran/trans-intrinsic.c
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/intrinsics/malloc.c


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug fortran/53668] Cray-pointer diagnostic enhancement
  2012-06-14  9:08 [Bug fortran/53668] New: Do some Cray-pointer fixes burnus at gcc dot gnu.org
  2015-08-28 20:47 ` [Bug fortran/53668] " fxcoudert at gcc dot gnu.org
@ 2015-08-28 20:52 ` fxcoudert at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: fxcoudert at gcc dot gnu.org @ 2015-08-28 20:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53668

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|missed-optimization         |
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-08-28
                 CC|                            |fxcoudert at gcc dot gnu.org
            Summary|Do some Cray-pointer fixes  |Cray-pointer diagnostic
                   |                            |enhancement
     Ever confirmed|0                           |1
           Severity|normal                      |enhancement


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-28 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-14  9:08 [Bug fortran/53668] New: Do some Cray-pointer fixes burnus at gcc dot gnu.org
2015-08-28 20:47 ` [Bug fortran/53668] " fxcoudert at gcc dot gnu.org
2015-08-28 20:52 ` [Bug fortran/53668] Cray-pointer diagnostic enhancement fxcoudert at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).